From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#27429: Stack clash (CVE-2017-1000366 etc); -fstack-check Date: Sun, 25 Jun 2017 12:41:06 +0200 Message-ID: <87o9tcnyd9.fsf@fastmail.com> References: <20170619222550.GA29289@jasmine.lan> <20170625113828.024a425f@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP4zX-0006Ug-DS for bug-guix@gnu.org; Sun, 25 Jun 2017 06:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP4zT-0000yL-40 for bug-guix@gnu.org; Sun, 25 Jun 2017 06:42:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dP4zS-0000y1-Ib for bug-guix@gnu.org; Sun, 25 Jun 2017 06:42:03 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20170625113828.024a425f@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic , 27429@debbugs.gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi, > > what do you all think of rebuilding the world with "-fstack-check" (either now or later on) ? > > That would make gcc emit code to always grow the stack in a way that it certainly touches each 4 KiB (parametrizable by STACK_CHECK_PROBE_INTERVAL_EXP) page on the way. > > I think that would be the right and permanent fix - unlike the whack-a-mole approach where we patch programs not to do what they are supposed to do, if their stack allocation happens to grow. > > See also and . Red Hat investigated this during the embargo[0] and found that the current implementation in GCC has problems[1]. We should wait until those issues are resolved first, but sounds good to me. [0] http://seclists.org/oss-sec/2017/q2/556 [1] http://seclists.org/oss-sec/2017/q2/505 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllPk0IACgkQoqBt8qM6 VPrYSQf/ZJHbkfiIRezbywXsiKt51BcKhOBIeoqYSx8BjuWB8eNnr2/mwuSAoOS3 nIISS5bwnYQib5JVvz6/LFoas+O5Fm8223+kC2DOiPBqkgAv9hCDs0/vwBK1vo/t DPMOTvq++w6oLjqsD8eiItIYwVT82xL3sGC7/b0i9v/g2fGyQjKneSaFYm/vtTTj NbrSNpqTd9fnV9r0n2+5jWRJYmED4k+bA5TyrkzkGhfvwyO1seNASBi+M2jF8wmu kVxIYNrIrH3hCVovs8I3Tygq6Bw8ubsS9q/W9BUNd+O1be5OofEMwwoyN2wzbhiL Y2IywpXlFWPGYk4zxr8qp5zf3/nRrA== =XScB -----END PGP SIGNATURE----- --=-=-=--