From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#30116: [PATCH] `substitute' crashes when file contains NUL
	characters (core-updates)
Date: Tue, 16 Jan 2018 12:23:17 +0100
Message-ID: <87o9lu6o9m.fsf@gnu.org>
References: <87r2qrc3mq.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ebPLc-0001PP-CB
	for bug-guix@gnu.org; Tue, 16 Jan 2018 06:24:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ebPLW-0007wt-Qf
	for bug-guix@gnu.org; Tue, 16 Jan 2018 06:24:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:50227)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ebPLW-0007wn-MH
	for bug-guix@gnu.org; Tue, 16 Jan 2018 06:24:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ebPLW-00012a-GS
	for bug-guix@gnu.org; Tue, 16 Jan 2018 06:24:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30116.B30116.15161018013952@debbugs.gnu.org>
In-Reply-To: <87r2qrc3mq.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 14
	Jan 2018 20:27:57 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 30116@debbugs.gnu.org

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> I've encountered the following crash when trying to use substitute on a
> file which contains NUL characters:

Yes, that=E2=80=99s because Guile=E2=80=99s =E2=80=98regexp-exec=E2=80=99 s=
imply wraps libc=E2=80=99s =E2=80=98regexec=E2=80=99,
which does not handle NULs.

We should consider switching to the pure-Scheme SRFI-115:

  https://srfi.schemers.org/srfi-115/srfi-115.html

Ludo=E2=80=99.