From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 30270@debbugs.gnu.org
Subject: bug#30270: [PATCH] url-fetch returns #t instead of FILE
Date: Sat, 27 Jan 2018 12:35:44 -0500 [thread overview]
Message-ID: <87o9lf6w7j.fsf@gmail.com> (raw)
In-Reply-To: <87vafn6whf.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 27 Jan 2018 12:29:48 -0500")
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hello!
>
> Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t
> instead of the file name (as the docstring says it should), which broke
> the fiasco script used to find broken hashes of Github's archives[0].
>
> Patch to follow.
^
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-download-Fix-return-value-of-the-url-fetch-procedure.patch --]
[-- Type: text/x-patch, Size: 992 bytes --]
From 61ca016f3a2a6504d899a6ec3b9daaf1647be451 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Sat, 27 Jan 2018 12:22:11 -0500
Subject: [PATCH] download: Fix return value of the url-fetch procedure.
Fixes #30270 which was introduced by commit 347fa4aebf.
* guix/build/download.scm (url-fetch): Return `file' instead of #t upon success.
---
guix/build/download.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/build/download.scm b/guix/build/download.scm
index 609a10053..1b630a9d6 100644
--- a/guix/build/download.scm
+++ b/guix/build/download.scm
@@ -770,7 +770,7 @@ otherwise simply ignore them."
#:reporter (progress-reporter/file
(uri-abbreviation uri) size))
(newline)))
- #t)))
+ file)))
((ftp)
(false-if-exception* (ftp-fetch uri file
#:timeout timeout)))
--
2.16.0
next prev parent reply other threads:[~2018-01-27 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 17:29 bug#30270: [PATCH] url-fetch returns #t instead of FILE Maxim Cournoyer
2018-01-27 17:35 ` Maxim Cournoyer [this message]
2018-01-28 22:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9lf6w7j.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=30270@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).