unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Chris Marusich <cmmarusich@gmail.com>
To: 32478-done@debbugs.gnu.org
Subject: bug#32478: pcscd service activation causes boot failure
Date: Mon, 20 Aug 2018 21:52:19 -0700	[thread overview]
Message-ID: <87o9dwmid8.fsf@gmail.com> (raw)
In-Reply-To: <87bm9xdniy.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 20 Aug 2018 18:13:25 +0200")

[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]

Hi Ludo and Arun,

ludo@gnu.org (Ludovic Courtès) writes:

>> ERROR: In procedure dynamic-func:
>> In procedure dynamic-pointer: Symbol not found: strverscmp
>
> This is because (guix utils) pulls in lots of things that are not really
> meant to be used on the “build side” (a misnomer in this case, but you
> see what I mean ;-)).  Here, it assumes that dlopen support is available
> but it’s not because the activation snippet runs on the
> statically-linked Guile.

That makes sense.  I keep forgetting about this.  :-) Thank you for
reminding me!

> I think “TODO: Deduplicate” would be enough as a comment, or at least
> something more concise like “XXX: We cannot use (guix utils) because it
> requires a dynamically-linked Guile, hence the duplicate
> ‘switch-symlinks’.”  I leave it up to you!

Yes, I agree.  I'll simplify the comment.  I included the long comment
mainly in the hopes that somebody would be able to help me understand
why it wasn't working.

Arun Isaac <arunisaac@systemreboot.net> writes:

>> Commit de30205ba0f63eb987097a9f47b6e4fd38cd9044 added a pcscd service
>> (hooray!).  However, its activation procedure doesn't always work.  The
>> system test passes, and the activation procedure works the first time
>> you boot, but if you reboot, it will fail because the symlink it creates
>> already exists.  The attached patch fixes the problem.
>
> Thanks for catching and fixing this! I am still in the process of
> building and testing your patch. I ran out of memory and had to `guix
> gc' and rebuild again. As you said, it takes a while. But, your patch
> LGTM. Please go ahead and push to master at your discretion, after
> addressing Ludo's feedback.

OK!  I've rewritten the comment as Ludo suggested and committed this to
master as 6fb6ac6857df31c55a640eead2a5f79edd7dab14.

Now, I'll close this bug report.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-08-21  4:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  7:26 bug#32478: pcscd service activation causes boot failure Chris Marusich
2018-08-20 16:13 ` Ludovic Courtès
2018-08-21  4:52   ` Chris Marusich [this message]
2018-08-20 19:33 ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9dwmid8.fsf@gmail.com \
    --to=cmmarusich@gmail.com \
    --cc=32478-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).