From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#33100: [libssh] fatal: dumb http transport does not support shallow capabilities Date: Wed, 24 Oct 2018 09:01:07 -0400 Message-ID: <87o9bj33e4.fsf@gmail.com> References: <87zhv94as1.fsf@gmail.com> <87in1w90iu.fsf@gnu.org> <87va5w3rtj.fsf@gmail.com> <875zxupapd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFInc-0003of-9J for bug-guix@gnu.org; Wed, 24 Oct 2018 09:02:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFInS-0000Ta-R9 for bug-guix@gnu.org; Wed, 24 Oct 2018 09:02:12 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFInS-0000TR-N2 for bug-guix@gnu.org; Wed, 24 Oct 2018 09:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gFInS-0000LF-Dy for bug-guix@gnu.org; Wed, 24 Oct 2018 09:02:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <875zxupapd.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 22 Oct 2018 11:55:26 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33100-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >> Perhaps just clearer messages would have helped here also ('Failed to do >> a shallow git clone due to ~error message~, falling back to a full clone= '). > > I agree, and that=E2=80=99s something to suggest to the Git folks. :-) Upon further inspection, we can do better on our side, specifically by printing a message of the fallback occurring when calling git-fetch. The patch below implements this simple change. What do you think? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-build-git-fetch-Print-message-when-falling-back-to-a.patch >From 06ba66d1949ba59573518f471ad3cbacefea6ea2 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 24 Oct 2018 08:49:50 -0400 Subject: [PATCH] build: git-fetch: Print message when falling back to a full checkout. Otherwise the user might believe that git-fetch stalled, observing the lack of output following a 'fatal' git error message (see: https://debbugs.gnu.org/33100). * guix/build/git.scm (git-fetch): Print message when falling back to a full checkout. --- guix/build/git.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/guix/build/git.scm b/guix/build/git.scm index 14d415a6f..df8f1548b 100644 --- a/guix/build/git.scm +++ b/guix/build/git.scm @@ -45,6 +45,7 @@ recursively. Return #t on success, #f otherwise." (if (zero? (system* git-command "fetch" "--depth" "1" "origin" commit)) (invoke git-command "checkout" "FETCH_HEAD") (begin + (format #t "Failed to do a shallow fetch; retrying a full fetch...~%") (invoke git-command "fetch" "origin") (invoke git-command "checkout" commit))) (when recursive? -- 2.19.0 --=-=-= Content-Type: text/plain Maxim --=-=-=--