From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#33266: guix-copy: Honor the SSH port of a host when defined in
	~/.ssh/config
Date: Tue, 06 Nov 2018 15:12:44 +0100
Message-ID: <87o9b21ehv.fsf@gnu.org>
References: <87a7mo5de4.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46629)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gK28r-0001lp-O4
	for bug-guix@gnu.org; Tue, 06 Nov 2018 09:15:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gK26I-0001JD-1T
	for bug-guix@gnu.org; Tue, 06 Nov 2018 09:13:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:60149)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gK26H-0001Ip-Uf
	for bug-guix@gnu.org; Tue, 06 Nov 2018 09:13:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gK26H-0007IL-OT
	for bug-guix@gnu.org; Tue, 06 Nov 2018 09:13:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33266.B33266.154151358128038@debbugs.gnu.org>
In-Reply-To: <87a7mo5de4.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 04
	Nov 2018 23:58:27 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 33266@debbugs.gnu.org

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> From 942eb8cabef5b7c8b4425c765b6ee2ac9f529ad8 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Sun, 4 Nov 2018 23:35:16 -0500
> Subject: [PATCH] Revert "copy: Default to port 22."
>
> This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.  Specifying=
 a
> default port had the undesirable effect of disregarding a port specificat=
ion
> for a given host in the ~/.ssh/config that would otherwise have been hono=
red
> at the time `open-ssh-session' calls the `session-parse-config!' method.
>
> In any case, `make-session' will default the port value of the created se=
ssion
> to 22 if left unspecified.

This looks good, and indeed it=E2=80=99s an unintended consequence of commit
cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.

However, the log of commit cc1dfc had this:

   Failing to do that, "%p" would be "0" when using "ProxyCommand"
   in ~/.ssh/config.

This is arguably a defect in either Guile-SSH or (more likely) libssh,
and it would be nice to report it.

Would you like to report it upstream?

Thanks,
Ludo=E2=80=99.