From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#33497: [PATCH] Re: bug#33497: Our CMake package has no documentation Date: Mon, 11 Mar 2019 21:33:17 -0400 Message-ID: <87o96glvvm.fsf@gmail.com> References: <8736rp649l.fsf@apteryx.i-did-not-set--mail-host-address--so-tickle-me> <87y39h4pfk.fsf@gmail.com> <878sykiwwq.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:40876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3WIt-00063t-Vh for bug-guix@gnu.org; Mon, 11 Mar 2019 21:34:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3WIs-000154-Q0 for bug-guix@gnu.org; Mon, 11 Mar 2019 21:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54328) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3WIs-00014u-Iv for bug-guix@gnu.org; Mon, 11 Mar 2019 21:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h3WIs-00030t-C4 for bug-guix@gnu.org; Mon, 11 Mar 2019 21:34:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <878sykiwwq.fsf@fastmail.com> (Marius Bakke's message of "Tue, 12 Feb 2019 21:17:41 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 33497@debbugs.gnu.org Hello Marius! Sorry for the delay. Marius Bakke writes: > Hello! > > Now would be the time to get this in 'core-updates'. > > Maxim Cournoyer writes: > >> Maxim Cournoyer writes: >> >>> Hello, >>> >>> Our CMake package lacks any documentation (manpage or other). Patch to >>> follow. >>> >>> Maxim >> >> Here's the patch to be merged in core-updates (or core-updates-next). >> >> From 07625983cd901c94e4ac25b157035c95e33a115e Mon Sep 17 00:00:00 2001 >> From: Maxim Cournoyer >> Date: Sun, 25 Nov 2018 01:39:54 -0500 >> Subject: [PATCH] gnu: cmake: Generate the documentation. >> >> This fixes https://bugs.gnu.org/33497. >> >> * gnu/packages/cmake.scm (gnu): Use the (gnu package python) and >> (gnu packages texinfo) modules. >> (cmake)[configure]: Add arguments to configure so that manual pages, info and >> HTML documentation is generated. >> [move-html-doc]: New phase. >> [native-inputs]: Add the native inputs required for building the >> documentation. >> [outputs]: Add a "doc" output. > > I'm not very comfortable with pulling python-sphinx into the dependency > closure of CMake, because then we can't update it or its dependencies > outside of the 'core-updates' cycle. It could also cause circular > dependency issues down the road. > > Would it make sense to build the documentation as a separate package? > In that case it can go on the master branch. I don't like the idea of having a separate package for the documentation of cmake because it goes against the expectations of Guix users (package comes with its manpage, and extra doc can be installed as extra output of the same package). Maybe we could have a "cmake-minimal" package we'd keep hidden and use by default as part of the cmake-build-system, which wouldn't include the doc, and the regular, user facing cmake would be the one in this patch? Maxim