unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#35655: Installer: mount error using btrfs on already formatted partition
@ 2019-05-09 16:42 Giovanni Biscuolo
  2019-05-13 21:51 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Giovanni Biscuolo @ 2019-05-09 16:42 UTC (permalink / raw)
  To: 35655

Hello,

summary: AFAIU the installer lacks "force" formatting when using btrfs,
using "mkfs.btrfs -f <device>" solved the problem (see below)


I'm using Guix 1.0.0 installer on bare-metal

selecting "Manual" in "Partitioning method" (I'd like to keep the other
partitions), setting /dev/sda5 this way:

--8<---------------cut here---------------start------------->8---
                             
    ┌─────────────────┤ Partition edit ├─────────────────┐                                                                      
    │                                                    │                                                                      
    │ You are currently editing partition 5.             │                                                                      
    │                                                    │                                                                      
    │         ┌────────────────────────────────┐         │                                                                      
    │         │ Name: guix                   ↑ │         │                                                                      
    │         │ Filesystem type: btrfs       ▒ │         │                                                                      
    │         │ ESP flag: Off                ▒ │         │                                                                      
    │         │ Encryption: No               ▒ │         │                                                                      
    │         │ Format the partition? : Yes  ▒ │         │                                                                      
    │         │ Mount point : /              ▒ │         │                                                                      
    │         │                              ▒ │         │                                                                      
--8<---------------cut here---------------end--------------->8---

and confirming this setting with "OK":

--8<---------------cut here---------------start------------->8---

   │ ┌──────────────────────────────────────────────────────────────────────────┐ │                                                         
   │ │ ATA HGST HTS725050A7 (scsi) /dev/sda 500GB gpt                         ↑ │ │                                                         
   │ │ ┣━  1 1046MB ntfs  diag                Basic data partition            ▮ │ │                                                         
   │ │ ┣━  2 346MB  fat32 boot,esp /boot/efi  EFI system partition            ▒ │ │                                                         
   │ │ ┣━  3 16.8MB       msftres             Microsoft reserved partition    ▒ │ │                                                         
   │ │ ┣━  4 26.4GB ntfs  msftdata            Basic data partition            ▒ │ │                                                         
   │ │ ┗━  5 472GB  btrfs          /          guix                            ▒ │ │                                                         
   │ │                                                                        ▒ │ │   
--8<---------------cut here---------------end--------------->8---

I confirm to format the disk (shoud be formatted btrfs, but the
operation is too quick and probably skipped) and proceed with
the rest of the installation

at the end of the configuration, I get this error:

--8<---------------cut here---------------start------------->8---

   │                                                                                                                                                               │                 
   │  The installer has encountered an unexpected problem. The backtrace is displayed below. Please report it by email to <bug-guix@gnu.org>.                      │                 
   │                                                                                                                                                               │                 
   │ In ice-9/boot-9.scm:                                                                                                                                        ↑ │                 
   │     829:9 19 (catch _ _ #<procedure 358b0a0 at ./gnu/installer/step…> …)                                                                                    ▮ │                 
   │     829:9 18 (catch _ _ #<procedure 358b050 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 17 (catch _ _ #<procedure 358b000 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 16 (catch _ _ #<procedure 36948c0 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 15 (catch _ _ #<procedure 3694410 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 14 (catch _ _ #<procedure 36943c0 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 13 (catch _ _ #<procedure 358be60 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 12 (catch _ _ #<procedure 358be10 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │     829:9 11 (catch _ _ #<procedure 358bdc0 at ./gnu/installer/step…> …)                                                                                    ▒ │                 
   │ In ./gnu/installer/steps.scm:                                                                                                                               ▒ │                 
   │    177:21 10 (_)                                                                                                                                            ▒ │                 
   │ In ./gnu/installer/newt/final.scm:                                                                                                                          ▒ │                 
   │     95:10  9 (run-final-page _ _)                                                                                                                           ▒ │                 
   │ In srfi/srfi-1.scm:                                                                                                                                         ▒ │                 
   │     640:9  8 (for-each #<procedure 7fc3527c9b28 at ./gnu/installer/…> …)                                                                                    ▒ │                 
   │ In ./guix/build/syscalls.scm:                                                                                                                               ▒ │                 
   │     488:8  7 (_ _ _ _ _ _ #:update-mtab? _)                                                                                                                 ▒ │                 
   │ In ice-9/boot-9.scm:                                                                                                                                        ▒ │                 
   │    751:25  6 (dispatch-exception 10 system-error ("mount" "mount …" …))                                                                                     ▒ │                 
   │ In ice-9/eval.scm:                                                                                                                                          ▒ │                 
   │     619:8  5 (_ #(#(#<directory (guile-user) 192e140> #<<instal…>) …))                                                                                      ▒ │                 
   │     619:8  4 (_ #(#(#(#<directory (guile-user) 192e140> #<<i…>) …) #))                                                                                      ▒ │                 
   │ In ice-9/ports.scm:                                                                                                                                         ▒ │                 
   │    462:17  3 (call-with-output-file _ _ #:binary _ #:encoding _)                                                                                            ▒ │                 
   │ In ice-9/eval.scm:                                                                                                                                          ▒ │                 
   │     619:8  2 (_ #(#(#<directory (guile-user) 192e140> # ("mo…" …)) #))                                                                                      ▒ │                 
   │     159:9  1 (_ #(#(#<directory (guile-user) 192e140> # ("mo…" …)) #))                                                                                      ▒ │                 
   │ In unknown file:                                                                                                                                            ▒ │                 
   │            0 (make-stack #t)                                                                                                                                ▒ │                 
   │ ice-9/eval.scm:159:9: In procedure mount: mount "/dev/sda5" on "/mnt/": Invalid argument                                                                    ▒ │                 
   │                                                                                                                                                             ▒ │                 
--8<---------------cut here---------------end--------------->8---

checking the filesystem type via "lsblk -f" I see that sda5 is still ext4:

--8<---------------cut here---------------start------------->8---
NAME   FSTYPE  LABEL      UUID                                 MOUNTPOINT
sda                                                            
[...]                     

├─sda2 vfat               7A61-DB20                            

[...]

└─sda5 ext4               90a30416-4d5b-4ba9-a9e8-3371ea8d2df3 
--8<---------------cut here---------------end--------------->8---

I tested the installer several times on this hardware using ext4 and the
installation process always succedes

the relevant logs from /var/logs/messages are:

--8<---------------cut here---------------start------------->8---
May  9 18:08:52 localhost vmunix: [ 4378.645672] raid6: avx2x4   gen() 34743 MB/s
May  9 18:08:52 localhost vmunix: [ 4378.713670] raid6: avx2x4   xor() 20040 MB/s
May  9 18:08:52 localhost vmunix: [ 4378.781671] raid6: avx2x2   gen() 30636 MB/s
May  9 18:08:52 localhost vmunix: [ 4378.849670] raid6: avx2x2   xor() 18818 MB/s
May  9 18:08:52 localhost vmunix: [ 4378.917669] raid6: avx2x1   gen() 26294 MB/s
May  9 18:08:52 localhost vmunix: [ 4378.985669] raid6: avx2x1   xor() 17949 MB/s
May  9 18:08:52 localhost vmunix: [ 4379.053670] raid6: sse2x4   gen() 19128 MB/s
May  9 18:08:52 localhost vmunix: [ 4379.121671] raid6: sse2x4   xor() 11860 MB/s
May  9 18:08:52 localhost vmunix: [ 4379.189669] raid6: sse2x2   gen() 16237 MB/s
May  9 18:08:52 localhost vmunix: [ 4379.257670] raid6: sse2x2   xor() 10489 MB/s
May  9 18:08:53 localhost vmunix: [ 4379.325671] raid6: sse2x1   gen() 13656 MB/s
May  9 18:08:53 localhost vmunix: [ 4379.393671] raid6: sse2x1   xor()  9574 MB/s
May  9 18:08:53 localhost vmunix: [ 4379.393672] raid6: using algorithm avx2x4 gen() 34743 MB/s
May  9 18:08:53 localhost vmunix: [ 4379.393672] raid6: .... xor() 20040 MB/s, rmw enabled
May  9 18:08:53 localhost vmunix: [ 4379.393684] raid6: using avx2x2 recovery algorithm
May  9 18:08:53 localhost vmunix: [ 4379.395980] xor: automatically using best checksumming function   avx       
May  9 18:08:53 localhost vmunix: [ 4379.705400] Btrfs loaded, crc32c=crc32c-intel
--8<---------------cut here---------------end--------------->8---

so I guess the installer tries to mount /dev/sda5 using brtfs but it
fails because it's not btrfs formatted

as a dirty hack, I restarted the installer and right after the
formatting confirmation dialog I switched to a console and formatted it
"manually" with:

--8<---------------cut here---------------start------------->8---
root@gnu ~# mkfs.btrfs /dev/sda5 
btrfs-progs v4.20.2 
See http://btrfs.wiki.kernel.org for more information.

/dev/sda5 appears to contain an existing filesystem (ext4).
ERROR: use the -f option to force overwrite of /dev/sda5
--8<---------------cut here---------------end--------------->8---

this probably explains why the filesystem is not formatted by the
installer: please consider it's usual to reuse old partitions when
installing on a used disk :-)

so I forced formatting:

--8<---------------cut here---------------start------------->8---
root@gnu ~# mkfs.btrfs -f /dev/sda5 
btrfs-progs v4.20.2 
See http://btrfs.wiki.kernel.org for more information.

Label:              (null)
UUID:               f0ef2920-41d4-4bd4-bee8-f04b1adcb7c8
Node size:          16384
Sector size:        4096
Filesystem size:    439.89GiB
Block group profiles:
  Data:             single            8.00MiB
  Metadata:         DUP               1.00GiB
  System:           DUP               8.00MiB
SSD detected:       no
Incompat features:  extref, skinny-metadata
Number of devices:  1
Devices:
   ID        SIZE  PATH
    1   439.89GiB  /dev/sda5
--8<---------------cut here---------------end--------------->8---

I returned to the installer console and the installation finished
succesfully

sorry I'm not able to find where is the code used by the installer to
format the disk, cannot propose a patch

HTH! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#35655: Installer: mount error using btrfs on already formatted partition
  2019-05-09 16:42 bug#35655: Installer: mount error using btrfs on already formatted partition Giovanni Biscuolo
@ 2019-05-13 21:51 ` Ludovic Courtès
  2019-05-13 23:17   ` Danny Milosavljevic
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2019-05-13 21:51 UTC (permalink / raw)
  To: Giovanni Biscuolo; +Cc: 35655

Hi Giovanni,

Giovanni Biscuolo <g@xelera.eu> skribis:

> summary: AFAIU the installer lacks "force" formatting when using btrfs,
> using "mkfs.btrfs -f <device>" solved the problem (see below)

I believe the patch at <https://issues.guix.info/issue/35657> fixes it.
Danny?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#35655: Installer: mount error using btrfs on already formatted partition
  2019-05-13 21:51 ` Ludovic Courtès
@ 2019-05-13 23:17   ` Danny Milosavljevic
  2019-05-15 12:36     ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2019-05-13 23:17 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 35655

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi Ludo,

On Mon, 13 May 2019 23:51:46 +0200
Ludovic Courtès <ludo@gnu.org> wrote:

> Giovanni Biscuolo <g@xelera.eu> skribis:
> 
> > summary: AFAIU the installer lacks "force" formatting when using btrfs,
> > using "mkfs.btrfs -f <device>" solved the problem (see below)  
> 
> I believe the patch at <https://issues.guix.info/issue/35657> fixes it.
> Danny?

I haven't tested it but it should work.

I've pushed that patch to master now.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#35655: Installer: mount error using btrfs on already formatted partition
  2019-05-13 23:17   ` Danny Milosavljevic
@ 2019-05-15 12:36     ` Ludovic Courtès
  2019-05-15 17:12       ` Giovanni Biscuolo
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2019-05-15 12:36 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 35655-done

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Mon, 13 May 2019 23:51:46 +0200
> Ludovic Courtès <ludo@gnu.org> wrote:
>
>> Giovanni Biscuolo <g@xelera.eu> skribis:
>> 
>> > summary: AFAIU the installer lacks "force" formatting when using btrfs,
>> > using "mkfs.btrfs -f <device>" solved the problem (see below)  
>> 
>> I believe the patch at <https://issues.guix.info/issue/35657> fixes it.
>> Danny?
>
> I haven't tested it but it should work.
>
> I've pushed that patch to master now.

I’ve tested it and I confirm that it successfully creates and mounts a
btrfs partition.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#35655: Installer: mount error using btrfs on already formatted partition
  2019-05-15 12:36     ` Ludovic Courtès
@ 2019-05-15 17:12       ` Giovanni Biscuolo
  2019-05-15 17:33         ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Giovanni Biscuolo @ 2019-05-15 17:12 UTC (permalink / raw)
  To: Ludovic Courtès, Danny Milosavljevic; +Cc: 35655-done

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

[...]

> I’ve tested it and I confirm that it successfully creates and mounts a
> btrfs partition.

I've tested also (on bare-metal) and it works now!

kudos, Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#35655: Installer: mount error using btrfs on already formatted partition
  2019-05-15 17:12       ` Giovanni Biscuolo
@ 2019-05-15 17:33         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2019-05-15 17:33 UTC (permalink / raw)
  To: Giovanni Biscuolo; +Cc: 35655-done

Giovanni Biscuolo <g@xelera.eu> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
> [...]
>
>> I’ve tested it and I confirm that it successfully creates and mounts a
>> btrfs partition.
>
> I've tested also (on bare-metal) and it works now!

Awesome, thanks for testing!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-05-15 17:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-09 16:42 bug#35655: Installer: mount error using btrfs on already formatted partition Giovanni Biscuolo
2019-05-13 21:51 ` Ludovic Courtès
2019-05-13 23:17   ` Danny Milosavljevic
2019-05-15 12:36     ` Ludovic Courtès
2019-05-15 17:12       ` Giovanni Biscuolo
2019-05-15 17:33         ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).