From: "Ludovic Courtès" <ludo@gnu.org>
To: 39725-done@debbugs.gnu.org
Subject: bug#39725: /gnu/store/.links: base16 or base32?
Date: Sat, 22 Feb 2020 01:00:23 +0100 [thread overview]
Message-ID: <87o8trze20.fsf@gnu.org> (raw)
In-Reply-To: <87h7zj1ue7.fsf@inria.fr> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22\?\= \=\?utf-8\?Q\?'s\?\= message of "Fri, 21 Feb 2020 22:51:28 +0100")
Ludovic Courtès <ludo@gnu.org> skribis:
> (guix store deduplication) uses base16, but optimize-store.cc does:
>
> /* Check if this is a known hash. */
> Path linkPath = linksDir + "/" + printHash32(hash);
>
> … where ‘printHash32’ returns a nix-base32 string. Oops!
Fixed in 4cb63a564d413c745983a608790a943ac07f8d67.
prev parent reply other threads:[~2020-02-22 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:51 bug#39725: /gnu/store/.links: base16 or base32? Ludovic Courtès
2020-02-22 0:00 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8trze20.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39725-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).