From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eM02EQIjbmCPbgAAgWs5BA (envelope-from ) for ; Wed, 07 Apr 2021 23:24:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QEb8CQIjbmBuDgAAbx9fmQ (envelope-from ) for ; Wed, 07 Apr 2021 21:24:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 647161C9CF for ; Wed, 7 Apr 2021 23:24:17 +0200 (CEST) Received: from localhost ([::1]:44804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUFep-00070l-Fw for larch@yhetil.org; Wed, 07 Apr 2021 17:24:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUFec-0006xp-7w for bug-guix@gnu.org; Wed, 07 Apr 2021 17:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUFeb-00086J-Vo for bug-guix@gnu.org; Wed, 07 Apr 2021 17:24:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUFeb-0006es-RX for bug-guix@gnu.org; Wed, 07 Apr 2021 17:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47569: =?UTF-8?Q?=E2=80=98qt-build-system=E2=80=99?= retains too many references via wrappers Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 07 Apr 2021 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47569 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 47569-submit@debbugs.gnu.org id=B47569.161783061125558 (code B ref 47569); Wed, 07 Apr 2021 21:24:01 +0000 Received: (at 47569) by debbugs.gnu.org; 7 Apr 2021 21:23:31 +0000 Received: from localhost ([127.0.0.1]:45476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUFe6-0006e9-Jq for submit@debbugs.gnu.org; Wed, 07 Apr 2021 17:23:30 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:35453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUFe4-0006dx-LZ for 47569@debbugs.gnu.org; Wed, 07 Apr 2021 17:23:28 -0400 Received: by mail-qk1-f173.google.com with SMTP id i9so130492qka.2 for <47569@debbugs.gnu.org>; Wed, 07 Apr 2021 14:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eU+kJk6fXkaLQXD+qzRc56PiqhCX77DKqphFjuftnKE=; b=LCthgorlU6j5blfdPpiSVG5/fldsiOGaca6rJX9tOX+ysitb0JBgTCxUSY4L5DZZE/ RfUht+Hb69e2Pnh0bsrsNXbXYau+P7zafwBjNH+gh/nlPNYOQoOreo65j34enTlK7ysg 0Taji+TVUQna+eJ3uvSLzJhKH2/naoK3DooIxSCRqbH6/PzPEawZpc7nFTw1l89EdQjv E2fKrrf6tzvcwrqSwXgqobKJoQU75rJEtTGxYgloljHdntAf1+L4I2OO2b5IfmFfgGml 24nUxuuQ7PlfZyoUTO0cmqjtS5Uz0YtUrsmCzXDRMYBlKghX6o+tpuwbisgJCHHeRm89 cduQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eU+kJk6fXkaLQXD+qzRc56PiqhCX77DKqphFjuftnKE=; b=mDwWRtO0XK8eJrx2+zr6JBsLJMXFiK/c7ew8MqwM0cqvFqGKqNHOHpv8Gm2/e6cpLd 7rQSKPD8vS65D09iWi5/e+CqhPLD/L6CCX4KEakecdyJTKpCmYjXkGsOhzP3VnkEl4vc JMnTyHx/nDLslrM9vXpjVfqnnvCw5uqTuzonUz2Mh8IdOOocIW//R5msvmAkhwMep7m/ eksa4Df+HcjExdJJ/oRfseyK8kVD1HKRqHqD0GU5FtEZK3+Ztih+yoBszi0tNBk96DzK Bb0ewFGeq9k2Ld34NPotEIMlt+0s/SkDcsMewTaFqg7a96TUPB3Ld0pelWcI9IqYR6w8 uVGA== X-Gm-Message-State: AOAM533VHV8wglg9jKtM9C+aRYgNC6lBRqHH4ZN3/r0mUbOrwzsRgs9d 2jnh0pmkDseWh8tm2c5P1HlflEUPHMI= X-Google-Smtp-Source: ABdhPJwyY02OGgeOqjVNsvzeIOD2RYzMjWvEXpGvH02weDa3SRcwxXVIy6qfvW9VMNesPvT0qF6hTA== X-Received: by 2002:a05:620a:205e:: with SMTP id d30mr5052510qka.380.1617830603044; Wed, 07 Apr 2021 14:23:23 -0700 (PDT) Received: from hurd (mtl.savoirfairelinux.net. [208.88.110.46]) by smtp.gmail.com with ESMTPSA id c5sm19139342qkl.21.2021.04.07.14.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 14:23:22 -0700 (PDT) From: Maxim Cournoyer References: <87czvczbsv.fsf@inria.fr> <87blaurbya.fsf@gmail.com> <878s5wseaz.fsf@gnu.org> <87r1jnmu0v.fsf@gnu.org> <87zgybl35g.fsf@gnu.org> <87sg41n6xm.fsf@gmail.com> Date: Wed, 07 Apr 2021 17:23:21 -0400 In-Reply-To: <87sg41n6xm.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 07 Apr 2021 17:03:33 -0400") Message-ID: <87o8epn60m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47569@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617830657; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eU+kJk6fXkaLQXD+qzRc56PiqhCX77DKqphFjuftnKE=; b=B76AaYGcJfyipHUsK4FLBVXnPa8qhjtflsKjLISerX2pTvg6Xv+lVjKAOyEJce9UdT2HhI MAY1xim8EOGAR0Nn2SzyRAG8bzVP9v5UJYvfBO+ZK2s94OPowTbhvrvabrKuadC3az6LTO yfKgb2eVexTLWhnLiZ7RCiQeAwbmf3QfbIeLt+q3HZfL/aL86FvkWPsJ0p+9uuGFm9/iIM FE+chDOK2ePoFsZpT3ZXJGuNCOm4xbaBSAmHv/7EnniUIaZAar0Ksrk+idtUiC5EqehExV UvDERu6/mq3RM4i+woBJpK+RLzpyyq7qo+cumcJNAGl8Em3kEHBoQ4a6OgWK3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617830657; a=rsa-sha256; cv=none; b=ZlXT4FE9UMuAaoWA2o0I9IC1mYgdXJGbDSNxd413mYe+b+FXIr5MCqTtaAtm8FnMdLsITp ZGU9mYd6A+okTHMjYZZpL2gu6AVzIVVbgHVPhDori/Wvx+fJmo4uSNWeJ86RyskRZQgJRJ c3F8fTVMLKQDfdDPxgLSmrXvYiPPhNwW3THkDG/JpIhR7wcVtWY1dKZxnb4BdC7F9KVurf yvMiDXYDBJmu+HPVeMwf8rQd8XbhCTqbk5lT0uNMmS51Nl013CJxm/wcEYD7VzLHf+eDcl XDt2Z/jvoDAmZztZRhQ1NHj/GzF9cLxdknzcFyovDRmLZe9Ommya9fUaLYkYHg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=LCthgorl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=LCthgorl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 647161C9CF X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: bFR+Re6bPz/9 Maxim Cournoyer writes: > Seeing a growing number of packages require a custom wrap phase for > qtwebengine, I think the following additions could make sense to be > incorporated as part as this Qt-world rebuild: > > 2 files changed, 5 insertions(+), 1 deletion(-) > gnu/packages/qt.scm | 3 +++ > guix/build/qt-build-system.scm | 3 ++- > > modified gnu/packages/qt.scm > @@ -538,6 +538,9 @@ system, and the core design of Django is reused in Grantlee.") > (search-path-specification > (variable "QT_PLUGIN_PATH") > (files '("lib/qt5/plugins"))) > + (search-path-specification > + (variable "QTWEBENGINEPROCESS_PATH") > + (files '("lib/qt5/libexec/QtWebEngineProcess"))) > (search-path-specification > (variable "XDG_DATA_DIRS") > (files '("share"))) Actually, scratch that part above, as there's already a search path defined on the qtwebengine package, and it's more correctly defined as: (native-search-paths (list (search-path-specification (file-type 'regular) (separator #f) (variable "QTWEBENGINEPROCESS_PATH") (files '("lib/qt5/libexec/QtWebEngineProcess"))))) So what I proposed above is not needed. > modified guix/build/qt-build-system.scm > @@ -86,7 +86,8 @@ > "/cursors" "/wallpapers" "/icons" "/mime") > '("XDG_CONFIG_DIRS" "/etc/xdg") > '("QT_PLUGIN_PATH" "/lib/qt5/plugins") > - '("QML2_IMPORT_PATH" "/lib/qt5/qml")))) > + '("QML2_IMPORT_PATH" "/lib/qt5/qml") > + '("QTWEBENGINEPROCESS_PATH" "lib/qt5/libexec/QtWebEngineProcess")))) > > (define* (wrap-all-programs #:key inputs outputs > (qt-wrap-excluded-outputs '()) Still is still useful I think, but I noticed now it needs a leading slash in from of the lib/qt5/libexec above. Thanks, Maxim