From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CID3G5xQh2BqGAEAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 01:45:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YMLKF5xQh2AyGQAA1q6Kng (envelope-from ) for ; Mon, 26 Apr 2021 23:45:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0BEF1AA14 for ; Tue, 27 Apr 2021 01:45:31 +0200 (CEST) Received: from localhost ([::1]:47646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbAuv-0005MD-68 for larch@yhetil.org; Mon, 26 Apr 2021 19:45:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbAuV-0005M5-Bo for bug-guix@gnu.org; Mon, 26 Apr 2021 19:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbAuU-0002it-BE for bug-guix@gnu.org; Mon, 26 Apr 2021 19:45:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbAuU-0003q1-7d for bug-guix@gnu.org; Mon, 26 Apr 2021 19:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#48050: Pinebook Pro LCD and Audio support Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 26 Apr 2021 23:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48050 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 48050@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161948065514671 (code B ref -1); Mon, 26 Apr 2021 23:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 23:44:15 +0000 Received: from localhost ([127.0.0.1]:47484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbAti-0003oX-KW for submit@debbugs.gnu.org; Mon, 26 Apr 2021 19:44:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:49246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbAte-0003oN-4C for submit@debbugs.gnu.org; Mon, 26 Apr 2021 19:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbAtd-0005JO-OU for bug-guix@gnu.org; Mon, 26 Apr 2021 19:44:09 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:33628) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbAtV-00028g-HN for bug-guix@gnu.org; Mon, 26 Apr 2021 19:44:09 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 9E5D51AF05; Mon, 26 Apr 2021 16:43:53 -0700 (PDT) From: Vagrant Cascadian Date: Mon, 26 Apr 2021 16:43:49 -0700 Message-ID: <87o8e0mx1m.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619480731; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post; bh=PGEPckoue3Uhsiayln4Kq0y+TCf9jMJFvszrxYHIj9k=; b=Nfne1Vpr2HNFVrk9R+l+SkuuzFty79+u9a4QRTcW6HK5rVbJsshWLIvM0oIiBrGPxj6kBo MhFkmEEV/BMUOEPfppdK4j28Vw0THAGRp7Zkgmx591hqpyEQbNDl16rV8rtiwzcidkwHea araR9h0DmaHMTTgbMo65ri0sikAvVRcc5OidwbEJSg7lr0tn8w3KGZw6PQXnYafxBso7sn 2A+ueqzJjrq3XxX+JHK1SjOuKHS1UvxEW/eLz0CZPbx/yHzn0DTQAQ8Hcr/1YjcCs5+ARQ g/6NOqDOX3u9CVOV2g/b32/RmSYf+axpT6u4yelldishQ6FI5WxZXvbkeOEC9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619480731; a=rsa-sha256; cv=none; b=g5LEGkcStx6mHWRwAARNj8RflDLH/OasvKsO839PFSz2vGY4Enb6rUSrAnSylpuQ6bJMAn fMwtIE5u0DqD3pJW5SI9bb8jYeD+G5LiL8BOspGya5B9M4IHUxr6z7zXWAHtITl3fdhmYB U6RcPk2/Fx682qijVkJ4FUKvE/KDDHlWfiKeatcZvBisxY6ZCtMJ0k3QCwdJyyXQLvQiNf xT9BugetI3MYK5I/7+eAlUvvow2QCp8M3CEFuhAbWH3XYhF9teHwX2IUjA5/heLA3Nf3lT f/o6iBLHLW7P9+1quplCJuf33I5HAYAXk9Q16xCHvRh75RwB4/dJPoCrjRoGYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -4.05 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: B0BEF1AA14 X-Spam-Score: -4.05 X-Migadu-Scanner: scn0.migadu.com X-TUID: ejbmG8fBS+us --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The attached patch enables support for LCD display and limited audio support for pinebook-pro-rk3399. With this, the Pinebook Pro gets display output on the built-in LCD. Console works, wayland works (tested with sway), presumably X.org would work as well (untested). Audio output on headphones kind of works. Trackpad is still a little sketchy; might require enabling some more modules. This should basically obsolete the need for the wip-pinebook-pro branch; I haven't noticed any significant functionality difference. I believe the same patches and changes apply and work more-or-less unchanged for linux-libre 5.10 lts series (I tested against Debian's 5.10.x kernel), and it might be worth having an LTS kernel with this enabled. If that's considered desireable, I can update the patch to add that too. Since this will require rebuilding the linux-libre tarball, it is probably best to wait to merge this until the next batch of linux-libre updates (e.g. linux-libre 5.11.x and 5.10.x, no need to wait till 5.12). If USB-C DisplayPort ever becomes supported and working on pinebook-pro, this patch will need to be removed. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-linux-libre-Add-LCD-and-sound-support-for-Pinebo.patch Content-Transfer-Encoding: quoted-printable From=20478b620eb4f52e76bde691262ebc793e4e3fd384 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 26 Apr 2021 09:27:50 -0700 Subject: [PATCH] gnu: linux-libre: Add LCD and sound support for Pinebook P= ro. * gnu/packages/linux.scm (linux-libre-5.11-source): Add Pinebook Pro lcd patch. (linux-libre-arm64-generic): Enable audio module for Pinebook Pro. * gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch: New fi= le. * gnu/local.mk (dist_patch_DATA): Add patch. =2D-- gnu/local.mk | 1 + gnu/packages/linux.scm | 9 ++++- ...nux-libre-arm64-generic-pinebook-lcd.patch | 40 +++++++++++++++++++ 3 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/linux-libre-arm64-generic-pinebook= -lcd.patch diff --git a/gnu/local.mk b/gnu/local.mk index e8b6effb36..5a2ae6ef48 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1369,6 +1369,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/linkchecker-tests-require-network.patch \ %D%/packages/patches/linphone-desktop-without-sdk.patch \ %D%/packages/patches/linux-libre-support-for-Pinebook-Pro.patch \ + %D%/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch \ %D%/packages/patches/linux-pam-no-setfsuid.patch \ %D%/packages/patches/lirc-localstatedir.patch \ %D%/packages/patches/lirc-reproducible-build.patch \ diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 080ffab527..1c6e1502b2 100644 =2D-- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -481,7 +481,10 @@ corresponding UPSTREAM-SOURCE (an origin), using the g= iven DEBLOB-SCRIPTS." (define-public linux-libre-5.11-source (source-with-patches linux-libre-5.11-pristine-source (list %boot-logo-patch =2D %linux-libre-arm-export-__sync_icache_dcach= e-patch))) + %linux-libre-arm-export-__sync_icache_dcache-= patch + ;; Pinebook Pro patch to fix LCD display + (search-patch + "linux-libre-arm64-generic-pinebook-lcd.patc= h")))) =20 (define-public linux-libre-5.10-source (source-with-patches linux-libre-5.10-pristine-source @@ -1044,7 +1047,9 @@ It has been modified to remove all non-free binary bl= obs.") ("CONFIG_BATTERY_AXP20X" . m) ("CONFIG_PINCTRL_AXP209" . m) ("CONFIG_AXP20X_POWER" . m) =2D ("CONFIG_AXP20X_ADC" . m)) + ("CONFIG_AXP20X_ADC" . m) + ;; Pinebook PRO sound support + ("CONFIG_SND_SOC_ES8316" . m)) %default-extra-linux-options))) =20 (define-public linux-libre-arm64-generic-5.10 diff --git a/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.pa= tch b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch new file mode 100644 index 0000000000..51ab544d5e =2D-- /dev/null +++ b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch @@ -0,0 +1,40 @@ +From 3a75704e99a118f2d8a4d70f07781558bde85770 Mon Sep 17 00:00:00 2001 +From: Jian-Hong Pan +Date: Thu, 24 Sep 2020 14:30:43 +0800 +Subject: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort + +The cdn-dp sub driver probes the device failed on PINEBOOK Pro. + +kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missi= ng extcon or phy +kernel: cdn-dp: probe of fec00000.dp failed with error -22 + +Then, the device halts all of the DRM related device jobs. For example, +the operations: vop_component_ops, vop_component_ops and +rockchip_dp_component_ops cannot be bound to corresponding devices. So, +Xorg cannot find the correct DRM device. + +The USB type-C DisplayPort does not work for now. So, disable the +DisplayPort node until the type-C phy work has been done. + +Link: https://patchwork.kernel.org/patch/11794141/#23639877 +Signed-off-by: Jian-Hong Pan +--- + arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +index 219b7507a10f..45769764425d 100644 +--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts ++++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +@@ -380,7 +380,7 @@ + }; +=20 + &cdn_dp { +- status =3D "okay"; ++ status =3D "disabled"; + }; +=20 + &cpu_b0 { +--=20 +2.30.2 + =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYIdQNgAKCRDcUY/If5cW qh0lAQCz3curOzxZgqf81U6+0LRWXgNX3FOEqyxUmz4hFa+CHAEAg3Ts7q+BsA84 cpLdh8dHNoerZx8LCvljl4UG+Cn4PQY= =PXWu -----END PGP SIGNATURE----- --==-=-=--