From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AGc/BId9kWCCZwEAgWs5BA (envelope-from ) for ; Tue, 04 May 2021 18:59:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4OGJO4Z9kWDpDAAAB5/wlQ (envelope-from ) for ; Tue, 04 May 2021 16:59:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81CE51BBFA for ; Tue, 4 May 2021 18:59:50 +0200 (CEST) Received: from localhost ([::1]:51336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldyOj-0006YF-NB for larch@yhetil.org; Tue, 04 May 2021 12:59:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldy6Y-0005Sq-H6 for bug-guix@gnu.org; Tue, 04 May 2021 12:41:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldy6Y-0000HZ-7k for bug-guix@gnu.org; Tue, 04 May 2021 12:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldy6Y-0003L2-6F for bug-guix@gnu.org; Tue, 04 May 2021 12:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44675: guix lint: support for spellchecker or basic grammar Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 04 May 2021 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44675 X-GNU-PR-Package: guix X-GNU-PR-Keywords: easy To: Vagrant Cascadian Received: via spool by 44675-submit@debbugs.gnu.org id=B44675.162014643912817 (code B ref 44675); Tue, 04 May 2021 16:41:02 +0000 Received: (at 44675) by debbugs.gnu.org; 4 May 2021 16:40:39 +0000 Received: from localhost ([127.0.0.1]:54220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldy6B-0003Kf-6s for submit@debbugs.gnu.org; Tue, 04 May 2021 12:40:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldy69-0003KV-H0 for 44675@debbugs.gnu.org; Tue, 04 May 2021 12:40:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55699) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldy63-0008Tk-GG; Tue, 04 May 2021 12:40:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59960 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldy61-0005zi-70; Tue, 04 May 2021 12:40:29 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87ima6rrri.fsf@yucca> <87tunznsi7.fsf@yucca> <2f3077c0d040e4b40db19d98195845e124b064d3.camel@telenet.be> <87o8e6nqvv.fsf@yucca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 =?UTF-8?Q?Flor=C3=A9al?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 04 May 2021 18:40:27 +0200 In-Reply-To: <87o8e6nqvv.fsf@yucca> (Vagrant Cascadian's message of "Thu, 22 Apr 2021 10:57:56 -0700") Message-ID: <87o8dqmozo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44675@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620147590; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=s5l9wAe5i7oCMyczoe6YGWwDNMxJuyTaR8mtc2gfByA=; b=Ffcpdu6/YQdG7qMr61oWwtMT2XnnlHviCe9CN5kzG3I9S6hRVuXlkbE22OX1+JgSGqTDTg /9oQE8REPX3/XDHriEuVjmyNcDCGrsOzcf5J+p3UoxxDbyKRfV5D1VQppGVwA/H+aARcS6 VBuPaCnGeen5HlHIk7Bh1a23xSs87ZEsqELm1BnHNPNnilDxacsmJJqgwx2G1mzmi6te87 JA8e+zJ01441YZGvrXoZqTB2Yfqg1Zj13ztvUhQLY/uV4MdJNk6FghMN/MoX9U6/ZLwswj 3epAJ4FU2VUxpCqXA1Zw+Q6qNjQgZGK2P8NqHwBlquiGj7j/K/pOVTqSv4DjVQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620147590; a=rsa-sha256; cv=none; b=s8V0CcmyavgMrn1qTLtTRipFxllBI7R8IJEHC8y6p0qp5DA7aNVLOdjTlSqIot6/7bj8Du ZWGSF3OMaPL/RmEQEZtkBVOYiyS98vHXEqu+lYZEd7GPG/1+D8yV3Dska05rHKxrqrWzcu l3GtPyu4AzULTS3QjQWhtiLNx26n2J18vaK8V+6VUvfPeo67F7xk3Pvjrp1Lhj8VmYTqEY muKMiHtvyrz97uhunAWR21UQeM6Xui9YjnTNqtqKWLUyW8ppTnfrkU3RYlQh75dj1dRJ++ BX1A0vc07Xwn9A9oJx73UYbu4WUaqSGktCFkmXIWjOF0+O4dQtObY6FE8NCcWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 81CE51BBFA X-Spam-Score: -2.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: Zk3tgCmhYTPQ Hi Vagrant, Vagrant Cascadian skribis: > From 4e724fbe9815e1c27967b835f08d2259164538ba Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Wed, 21 Apr 2021 09:26:45 -0700 > Subject: [PATCH] lint: Add description check for pluralized "This package" > > Partial fix for: https://issues.guix.gnu.org/44675 > > * guix/lint.scm (check-pluralized-this-package): Add check for > occurances of "This packages" in package descriptions. > * tests/lint.scm: Add test. I had missed this patch, nice! > + (define (check-pluralized-this-package description) > + "Check that DESCRIPTION does not contain 'This packages'" > + (if (string-match "This packages" description) > + (list > + (make-warning package > + (G_ "description contains 'This packages' but should just be 'T= his package'"))) > + '())) How about making this =E2=80=98check-spelling=E2=80=99 and generalizing a b= it so that it iterates over a bunch of regexps or strings? Like: (if (any (cut string-contains description <>) patterns) =E2=80=A6) where =E2=80=98patterns=E2=80=99 is a list of strings. (Note that =E2=80=98string-match=E2=80=99 invokes libc=E2=80=99s regcomp + = regexec, so it=E2=80=99s more heavyweight than needed here.) Thanks, Ludo=E2=80=99.