From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wE9NOVgPN2KNUQAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 12:26:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KOKlNlgPN2IyMAEA9RJhRA (envelope-from ) for ; Sun, 20 Mar 2022 12:26:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EBAA28FA0 for ; Sun, 20 Mar 2022 12:26:16 +0100 (CET) Received: from localhost ([::1]:57152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVthP-00015m-Hc for larch@yhetil.org; Sun, 20 Mar 2022 07:26:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVthC-000157-F2 for bug-guix@gnu.org; Sun, 20 Mar 2022 07:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVthC-0006D2-6u for bug-guix@gnu.org; Sun, 20 Mar 2022 07:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVthB-0002Nt-To for bug-guix@gnu.org; Sun, 20 Mar 2022 07:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Roman Scherer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 11:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Received: via spool by 50329-submit@debbugs.gnu.org id=B50329.16477755549151 (code B ref 50329); Sun, 20 Mar 2022 11:26:01 +0000 Received: (at 50329) by debbugs.gnu.org; 20 Mar 2022 11:25:54 +0000 Received: from localhost ([127.0.0.1]:32930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVth4-0002NX-7e for submit@debbugs.gnu.org; Sun, 20 Mar 2022 07:25:54 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVth0-0002NH-VA for 50329@debbugs.gnu.org; Sun, 20 Mar 2022 07:25:52 -0400 Received: by mail-wr1-f51.google.com with SMTP id j18so7686621wrd.6 for <50329@debbugs.gnu.org>; Sun, 20 Mar 2022 04:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=1pfoxI7QJ1eKoFn2SlLYAvAKcdl9AEwlWLg3UNYriPY=; b=wHVHnUdpOyRmzmyGV0QIOv7U3twV6BFk+le/KoTsBkIduemONcTHodE3j/t2dH+vW6 B5XBxSR/LjA4lUctlZ92UlYuzIIb0jMWrFqelmdIc+B9RKJQCwnBoIIhG39xZuu2i6Tx vVXpf1evh1Dbq1a/5pvLdFxhSV/gnD6LjqCpPsPlBO3his5fz1ZflVMJNYoAwrKzif2t hK5wa6KV5c569bbKBSIb/IZz8AQMVrnv2rrm47qfrqrol5wu41WWzeFUZyShUHzRUeCP zPqEVMwr9tZDERkzqA+fs0tjSND5vQhEB19DI4ef7zbRushCdhkgAK+J87Ddeefv2jRb KTaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=1pfoxI7QJ1eKoFn2SlLYAvAKcdl9AEwlWLg3UNYriPY=; b=6U2yQ876fUzc5OJH1/W06k0P34S0vy251XMn6AMLVWyeK7dD1TlRKD0QPQB4gMOoAh Pq+wFXS0g7qBEwRyYd3lahLbBYLz678Soj0AnHnKaqfbh+0uN1E0pvU6BLB5C5F5h5pP eBbMY0A5LMLn4HbUMkts7gQK+s8T3reNPdYp/gBi2C1NKg8vt0OpKSOqs32AjPFr0O68 sKaor+4o9w3fB2n2sB3ZDMl9KXLafe3YQMrICNZXu5kaKNKvNp8ApRCoKFgQhr5A9+ut WiLZ9n6dMQA22XN+fFl8dizctOLG3NfCjLmALlb1PK8w9ghPmfOD6MB4pPw+RdvNJP/P A33w== X-Gm-Message-State: AOAM532QgNixbVvXnzeqrv66NmKuqyvN0k1Fd5o7SekJwWypAWbN4OZN mWO9JQP9FLL+x3vEsztEFHbcuUdcgH1zl8KV X-Google-Smtp-Source: ABdhPJyDSQwRQj/9+R2f3iJRQjNf1pjqfXD2ntxhVONIt4DokrQgraHMNkDokjn4HyB/pI2k/WZ7dg== X-Received: by 2002:adf:e103:0:b0:1f1:d893:9bf5 with SMTP id t3-20020adfe103000000b001f1d8939bf5mr14635602wrz.263.1647775544473; Sun, 20 Mar 2022 04:25:44 -0700 (PDT) Received: from thinkpad (tmo-116-11.customers.d1-online.com. [80.187.116.11]) by smtp.gmail.com with ESMTPSA id o11-20020adf9d4b000000b001f0077ea337sm10675998wre.22.2022.03.20.04.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 04:25:44 -0700 (PDT) References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> <87wngp6l7n.fsf@burningswell.com> <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> <87sfrc7vqw.fsf@burningswell.com> User-agent: mu4e 1.6.10; emacs 28.0.50 From: Roman Scherer Date: Sun, 20 Mar 2022 12:21:34 +0100 In-reply-to: Message-ID: <87o8207tmx.fsf@burningswell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou , 50329@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647775576; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1pfoxI7QJ1eKoFn2SlLYAvAKcdl9AEwlWLg3UNYriPY=; b=REHvn6erR/oTAY5eI5cgYO7oqV2/xZBidpEsWED4sOT6DFfd3zZbArC7FBQVxDD7wmkK4s mpeOJGxPScS5FITaalIp4U1Da8ZTWYwL+OfsyW7PmiUhpIFORfL0/kShUw6In8e/lXFx/E 4P44aEaPRVYxmhbD/SnDit9hi7yKHjJbW+syDXBpfaNZJmScVbIa3fYBlFuj27gh3NhZft JVqNW/WIieXzuaq1A8NsmrTo5p/GYlCWDnyqxoo+rsg1vOkyaprIInI/pajz75/UB8sNd/ TXumFrgHTMbSrusH3FymlVG0g/UAvs3KsU/lARwxKpc4dkJ1IiGqGACoYllSow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647775576; a=rsa-sha256; cv=none; b=vATvVv5ibTxzgQ6afPjKrpZbbWHyMVSQqyJFNhaMBAxB8u++EBdicPmVw1v8rbRxsJLnU+ M/a551j7FTb9LWX1jRcf3qt8ANt5n+zLst8Q2l+gljy3efC6EMYEpwjVFz0BSe2hLUrVgS BagPWPfguoPK4EDwizMonu9edzMsZgvWtki9XKEzN/6EezZkGpTXZWbsg61Z7lwTazY1m4 CwaDgM7duopgKKwAKj3d4k6mzGSxanyf+9Wxm/sL9a4Wjy3DncDiHtiKa2CXTOP5pSJlF+ TL6/ZgJtz3mVD8mdbzIBm5cpjAnBKcdbQBnnUFQa0/qbms+h2lOaeUmwR+EynA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=wHVHnUdp; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=wHVHnUdp; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9EBAA28FA0 X-Spam-Score: -2.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2oUnv8VIeXY1 --=-=-= Content-Type: text/plain Hi Liliana, thanks for adding the comment locally. I just checked the source of LSP Treemacs and yes, they are all mentioned by name here: https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L38 Is this a problem? Should the build script remove them? If that's the case, we could remove all those "icon themes" and just leave this "Iconless" theme in the file: https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L209 Roman Liliana Marie Prikler writes: > Hi Roman, hi Maxime, > > Am Sonntag, dem 20.03.2022 um 11:35 +0100 schrieb Roman Scherer: >> Hi Maxime, >> >> ok, I see. Thanks for the explanation. I attached a patch that >> removes the icons from the source as per your suggestion. >> >> What do you think about this one? >> >> Thanks, Roman. > The logic behind your patch LGTM, but it lacks an explanatory comment. > Don't worry about resending the patch, though -- I already added the > comment locally and am currently looking to also apply this to emacs- > company-box. If either of you could check whether those icons are > referred to by name in emacs-lsp-treemacs while I'm working on company- > box, that'd be appreciated. > > Cheers --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmI3DzYfHHJvbWFuLnNj aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmeX8CAC8JYXLUQZ2lNOw AGENNNw3NnzDUb9Pt3OC19qZCX6RjZFqt0vmHvD8WCJLUwIRo/qLmXkdkoULgekH pqBrCLQbORuZtazPCW+r9Y01bZz7vmGAaQDVHdFZbMM2HFRQeBHmw57v5jiTYz37 U53/3+h3XRzIf+3UXrfwpYujNnJ+c3WLcI+I09eIwdKgcMO0PLnf7sFIzyZO0R3C FuM0He9W7mYPmSRUTdKBZgqAMAFw9fMMnjDJDH0V0SSxDoi36qfqNjwmr1qPrm/u OGWHTgL4JLwABdBHdGlUcDcA3qTqok/cGmdX3bVXY7mey5HGLBXmQQpJxqfYhqQ1 +eLNVAWJ =FiUh -----END PGP SIGNATURE----- --=-=-=--