From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +E1JINUuTWMB7wAAbAwnHQ (envelope-from ) for ; Mon, 17 Oct 2022 12:30:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QHkrINUuTWOwwAAAauVa8A (envelope-from ) for ; Mon, 17 Oct 2022 12:30:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35563A670 for ; Mon, 17 Oct 2022 12:30:45 +0200 (CEST) Received: from localhost ([::1]:39690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okNOO-0004hC-Ak for larch@yhetil.org; Mon, 17 Oct 2022 06:30:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okNNk-0004a7-Lz for bug-guix@gnu.org; Mon, 17 Oct 2022 06:30:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okNNk-00042z-Bz for bug-guix@gnu.org; Mon, 17 Oct 2022 06:30:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okNNj-0001az-5W for bug-guix@gnu.org; Mon, 17 Oct 2022 06:30:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58419: Grafting order depends on store connection state Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 17 Oct 2022 10:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58419 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Josselin Poiret Cc: 58419@debbugs.gnu.org Received: via spool by 58419-submit@debbugs.gnu.org id=B58419.16660025506045 (code B ref 58419); Mon, 17 Oct 2022 10:30:03 +0000 Received: (at 58419) by debbugs.gnu.org; 17 Oct 2022 10:29:10 +0000 Received: from localhost ([127.0.0.1]:47432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okNMr-0001ZR-OS for submit@debbugs.gnu.org; Mon, 17 Oct 2022 06:29:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okNMi-0001Yn-CD for 58419@debbugs.gnu.org; Mon, 17 Oct 2022 06:29:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okNMc-0003uk-Q9; Mon, 17 Oct 2022 06:28:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=32tzlPv9/FdouSmoQMLFe+n6Yl9/lLCTF3qkOT40luc=; b=gtEo47ad5lONk7c1Ghur /pMeOcWTY2k0afaLmldj/u5Jd2AfzhRxq8xqmQOyshhRPIyyB13l5mWHEmOLbavz5wiGhyFrqU/IL I5OKykwdBNP2Wt792EDii+T/E9duvemBKBqh2qVvXfyosKuuCfU0bUALSEK089o9s5i0bDMqH/tV8 LWMrO+9XF7C14gH4f+9mYaNnFxb2W4tkSuKg3dWUPZt5dO5MnRI+xpeEGlCFk1rcrS8rdirLezDqz 2EltDyiwU49ItCkVRDwhZbTnd8c6nYmU0nDKa2vN8hWEHqNbvPeCMHEohoJPgso5dU6m2fYW4wdIA h8GN8PpM5ehZgQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=58044 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okNMc-0006BJ-C0; Mon, 17 Oct 2022 06:28:54 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87o7ujjwm1.fsf@jpoiret.xyz> <87wn92la9e.fsf@gnu.org> Date: Mon, 17 Oct 2022 12:28:51 +0200 In-Reply-To: <87wn92la9e.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 14 Oct 2022 17:01:33 +0200") Message-ID: <87o7uaspzw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666002645; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=32tzlPv9/FdouSmoQMLFe+n6Yl9/lLCTF3qkOT40luc=; b=eGz4Zhj1ybc4v5U5SzE6z1Rm9zFPYiMyMviUa2WzzrJqRXSjwbLm8jnC1V2NPJKC2hHZ8d 4oBC+/Q2T+tqL/U9UT2o3aYUkBhfeysWQwZl/wBVsE7A6E56vcshgy78Zk3cESBShu6gdb AW/jKWBEjtgxTainq6UdAahvxw+NLi35TfCrhVrdynZZlpKvcLaikkKyxLWX6AQjF7itAj P1T1CFwYkZSOB0tAOI1rnd5qcGjMMdn2I6W2GEf4keYavdJq/ij+RfeB88G/0rIjV5zjZ0 Ne3cn5DZ/2wdUBKsn88MZVjj3Z4pVaZXbsjf+2imcNRpA840AoNGmNLqA9eUOQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666002645; a=rsa-sha256; cv=none; b=AAywhhzFKgX0T4c+L4TUbgUrsf2yqyyRyORG8dwK+juWVnO8XFPTzwJXtABboYDLesQD78 6zeKjSrYaYw7XwOfRwK52MIKKnwUmyGTYlI/DnvIy5TRZ+G9GOiEVGOCUQg8rpm1JhaX9t yzeH4VmWqwH5HGWC0ehOHBa6agO12lpeuAYsS4K/sJSOO3m9EZjuDz9/QpuH0oZa0/T7pQ o5ZnXaRbrNiPPHOB4CrAYSzyRetf75CS0HttIyfYBOmNxYO5VRHoOTijocIQ6Ap29HcPmT Z70hJwITe65dRvo7qy8j87lYqQ5Lm0gkoJiC7TEBoEVelMhSJnoCkd0twHDedA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gtEo47ad; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gtEo47ad; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 35563A670 X-Spam-Score: -4.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: uCRbdAAbG5bD Hi, Ludovic Court=C3=A8s skribis: > If we squint a bit, we realize it=E2=80=99s the same thing but in a diffe= rent > order, which is good news: it=E2=80=99s functionally equivalent. > > The downside is obvious: it=E2=80=99s stupidly non-deterministic, and we = can end > up building the same grafts multiple times. > > The order differs in two places: in the definition of =E2=80=98%build-inp= uts=E2=80=99, > and in the definition of the =E2=80=98mapping=E2=80=99 variable. This ca= n be solved by > sorting things in the right place, but that needs some thought. I posted a patch series that fixes this as a side-effect of switching to =E2=80=98gexp->derivation=E2=80=99: https://issues.guix.gnu.org/58579 That eliminates =E2=80=98%build-inputs=E2=80=99, which was one source of di= fferences, and the =E2=80=98mapping=E2=80=99 variable is now populated in a determinis= tic fashion, though I must say it=E2=80=99s not entirely clear to me why this part has changed. Feedback welcome! Ludo=E2=80=99.