bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Morgan Smith]

Hello!

Ever since commit 1f466ed6be932526fc69e72ffd50390691d0d382 we don't look
at the user's value of QT_PLUGIN_PATH.  The comment says this is to
prevent plugin confusion between Qt5 and Qt6 stuff.

This is very unfortunate for me.  I have qtwayland (qt5) installed in my
profile so QT programs can find the wayland plugin they need to display
themselves on wayland.  Unfortunately, they no longer can.

Maybe we could make our own Guix environment variables like
GUIX_QT5_QT_PLUGIN_PATH and GUIX_QT6_QT_PLUGIN_PATH and then add those
to the wrapper?  So like qtwayland would set GUIX_QT5_QT_PLUGIN_PATH and
then the wrapper in qt-utils.scm could read that?  Just an idea, I have
no clue what a good solution for this issue looks like.

Thanks,

Morgan

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Maxim Cournoyer]

[re-sending again, this time with debbugs in CC]

Hello,

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> Hello!
>
> Ever since commit 1f466ed6be932526fc69e72ffd50390691d0d382 we don't look
> at the user's value of QT_PLUGIN_PATH.  The comment says this is to
> prevent plugin confusion between Qt5 and Qt6 stuff.

Yes; unfortunately Qt doesn't seem to have thought about making that
variable usable with both Qt5 and Qt6 at the same time.  It's probably
worth reporting the issue upstream.

> This is very unfortunate for me.  I have qtwayland (qt5) installed in my
> profile so QT programs can find the wayland plugin they need to display
> themselves on wayland.  Unfortunately, they no longer can.

I see.

> Maybe we could make our own Guix environment variables like
> GUIX_QT5_QT_PLUGIN_PATH and GUIX_QT6_QT_PLUGIN_PATH and then add those
> to the wrapper?  So like qtwayland would set GUIX_QT5_QT_PLUGIN_PATH and
> then the wrapper in qt-utils.scm could read that?  Just an idea, I have
> no clue what a good solution for this issue looks like.

That could work for qt-build-system built packages, yes.  We could also
attempt to patch our Qt packages to honor these directly, if that's not
too difficult.  Then straightforward search paths could be defined for
them, and the wrapper in qt-utils adjusted.

Thanks,

Maxim

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Maxim Cournoyer]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> [re-sending again, this time with debbugs in CC]
>
> Hello,
>
> Morgan Smith <Morgan.J.Smith@outlook.com> writes:
>
>> Hello!
>>
>> Ever since commit 1f466ed6be932526fc69e72ffd50390691d0d382 we don't look
>> at the user's value of QT_PLUGIN_PATH.  The comment says this is to
>> prevent plugin confusion between Qt5 and Qt6 stuff.
>
> Yes; unfortunately Qt doesn't seem to have thought about making that
> variable usable with both Qt5 and Qt6 at the same time.  It's probably
> worth reporting the issue upstream.

Reported upstream with https://bugreports.qt.io/browse/QTBUG-107459.

-- 
Thanks,
Maxim

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[kiasoc5 via Bug reports for GNU Guix]

Would it be possible to patch the wrapper before the Guix 1.4.0 release, 
or at least document somewhere that qt wayland is blocked by this bug?

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Marek Paśnikowski via Bug reports for GNU Guix]

Hello.

I found a piece of QT documentation on handling of plugins [1].

Is it helpful to achieving working Plasma Desktop on Guix?

Maxim - I was able to only find your email address; I don't think the other participants of this Debbugs issue will receive a copy of this message.

Best Regards,
Marek Paśnikowski

[1]: https://doc.qt.io/qt-6.2/deployment-plugins.html#loading-and-verifying-plugins-dynamically

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Maxim Cournoyer]

Hi,

Marek Paśnikowski <marekpasnikowski@protonmail.com> writes:

> Hello.
>
> I found a piece of QT documentation on handling of plugins [1].
>
> Is it helpful to achieving working Plasma Desktop on Guix?
>
> Maxim - I was able to only find your email address; I don't think the
> other participants of this Debbugs issue will receive a copy of this
> message.
>
> Best Regards,
> Marek Paśnikowski
>
> [1]: https://doc.qt.io/qt-6.2/deployment-plugins.html#loading-and-verifying-plugins-dynamically

Thanks for the link.  According to it, there shouldn't be a problem a
problem mixing various Qt versions on the same QT_PLUGIN_PATH, as Qt is
supposed to not load plugins that were linked against a newer version,
or older major version.

If this was so, then it seems like the problem/concern I reported
upstream https://bugreports.qt.io/browse/QTBUG-107459 could be
acknowledged and closed, but I'd like to have confirmation.  I've sent a
comment to the above ticket, hopefully we can get such confirmation.

-- 
Thanks,
Maxim

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Maxim Cournoyer]

Hello,

Marek Paśnikowski <marekpasnikowski@protonmail.com> writes:

> Hello.
>
> I found a piece of QT documentation on handling of plugins [1].
>
> Is it helpful to achieving working Plasma Desktop on Guix?
>
> Maxim - I was able to only find your email address; I don't think the
> other participants of this Debbugs issue will receive a copy of this
> message.
>
> Best Regards,
> Marek Paśnikowski
>
> [1]: https://doc.qt.io/qt-6.2/deployment-plugins.html#loading-and-verifying-plugins-dynamically

The upstream bug I had opened,
https://bugreports.qt.io/browse/QTBUG-107459, has now been closed as
"Believed not to be a problem.", so it's indeed supposed to work.

I'll try looking into reverting some of the changes made when Qt 6 was
introduced; there may be warnings, if I recall correctly, but since it's
advertised as something supported, let's put it to the test!

-- 
Thanks,
Maxim

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Maxim Cournoyer]

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> Marek Paśnikowski <marekpasnikowski@protonmail.com> writes:
>
>> Hello.
>>
>> I found a piece of QT documentation on handling of plugins [1].
>>
>> Is it helpful to achieving working Plasma Desktop on Guix?
>>
>> Maxim - I was able to only find your email address; I don't think the
>> other participants of this Debbugs issue will receive a copy of this
>> message.
>>
>> Best Regards,
>> Marek Paśnikowski
>>
>> [1]: https://doc.qt.io/qt-6.2/deployment-plugins.html#loading-and-verifying-plugins-dynamically
>
> The upstream bug I had opened,
> https://bugreports.qt.io/browse/QTBUG-107459, has now been closed as
> "Believed not to be a problem.", so it's indeed supposed to work.
>
> I'll try looking into reverting some of the changes made when Qt 6 was
> introduced; there may be warnings, if I recall correctly, but since it's
> advertised as something supported, let's put it to the test!

So I finally tried it in guix/build/qt-utils.scm:

--8<---------------cut here---------------start------------->8---
@@ -87,9 +88,7 @@ (define exists? (match file-type
       "/applications" "/cursors" "/fonts" "/icons" "/glib-2.0/schemas"
       "/mime" "/sounds" "/themes" "/wallpapers")
     '("XDG_CONFIG_DIRS" suffix directory "/etc/xdg")
-    ;; We wrap exactly to avoid potentially mixing Qt5/Qt6 components, which
-    ;; would cause warnings, perhaps problems.
-    `("QT_PLUGIN_PATH" = directory
+    `("QT_PLUGIN_PATH" prefix directory
       ,(format #f "/lib/qt~a/plugins" qt-major-version))
     `("QML2_IMPORT_PATH" = directory
       ,(format #f "/lib/qt~a/qml" qt-major-version))
--8<---------------cut here---------------end--------------->8---

And I see, as I had originally found:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix shell --pure qtwayland@5 qtbase@5 jami 

[...]

[env]$ echo $QT_PLUGIN_PATH 
/gnu/store/06r23gkwlkzgivf411sk231sbvy5ghcm-profile/lib/qt5/plugins
maxim@hurd ~/src/guix [env]$ jami   
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqeglfs.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqlinuxfb.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqminimal.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqminimalegl.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqoffscreen.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqvnc.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/rpn3knqgk81c27va7bxrpayv0dv5s4kr-qtwayland-5.15.8/lib/qt5/plugins/platforms/libqwayland-egl.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/rpn3knqgk81c27va7bxrpayv0dv5s4kr-qtwayland-5.15.8/lib/qt5/plugins/platforms/libqwayland-generic.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/rpn3knqgk81c27va7bxrpayv0dv5s4kr-qtwayland-5.15.8/lib/qt5/plugins/platforms/libqwayland-xcomposite-egl.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/rpn3knqgk81c27va7bxrpayv0dv5s4kr-qtwayland-5.15.8/lib/qt5/plugins/platforms/libqwayland-xcomposite-glx.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforms/libqxcb.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-maxim'
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platformthemes/libqgtk3.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platformthemes/libqxdgdesktopportal.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforminputcontexts/libcomposeplatforminputcontextplugin.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/platforminputcontexts/libibusplatforminputcontextplugin.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Using Qt runtime version: 6.3.2

(jami:9326): libnotify-WARNING **: 19:41:03.309: Failed to connect to proxy
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/imageformats/libqgif.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/imageformats/libqico.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/imageformats/libqjpeg.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
"Using locale: C"
19:41:03.438         os_core_unix.c !pjlib 2.12.1 for POSIX initialized
Daemon is running
No migration required
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/sqldrivers/libqsqlite.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/sqldrivers/libqsqlmysql.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/sqldrivers/libqsqlodbc.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/sqldrivers/libqsqlpsql.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Syncing lrc accounts list with the daemon
Cannot find dbus interface for screen saver
qt.core.qobject.connect: QObject::connect(lrc::api::ContactModel, ContactAdapter): unique connections require a pointer to member function of a QObject subclass
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/xcbglintegrations/libqxcb-egl-integration.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.core.plugin.loader: In /gnu/store/047ay09ng8kvvbk2h51hbm5mf7x4garg-qtbase-5.15.8/lib/qt5/plugins/xcbglintegrations/libqxcb-glx-integration.so:
  Plugin uses incompatible Qt library (5.15.0) [release]

[...]
--8<---------------cut here---------------end--------------->8---

But Jami runs fine anyway, so I guess it's noise we'll have to put up
with.  I'm merging this change and others to the staging branch now, if
you want to try it out in a day or two it should be fully built for
x86_64.

-- 
Thanks,
Maxim

bug#57742: [PATCH core-updates] build: qt-utils: Add prefix when wrapping QT_PLUGIN_PATH variable.

[Antero Mejr via Bug reports for GNU Guix]

This allows extension of QT_PLUGIN_PATH.
QT programs will now work under Wayland when qt-wayland is installed.

* guix/build/qt-utils.scm (variables-for-wrapping)[QT_PLUGIN_PATH]: Add prefix
value to 'wrap-program' procedure call for QT_PLUGIN_PATH variable.
---
Tested using Wayland and X (via XWayland), using plugin paths for QT5, QT6, or
both. In all cases, QT selects the correct plugin if it's present anywhere in
QT_PLUGIN_PATH.

 guix/build/qt-utils.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm
index 2e47f1bc02..b503659521 100644
--- a/guix/build/qt-utils.scm
+++ b/guix/build/qt-utils.scm
@@ -89,7 +89,7 @@ (define exists? (match file-type
     '("XDG_CONFIG_DIRS" suffix directory "/etc/xdg")
     ;; We wrap exactly to avoid potentially mixing Qt5/Qt6 components, which
     ;; would cause warnings, perhaps problems.
-    `("QT_PLUGIN_PATH" = directory
+    `("QT_PLUGIN_PATH" prefix directory
       ,(format #f "/lib/qt~a/plugins" qt-major-version))
     `("QML2_IMPORT_PATH" = directory
       ,(format #f "/lib/qt~a/qml" qt-major-version))
-- 
2.38.1

bug#57742: [PATCH core-updates] build: qt-utils: Add prefix when wrapping QT_PLUGIN_PATH variable.

[Antero Mejr via Bug reports for GNU Guix]

Please ignore the QT patch I just sent, it's exactly the same as yours,
and I sent it before I saw your message from 20 minutes ago.  Sorry!

When I tested the patch I didn't get any of that noise about "Plugin
uses incompatible Qt library", although the program I tested with may
have configured QT to be less verbose.

bug#57742: QT plugins from profile not found (QT_PLUGIN_PATH)

[Maxim Cournoyer]

Hi,

Antero Mejr <antero@mailbox.org> writes:

> This allows extension of QT_PLUGIN_PATH.
> QT programs will now work under Wayland when qt-wayland is installed.
>
> * guix/build/qt-utils.scm (variables-for-wrapping)[QT_PLUGIN_PATH]: Add prefix
> value to 'wrap-program' procedure call for QT_PLUGIN_PATH variable.
> ---
> Tested using Wayland and X (via XWayland), using plugin paths for QT5, QT6, or
> both. In all cases, QT selects the correct plugin if it's present anywhere in
> QT_PLUGIN_PATH.
>
>  guix/build/qt-utils.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm
> index 2e47f1bc02..b503659521 100644
> --- a/guix/build/qt-utils.scm
> +++ b/guix/build/qt-utils.scm
> @@ -89,7 +89,7 @@ (define exists? (match file-type
>      '("XDG_CONFIG_DIRS" suffix directory "/etc/xdg")
>      ;; We wrap exactly to avoid potentially mixing Qt5/Qt6 components, which
>      ;; would cause warnings, perhaps problems.
> -    `("QT_PLUGIN_PATH" = directory
> +    `("QT_PLUGIN_PATH" prefix directory
>        ,(format #f "/lib/qt~a/plugins" qt-major-version))
>      `("QML2_IMPORT_PATH" = directory
>        ,(format #f "/lib/qt~a/qml" qt-major-version))

Already fixed on my staging :-).

I'll merge staging into master as soon as it catches up to master
according to https://ci.guix.gnu.org/.  Help welcome!

-- 
Thanks,
Maxim