From: Christopher Baines <mail@cbaines.net>
To: Andreas Enge <andreas@enge.fr>
Cc: 69466@debbugs.gnu.org
Subject: bug#69466: Wrong colours for QA
Date: Mon, 22 Apr 2024 17:27:58 +0100 [thread overview]
Message-ID: <87o7a11hwx.fsf@cbaines.net> (raw)
In-Reply-To: <ZeBhRBe3IEuXRXkp@jurong> (Andreas Enge's message of "Thu, 29 Feb 2024 11:49:40 +0100")
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
Andreas Enge <andreas@enge.fr> writes:
> it looks like the dark green colour is wrongly chosen in QA,
> for instance here:
> https://qa.guix.gnu.org/issue/69441
> The issue has been reviewed, but "Comparison unavailable
> Yet to process revision".
>
> I think dark green should only appear when the package is reviewed
> AND builds correctly (so would be light green without reviewing).
When implementing this I chose to have the review trump any other status
since hopefully any failing builds will have been taken in to account by
the reviewer.
I think it's useful to highlight when there's a review regardless of the
other information that QA has.
1: https://git.savannah.gnu.org/cgit/guix/qa-frontpage.git/tree/guix-qa-frontpage/issue.scm#n163
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2024-04-22 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 10:49 bug#69466: Wrong colours for QA Andreas Enge
2024-04-22 16:27 ` Christopher Baines [this message]
2024-04-29 13:42 ` Andreas Enge
2024-04-29 14:29 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7a11hwx.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=69466@debbugs.gnu.org \
--cc=andreas@enge.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).