From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qLupCyNA32YeaQAAqHPOHw:P1 (envelope-from ) for ; Mon, 09 Sep 2024 18:36:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qLupCyNA32YeaQAAqHPOHw (envelope-from ) for ; Mon, 09 Sep 2024 20:36:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=f0aTkhpA; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=SrYtktSm; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725906979; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IKkStzDvKuxFypX1nQaL/TTbenHLVUI7yLMk7MCEOjQ=; b=DXpARMHY4nyXPWjuRvu4sEBarwc1v7e/Ku90kouew2Z3mABAEUzQ9XNnRwHlJF8ROip1QH RVVXCGrvj9O2Nb43Gzb9DJ1Pi8ZO7R82IZplNT0AEhqzSOaRNPXjmMyKlcn218uv4Y/Kjq ms4sZbnT0LiiQrwgGbEn/g5YsfoBlxTLzYH7YIU2M3btxsdKPNR8LT+DMSWTqS+Y4OO4A2 5F6eKD6ofXsJsU1FPnXqqddxUup9+sGGTzzqIRRGE9rAV4lmxjsqFFJRiItHHH7L4EJLE/ Obw1/cBL5bPZQNU3X6Gec7Sqoa/PbxhuZEiWfBLzuPteLTxuyTP5tfqkg2ZZhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=f0aTkhpA; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=SrYtktSm; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725906979; a=rsa-sha256; cv=none; b=dsNwCn7iLycXJ1abZe5UUp2kGGKF3MaUcAlOJfPnDxpyzq5XOdMdNCdXcmBLaVTK8H+XJp W6rTTSRb6nx7fzELmvOd6ADDCgucfnDXW4Lr6yYU50BLA3MKQBNazc0S9pUb6PfjxgxsD/ RQGcQKv86gDiCLLg86yVe0elk5LHvQVX3gTCiipxrDzlpggDIsLfUXKKVLH4ZBAE8+ZNeC chrkzYY+slCuiRdRZN926Fx5VT0aolo02QdXCTYRcNAXiIuVn6DC68fiNLPsWGesO3VXnX GM0EIDCLxcp09NPF2P42txvr1EaOp/UTk3NztvGHX0WgP5ESNiHYOGwEK//2kg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B10E978DFE for ; Mon, 09 Sep 2024 20:36:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snjF6-0003oP-FI; Mon, 09 Sep 2024 14:36:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snjF2-0003o3-E7 for bug-guix@gnu.org; Mon, 09 Sep 2024 14:36:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snjF0-0004oW-LT for bug-guix@gnu.org; Mon, 09 Sep 2024 14:35:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=IKkStzDvKuxFypX1nQaL/TTbenHLVUI7yLMk7MCEOjQ=; b=f0aTkhpA6BZsnN3QEkl4IRFSa62coYBso9aWqq/PBVKMCLXwA+nuo53xx7a2zeaz4TuHKwzAk3WqkrzqN3kRpdiZuA8nKuscy+58AyTM9+wAKQOmAhj3tL2qhy42j3OMPQ+lfCTPGXi51kXoHJO5Ye7D/8xVYrNfA6zxelhwNtgFdx58HLv6EQcXGkJ1jwFTPxt/yh4Vhvv7lS0YJxfNdWI8stwDFDmRrJXlANw3FXBGDcqRQfySmPWIgC3kyM5ydM8uFTwYtLRr5HvCILeII4mJ48n0y7ATnA+GKuV9b0MApTOLRWGQnbZA5zCMxFLdno+GKz6lN+sxKbGVuFAwfA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snjF4-0005en-GE for bug-guix@gnu.org; Mon, 09 Sep 2024 14:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#73081: installer crash: iso-codes is too old Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 09 Sep 2024 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73081 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ricardo Wurmus Cc: Mathieu Othacehe , Josselin Poiret , 73081@debbugs.gnu.org Received: via spool by 73081-submit@debbugs.gnu.org id=B73081.172590695821736 (code B ref 73081); Mon, 09 Sep 2024 18:36:02 +0000 Received: (at 73081) by debbugs.gnu.org; 9 Sep 2024 18:35:58 +0000 Received: from localhost ([127.0.0.1]:34154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snjF0-0005eU-EY for submit@debbugs.gnu.org; Mon, 09 Sep 2024 14:35:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snjEy-0005eF-MT for 73081@debbugs.gnu.org; Mon, 09 Sep 2024 14:35:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snjEp-0004l4-DY; Mon, 09 Sep 2024 14:35:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IKkStzDvKuxFypX1nQaL/TTbenHLVUI7yLMk7MCEOjQ=; b=SrYtktSmFP2q8uUvzij7 kzHBa7GtZ1L/Qcwx4wsiaOaubzb7Q74mbIWKD1PSsY4RNt/ALqm4kcE1AIhBasmLF4D8ctyECoYpY w6l0zuHFsqtHlgCXaMqoPJMSP9w7bclACEUPAvllX5XVrll2HVdcGV/EDZEMP0A4AbI+tvF9R2zvP 0tU4jZOnm39fq80pT079evR/Da8uho7hYlbUeUojg4GN/Cfq3YJwPy8hNvrkvUBtvfmyIjnXixuPj uRpAVMw8iZeIQV+viw68tnLWixEihOXDSaoQglI+lSSwb89iErAItw9GYKMnCX2Zr1BzGEPGYZYit W9/C62s4zpZhtQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <71c632b0e965df14ca7bf7994d43b2f97cad3d15.1725660077.git.rekado@elephly.net> (Ricardo Wurmus's message of "Sat, 7 Sep 2024 00:01:17 +0200") References: <875xr8myav.fsf@elephly.net> <71c632b0e965df14ca7bf7994d43b2f97cad3d15.1725660077.git.rekado@elephly.net> Date: Mon, 09 Sep 2024 20:35:43 +0200 Message-ID: <87o74wad4w.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.09 X-Migadu-Queue-Id: B10E978DFE X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.09 X-TUID: RS6pp5TY6r7A Hi, Ricardo Wurmus skribis: > * gnu/packages/iso-codes.scm (iso-codes/installer): New variable. > * gnu/installer.scm (compute-locale-step): Use it. > > Fixes . > Change-Id: Ibc37b3972f6eda14886543b30a72d3b890455d07 > > Change-Id: Ia06b776e861742fb108a41317ed6df13afec9b6f [...] > +(define-public iso-codes/installer > + (hidden-package > + (package > + (inherit iso-codes/official) Maybe rename =E2=80=98iso-codes=E2=80=99 to =E2=80=98iso-codes/pinned=E2=80= =99, rename users, and have: (define-public iso-codes (package (inherit iso-codes/pinned) =E2=80=A6)) ? > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url home-page) > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0rh2hiivd2hl864zar3pr3yxpkizj4jj4g6c9zjflls35jk4my3a")) > + (modules '((guix build utils))) > + (snippet > + '(begin > + (substitute* (find-files "." "\\.po$") > + (("#.*Name for TWN,.*") "") > + (("^msgid \"Taiwan, .*") "# Guix doesn't use ")) > + (substitute* "data/iso_3166-1.json" > + (("(Taiwan), [^\"]*" _ name) name)))))) Maybe (origin (inherit (package-source iso-codes/pinned)) =E2=80=A6) to avo= id duplicating the snippet? Apart from that, it LGTM, thanks! Ludo=E2=80=99.