unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org
Subject: Re: Rollback problems
Date: Thu, 24 Jan 2013 12:34:25 +0100	[thread overview]
Message-ID: <87mwvystku.fsf@gnu.org> (raw)
In-Reply-To: <201301240017.55013.andreas@enge.fr> (Andreas Enge's message of "Thu, 24 Jan 2013 00:17:54 +0100")

Hello!

Andreas Enge <andreas@enge.fr> skribis:

> Am Mittwoch, 23. Januar 2013 schrieb Ludovic Courtès:
>> And what if you roll back once you’re at the empty profile?
>
> Then nothing should happen.
>
>> It seems more intuitive for me to error out like this, because there was
>> really nothing but nothingness before “hello” was installed.  :-)
>> WDYT?
>
> No, I disagree; when I have nothing, install hello and roll back, I should 
> be back to nothing. Some other opinions would be useful on this matter.

Hmm, OK.

Well, that’s doable, so if you or others find it less confusing this
way, it’s probably worth doing it.

>> This is expected (same behavior as nix-env.)  Profile generations are
>> not deleted unless you explicitly do so; this is what guarantees that
>> one can roll back anywhere they want.
>> 
>> But I wonder if this is really worth the trouble.  In my experience, a
>> scenario like the one above rarely happens, if ever.
>
> I find the behaviour of roll back currently very confusing, and the 
> situation looks reasonable to me:
> I install hello, it works, so I keep it.
> I install freetype, it does not work, so I drop it again.
> I install file, it does not work, so I drop it again.
> Now I expect to have only hello, but I have hello and freetype.

Right, that seems like a real-world scenario, I admit.

So I guess we can make that change.  That will mean storing the ordered
list of previous generations in each generation’s manifest, and then
getting the previous generation number from there.

I wonder if generations should be identified by a number at all, then.

Thoughts?

Thanks,
Ludo’.

  reply	other threads:[~2013-01-24 11:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 20:48 Rollback problems Andreas Enge
2013-01-23 22:58 ` Ludovic Courtès
2013-01-23 23:17   ` Andreas Enge
2013-01-24 11:34     ` Ludovic Courtès [this message]
2013-01-24 15:33       ` Alex Sassmannshausen
2013-01-24 15:59         ` Ludovic Courtès
2013-01-24 20:52       ` Ludovic Courtès
2013-01-25  2:44         ` Nikita Karetnikov
2013-01-25 13:54           ` Alex Sassmannshausen
2013-01-25 14:48             ` Andreas Enge
2013-01-25 14:53           ` Ludovic Courtès
2013-01-27 17:05         ` Ludovic Courtès
2013-01-28 22:10           ` Andreas Enge
2013-01-28 22:44             ` Ludovic Courtès
2013-01-25  3:08     ` Nikita Karetnikov
2013-01-27 17:06 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwvystku.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=andreas@enge.fr \
    --cc=bug-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).