unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Andreas Enge <andreas@enge.fr>
Cc: 21288@debbugs.gnu.org
Subject: bug#21288: Qt's bundled libraries must not be used
Date: Sun, 04 Oct 2015 22:09:03 -0400	[thread overview]
Message-ID: <87mvvyt6bk.fsf@netris.org> (raw)
In-Reply-To: <20151004210542.GA831@debian> (Andreas Enge's message of "Sun, 4 Oct 2015 23:05:42 +0200")

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> Commit bc554b4 compiles qt-5 with the system harfbuzz and removes a bundled
> copy from our source code (the one called harfbuzz-ng; strangely, there is
> another one, called harfbuzz, without which the package does not compile).
>
> Commit 9c32e1f removes the bundled sqlite copy (the system sqlite was already
> used before).

Sounds good, thank you!

> Some other system libraries are already used automatically; to make things
> clearer, we could also remove their source code (from the corresponding
> 3rdparty/ subdirectories).

Yes, I think we should remove as many bundled libraries as possible.
Even if the build system does not use the bundled libFOO today, a future
version might start using it, and so when there's a security flaw found
in libFOO, we will have to double-check to make sure it's really not
being used.  It's much easier to just remove the bundled copies.

What do you think?

      Mark

  reply	other threads:[~2015-10-05  2:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 14:53 bug#21288: Qt's bundled libraries must not be used Ludovic Courtès
2015-10-04 10:49 ` Andreas Enge
2015-10-04 21:05   ` Andreas Enge
2015-10-05  2:09     ` Mark H Weaver [this message]
2020-05-13 19:14 ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvvyt6bk.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=21288@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).