bug#31640: Librecad fails to build with Qt 5.11

bug#31640: Librecad fails to build with Qt 5.11

[Ricardo Wurmus]

Librecad fails to build since the upgrade to Qt 5.11 in commit
1f52eb7be7e166b477b7635ff71936fc05425a6e.

--8<---------------cut here---------------start------------->8---
g++ -c -pipe -g -fext-numeric-literals -O2 -std=gnu++11 -Wall -W -D_REENTRANT -fPIC -DDWGSUPPORT -DQC_APPDIR="librecad" -DLC_VERSION="2.1.3" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I. -I../../libraries/libdxfrw/src -I../../libraries/jwwlib/src -Icmd -Ilib/actions -Ilib/creation -Ilib/debug -Ilib/engine -Ilib/fileio -Ilib/filters -Ilib/generators -Ilib/gui -Ilib/information -Ilib/math -Ilib/modification -Ilib/printing -Iactions -Imain -Itest -Iplugins -Iui -Iui/forms -Iui/generic -I../res -isystem /gnu/store/lxnirpmnx1268pwq5nsnmjwi4l619ky2-qtsvg-5.11.0/include/qt5 -isystem /gnu/store/lxnirpmnx1268pwq5nsnmjwi4l619ky2-qtsvg-5.11.0/include/qt5/QtSvg -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5 -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtPrintSupport -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtWidgets -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtGui -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtCore -I../../generated/librecad/moc -isystem /gnu/store/88vpd91676yna0zrix1shvqvvh4nx21a-libdrm-2.4.91/include/libdrm -I../../generated/librecad/ui -I/gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/lib/qt5/mkspecs/linux-g++ -o ../../generated/librecad/obj/linklist.o ui/generic/linklist.cpp
ui/generic/widgetcreator.cpp: In constructor ‘WidgetCreator::WidgetCreator(QWidget*, QMap<QString, QAction*>&, QMap<QString, QActionGroup*>, bool)’:
ui/generic/widgetcreator.cpp:59:44: error: invalid use of incomplete type ‘class QActionGroup’
         ui->categories_combobox->addItem(ag->objectName());
                                            ^
In file included from ui/generic/widgetcreator.cpp:27:0:
ui/generic/widgetcreator.h:9:7: note: forward declaration of ‘class QActionGroup’
 class QActionGroup;
       ^
In file included from /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtGui/qtguiglobal.h:43:0,
                 from /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtWidgets/qtwidgetsglobal.h:43,
                 from /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtWidgets/qframe.h:43,
                 from /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtWidgets/QFrame:1,
                 from ui/generic/widgetcreator.h:4,
                 from ui/generic/widgetcreator.cpp:27:
ui/generic/widgetcreator.cpp: In member function ‘void WidgetCreator::setCategory(QString)’:
ui/generic/widgetcreator.cpp:233:39: error: invalid use of incomplete type ‘class QActionGroup’
     foreach (auto action, action_group->actions())
                                       ^
In file included from ui/generic/widgetcreator.cpp:27:0:
ui/generic/widgetcreator.h:9:7: note: forward declaration of ‘class QActionGroup’
 class QActionGroup;
       ^
g++ -c -pipe -g -fext-numeric-literals -O2 -std=gnu++11 -Wall -W -D_REENTRANT -fPIC -DDWGSUPPORT -DQC_APPDIR="librecad" -DLC_VERSION="2.1.3" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I. -I../../libraries/libdxfrw/src -I../../libraries/jwwlib/src -Icmd -Ilib/actions -Ilib/creation -Ilib/debug -Ilib/engine -Ilib/fileio -Ilib/filters -Ilib/generators -Ilib/gui -Ilib/information -Ilib/math -Ilib/modification -Ilib/printing -Iactions -Imain -Itest -Iplugins -Iui -Iui/forms -Iui/generic -I../res -isystem /gnu/store/lxnirpmnx1268pwq5nsnmjwi4l619ky2-qtsvg-5.11.0/include/qt5 -isystem /gnu/store/lxnirpmnx1268pwq5nsnmjwi4l619ky2-qtsvg-5.11.0/include/qt5/QtSvg -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5 -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtPrintSupport -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtWidgets -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtGui -isystem /gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/include/qt5/QtCore -I../../generated/librecad/moc -isystem /gnu/store/88vpd91676yna0zrix1shvqvvh4nx21a-libdrm-2.4.91/include/libdrm -I../../generated/librecad/ui -I/gnu/store/xgpwah2hppghgc7c09jp643ddm2lfjj5-qtbase-5.11.0/lib/qt5/mkspecs/linux-g++ -o ../../generated/librecad/obj/qc_applicationwindow.o main/qc_applicationwindow.cpp
make[2]: *** [Makefile:12199: ../../generated/librecad/obj/widgetcreator.o] Error 1
make[2]: *** Waiting for unfinished jobs....
main/qc_applicationwindow.cpp:3199:48: warning: unused parameter ‘event’ [-Wunused-parameter]
 void QC_ApplicationWindow::changeEvent(QEvent* event)
                                                ^
make[2]: Leaving directory '/tmp/guix-build-librecad-2.1.3.drv-0/LibreCAD-2.1.3/librecad/src'
make[1]: *** [Makefile:45: sub-src-make_first] Error 2
make[1]: Leaving directory '/tmp/guix-build-librecad-2.1.3.drv-0/LibreCAD-2.1.3/librecad'
make: *** [Makefile:91: sub-librecad-make_first-ordered] Error 2
phase `build' failed after 221.3 seconds
builder for `/gnu/store/r9hw8kh3z69hs1wnj5gc44dg8ri5ijkg-librecad-2.1.3.drv' failed with exit code 1
guix package: error: build failed: build of `/gnu/store/r9hw8kh3z69hs1wnj5gc44dg8ri5ijkg-librecad-2.1.3.drv' failed
--8<---------------cut here---------------end--------------->8---

--
Ricardo

bug#31640: Librecad fails to build with Qt 5.11

[Clément Lassieur]

Ricardo Wurmus <rekado@elephly.net> writes:

> Librecad fails to build since the upgrade to Qt 5.11 in commit
> 1f52eb7be7e166b477b7635ff71936fc05425a6e.

Fixed by 6cedd611774f91056c70d8d3a175d514b9b9fc76.  Thank you for
reporting it.

Clément

bug#31640: Librecad fails to build with Qt 5.11

[Ricardo Wurmus]

Clément Lassieur <clement@lassieur.org> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Librecad fails to build since the upgrade to Qt 5.11 in commit
>> 1f52eb7be7e166b477b7635ff71936fc05425a6e.
>
> Fixed by 6cedd611774f91056c70d8d3a175d514b9b9fc76.  Thank you for
> reporting it.

Awesome!  Thank you, Clément, for the quick fix!

-- 
Ricardo