From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#35540: Installer displays encrypted partition password entry in
	cleartext
Date: Fri, 03 May 2019 12:07:49 +0200
Message-ID: <87muk3etqi.fsf@gnu.org>
References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:46275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMV6p-0003wf-9W
	for bug-guix@gnu.org; Fri, 03 May 2019 06:08:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMV6o-000825-FT
	for bug-guix@gnu.org; Fri, 03 May 2019 06:08:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:34238)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hMV6o-00081v-AH
	for bug-guix@gnu.org; Fri, 03 May 2019 06:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMV6o-0005py-4T
	for bug-guix@gnu.org; Fri, 03 May 2019 06:08:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35540.B35540.155687808122431@debbugs.gnu.org>
In-Reply-To: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain>
	(pelzflorian@pelzflorian.de's message of "Fri, 3 May 2019 10:54:37
	+0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35540@debbugs.gnu.org

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> When creating an encrypted partition in Manual partitioning (maybe
> also Guided?) in the Newt installer, it asks for a password with which
> to encrypt the partition.  However only the password confirmation
> password entry diplays ******* instead of the typed password, the
> password entry before displays the password in cleartext.

This is done on purpose as I wrote in commit
453c976501bb4d5c4c6b832b7c0c1ec3d493b80f:

         ;; Note: Don't use FLAG-PASSWORD here because this is the
         ;; first bit of text that the user types in, so it's
         ;; probably safer if they can see that the keyboard layout
         ;; they chose is in effect.

I=E2=80=99m not entirely sure this is the right thing to do, but I thought =
that
as a user I=E2=80=99d want to make sure I really typed what I thought I typ=
ed.

WDYT?

Ludo=E2=80=99.