From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP.
Date: Wed, 18 Dec 2019 19:59:59 +0100
Message-ID: <87mubpcvdc.fsf@devup.no>
References: <87y2vdcp2b.fsf@devup.no>
 <20191215203513.27831-1-mbakke@fastmail.com> <878sncdjmu.fsf@gnu.org>
 <874ky0djjt.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34637)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iheZF-0006I8-M9
 for bug-guix@gnu.org; Wed, 18 Dec 2019 14:01:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iheZC-00061r-4h
 for bug-guix@gnu.org; Wed, 18 Dec 2019 14:01:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:37939)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iheZB-00060M-OV
 for bug-guix@gnu.org; Wed, 18 Dec 2019 14:01:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iheZB-0005eJ-M3
 for bug-guix@gnu.org; Wed, 18 Dec 2019 14:01:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38628.B38628.157669561421647@debbugs.gnu.org>
In-Reply-To: <874ky0djjt.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 38628@debbugs.gnu.org

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Also it would be nice to add a tiny test close to the one that
> 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c added.

Good idea.  I came up with this:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

diff --git a/tests/gexp.scm b/tests/gexp.scm
index 84c16422c2..8b1596f66d 100644
--- a/tests/gexp.scm
+++ b/tests/gexp.scm
@@ -886,6 +886,12 @@
     (run-with-store %store
       (lower-gexp #~(foo #$+)))))
 
+(test-equal "lower-gexp, character literal"
+  '(#\+)
+  (lowered-gexp-sexp
+   (run-with-store %store
+     (lower-gexp #~(#\+)))))
+
 (test-assertm "gexp->derivation #:references-graphs"
   (mlet* %store-monad
       ((one (text-file "one" (random-text)))

--=-=-=
Content-Type: text/plain


WDYT?

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl36dy8ACgkQoqBt8qM6
VPrgsgf+JoBk+sQR1w01jqAyYbPN3a1HyqTt/saW5h5veRJ365EfesdqIa2A9QJD
y4w+ibZFBjei68Y7wfTGxPDK9rBvqDs9ruKVIASBD4K/k7RzF/uOXub85hOv2Bts
xfiEMsN/YmAegXTTnOLD5ejF2zBxRMIVjXH6+GlDKwPAMSgrHcKJTeqTax+7XNAB
CFwx1b0RDfS1T0CpwdH542OD8+vfbrWZqic1SH7IUr8LUOO+GkklO2esNhe9qTr+
ACNEl/cCQkI42cGvAZnGo/5y5eGsuXMU2kIoSXdlsHzvDnH3kNEQ3DGI+QSIpP+9
K5zhv70+qpasN6LxuLsecI/o6HXOmw==
=xrAY
-----END PGP SIGNATURE-----
--==-=-=--