From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 38628@debbugs.gnu.org
Subject: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP.
Date: Wed, 18 Dec 2019 19:59:59 +0100 [thread overview]
Message-ID: <87mubpcvdc.fsf@devup.no> (raw)
In-Reply-To: <874ky0djjt.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 198 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Also it would be nice to add a tiny test close to the one that
> 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c added.
Good idea. I came up with this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Type: text/x-patch, Size: 468 bytes --]
diff --git a/tests/gexp.scm b/tests/gexp.scm
index 84c16422c2..8b1596f66d 100644
--- a/tests/gexp.scm
+++ b/tests/gexp.scm
@@ -886,6 +886,12 @@
(run-with-store %store
(lower-gexp #~(foo #$+)))))
+(test-equal "lower-gexp, character literal"
+ '(#\+)
+ (lowered-gexp-sexp
+ (run-with-store %store
+ (lower-gexp #~(#\+)))))
+
(test-assertm "gexp->derivation #:references-graphs"
(mlet* %store-monad
((one (text-file "one" (random-text)))
[-- Attachment #1.3: Type: text/plain, Size: 7 bytes --]
WDYT?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-12-18 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 20:27 bug#38628: Character literals unsupported in source 'snippets' Marius Bakke
2019-12-15 20:35 ` bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP Marius Bakke
2019-12-16 21:51 ` Ludovic Courtès
2019-12-16 21:53 ` Ludovic Courtès
2019-12-18 18:59 ` Marius Bakke [this message]
2019-12-18 22:06 ` Marius Bakke
2019-12-19 11:11 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mubpcvdc.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=38628@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).