bug#41413: guix-install.sh broken on Gentoo

bug#41413: guix-install.sh broken on Gentoo

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 29 bytes --]

Take it away, ZombieChicken:

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#41413: guix-install.sh broken on Gentoo

[ZC via web]

guix-install.sh calls "update-rc.d", which doesn't exist on a Gentoo system. Instead of trying to support all possible init systems, or make assumptions regarding how the init system works, I'd suggest simply dropping support for anything other than upstart and/or systemd. Users of smaller distros using unusual/traditional init systems can add support for guix theirself. The safest and most portable option would likely be to simply point to the init script at the end of the install, and tell the user to copy that file to the proper directory and enable it, copy and modify it to fit their system, or use it as a template for whatever their init system happens to be. It's less user-friendly in the "run it and forget it" sense, but it won't break a user's already working system, or error out in new and fun ways.

bug#41413: guix-install.sh broken on Gentoo

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hullo,

ZC via web 写道：
> guix-install.sh calls "update-rc.d", which doesn't exist on a 
> Gentoo system. Instead of trying to support all possible init 
> systems, or make assumptions regarding how the init system 
> works, I'd suggest simply dropping support for anything other 
> than upstart and/or systemd.

I think we can safely assume that if ‘update-rc.d’ exists it will 
work a certain way (i.e. there aren't multiple incompatible 
‘update-rc.d’s around), and that the real bug is that the script 
checks for a random directory in /etc instead.

It should test for the script(s) it uses, not related symptoms.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#41413: guix-install.sh broken on Gentoo

[Vincent Legoll]

Hello,

I'm working on adding a gentoo VM to my test farm, so I'll have a look
at the problem, and hopefully fix it properly.

-- 
Vincent Legoll

bug#41413: guix-install.sh broken on Gentoo

[Vincent Legoll]

Hello Tobias, ZC,

I created a gentoo VM (i686 / following gentoo handbook) and tried
the official upstream guix installer.

It worked properly, not detecting the OS init system, I think this is
because the gentoo handbook made me install cronie instead of plain
cron, so there's no "/etc/init.d/cron" file. And so it did not try to
install the guix-daemon service init.d file through update-rc.d.
And told me to run the daemon manually, which worked OK.

Running it with a local guix-install.sh + binary tarball with my
pending changes (which includes openrc support). It also worked
properly, detecting the OS as being openrc managed and doing what
is needed.

So, I'll still cook up a patch to fix sysvinit detection, because
assuming sysvinit on the mere presence of /etc/init.d/cron is not
really the right thing to do. (and the fix will need to be tested
on a sysvinit-based distro, which I'll do)

But on the other hand, I don't know what to do with this bug report,
I cannot reproduce the exact problem, and I'm not trying all the other
available cron variants from gentoo (bcron, dcron, fcron).

So either ZC tells us more about his setup and shows us more output
to be able to understand what did go wrong, or we cannot help further.

Couldn't keep ZC CC'ed as the issue was created without his email
address, let's hope he follows it via another way...

-- 
Vincent Legoll

bug#41413: guix-install.sh broken on Gentoo

[Maxim Cournoyer]

Hi Vincent,

Vincent Legoll <vincent.legoll@gmail.com> writes:

> Hello Tobias, ZC,
>
> I created a gentoo VM (i686 / following gentoo handbook) and tried
> the official upstream guix installer.
>
> It worked properly, not detecting the OS init system, I think this is
> because the gentoo handbook made me install cronie instead of plain
> cron, so there's no "/etc/init.d/cron" file. And so it did not try to
> install the guix-daemon service init.d file through update-rc.d.
> And told me to run the daemon manually, which worked OK.
>
> Running it with a local guix-install.sh + binary tarball with my
> pending changes (which includes openrc support). It also worked
> properly, detecting the OS as being openrc managed and doing what
> is needed.
>
> So, I'll still cook up a patch to fix sysvinit detection, because
> assuming sysvinit on the mere presence of /etc/init.d/cron is not
> really the right thing to do. (and the fix will need to be tested
> on a sysvinit-based distro, which I'll do)
>
> But on the other hand, I don't know what to do with this bug report,
> I cannot reproduce the exact problem, and I'm not trying all the other
> available cron variants from gentoo (bcron, dcron, fcron).
>
> So either ZC tells us more about his setup and shows us more output
> to be able to understand what did go wrong, or we cannot help further.
>
> Couldn't keep ZC CC'ed as the issue was created without his email
> address, let's hope he follows it via another way...

It seems the installer is working fine as per your tests and that the
original issue cannot be reproduced.  I'm closing this bug.

Thank you,

Maxim

bug#41413: guix-install.sh broken on Gentoo

[Vincent Legoll]

Hello,

On Wed, May 5, 2021 at 6:56 AM Maxim Cournoyer
<maxim.cournoyer@gmail.com> wrote:
> It seems the installer is working fine as per your tests and that the
> original issue cannot be reproduced.  I'm closing this bug.

Yes, I stopped working on that (guix-install.sh), not enough
feedback / reviews / merges, so it stalled.

Thanks anyways

-- 
Vincent Legoll