From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uD/wHJklUl8dJQAA0tVLHw (envelope-from ) for ; Fri, 04 Sep 2020 11:31:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YEXEGJklUl+1KwAAB5/wlQ (envelope-from ) for ; Fri, 04 Sep 2020 11:31:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C039C940308 for ; Fri, 4 Sep 2020 11:31:36 +0000 (UTC) Received: from localhost ([::1]:54358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE9wN-0005gL-70 for larch@yhetil.org; Fri, 04 Sep 2020 07:31:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE9vr-0005g4-Es for bug-guix@gnu.org; Fri, 04 Sep 2020 07:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kE9vr-0003of-5f for bug-guix@gnu.org; Fri, 04 Sep 2020 07:31:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kE9vr-0005Gi-2t for bug-guix@gnu.org; Fri, 04 Sep 2020 07:31:03 -0400 Subject: bug#43138: Stack overflow in emacs 27 because of preloading emacs-seq Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Fri, 04 Sep 2020 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43138 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Mail-Followup-To: 43138@debbugs.gnu.org, pierre.langlois@gmx.com, pierre.langlois@gmx.com Received: via spool by 43138-done@debbugs.gnu.org id=D43138.159921905819960 (code D ref 43138); Fri, 04 Sep 2020 11:31:02 +0000 Received: (at 43138-done) by debbugs.gnu.org; 4 Sep 2020 11:30:58 +0000 Received: from localhost ([127.0.0.1]:37618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9vm-0005BV-6X for submit@debbugs.gnu.org; Fri, 04 Sep 2020 07:30:58 -0400 Received: from mout.gmx.net ([212.227.17.22]:52063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9vk-00054B-6t for 43138-done@debbugs.gnu.org; Fri, 04 Sep 2020 07:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599219049; bh=2EqhhBRJYTQbXhCPbcgcwMWEl8NXqx65q0Ti+ePqUiA=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=EnxOyUepWuLy8Z51h7g+rYCeUApbUP080Tctd2zdH3VGV6ZUnO4RWMOG7SRItVqCP I6shHhYMdIcmZoCUgMS7i87OG0mhZrEhp95z3hFIbVo1Ol6BAYZKrpGiGnkb4LT/GL SAJdunoqBAKpAFV491sQvXJRESOIi6tyR7obNqGs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MGQnF-1kM7TY2OGD-00GmR1; Fri, 04 Sep 2020 13:30:49 +0200 References: <87ft82lsul.fsf@gmx.com> <87imcyv9iq.fsf@netris.org> <87imcy5x7y.fsf@gmx.com> <871rjmv37n.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <871rjmv37n.fsf@netris.org> Message-ID: <87mu25srrm.fsf@gmx.com> Date: Fri, 04 Sep 2020 12:30:53 +0100 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:aeehHyy8qoeF+ex70XwEFugCr4CHnO/ACZVN2o6F/TDBIxq6bVQ CLNs2+0x3xZBe6JzUbQo6bEG5HdSo92f8L8y8piiqSjqvN74FKNC0V3YqtBpgLjugT9Cppe Er5fjU8kamH8RokpUER0xakRhfjZ+Z1B42I4+Pb9cknRlIx76ziZOD7zH/UZHLu4iOg+RcL TMTGtjYNo1mgi9V8mze4A== X-UI-Out-Filterresults: notjunk:1;V03:K0:CHnLYOvRSmI=:UHG0FYqTv6C1L3JMkG7jMl AeSXAkzkHZyhuLL155EEeqCdH8Je9EZU2x1xSleMarkc2KaAn31GMSsK8AK96lfElMbjjitjN nu/oBeiqZItdo4y/wZXY04tNWTkkOctgWVXA6xOpTV5BPinco74iX0gZcBnVMte0MAsq2edT7 3a79J5btA2gErrJ4NqFEOHInxwCdUxB89AmkVB5SMYhbTU6rW0G8rjfFRPGVs7Le4zFOJ132W FQTFr+rlOGVUHF73xiQbYwKPnp+3fQltIofpSwwwtSUM9qE8AkUw5gswKEO82m6As2i75JjQb cQFyZu037iJ7lPyTETQLw8TqryD06FbAh1Qp9KQZ3ETHAjFYgRJ6ZGBo2h4W06OA9yNqchkyo ovqc0OTSq8w+idaFQBir48qYY6XpYwOfv0eHHwQi/Wvlgt79etch499pAFBrXZLiZhtGNLaVn jrVlnJIFY+yoPFap1N9Gj1/nQHtbKuruZN3EujWazVhVyWEmKuPW2nua+92GSaCCPM2I/9/wV ZU+VKvzOx8dmNrHR7n/GO1OAPvLeLgxb5XffPNMrdidmkL/E7+NnbTVK4oON/hQX4/VVYrLuA jVoLB2ILkYMNa2OsufR8KFyOMMSYgDOnNPsn+WKdY3Ilgja7acT8ZNteG9NBiAVsl1IRDowEp oDpKJfUJdw+1dmmlq3FfbpmXOPNN6CqjuONfqvsfoNTZM1VRi5ITpeFHzH3yWg2yhCXNDGkqC tKHU6A6hwKKTglB2AS6k9xPVE/i+HNCuOg6T+ie+yr21MHZaI1ubC4AOUow2ZDY8fet23xIgr 1Mukh7dpg+L2ASePcAF/UK6JyVPTnIiln4oTkUdVsW68A/7EUwFxtTlPiHm+sV3tGIV9dGANS gZR8+SXEiVAGTH3vqwrlyVqSMe1a0JIv7EJZy0SDD2yJi/KVbFoY1+oL15Qw9zunxXCNF/NW0 rXqrTieUnxa3fJawijSSgVzvLrEkSTiYXycE3o3BkM7vcKeOUZcRbEn+bdBm+/v94ZVpLQ+IT ua9Fsb4p3Ms5fhCcJs8mh5AG/OdanISBVpXYUx9CWy+JeSE6NgsN5R1oVDjvgmXkoRKmN/M12 5lC1Rio7PqjdrJ9p9XGnQD3QQAPNdqXSRYHwKBO3HU0DACtYNakPaFGiWhEOCwovlvTjkAjRb h7JoPDqlcA2FMjfevIsehj2IdKSOTpNlCmLxMwOsbahaMF+nbv+o39rmdfCZWYAKZQJEwIqe+ 2dJ9cVBMbdEKnPbbfnRP1Z7Y21p3qPD8cMLh4ag== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43138-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=EnxOyUep; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.11 X-TUID: HjJB4Wg9+ATO --=-=-= Content-Type: text/plain Hi Mark, Replying with the bug on CC, I didn't realise your last email didn't include it. I assume that was a mistake? Mark H Weaver writes: > Hi Pierre, > > Pierre Langlois writes: > >> Mark H Weaver writes: >> >>> If 'emacs-seq' is included in Emacs 27, it seems to me that we should >>> just delete it, unless there's something I'm missing. >> >> Agreed, I was curious if there was another reason for needing it, since >> I /believe/ it's been in emacs proper since 25, but emacs-seq was added >> in to guix after that. I suspect it it's still listed as a dependency >> for packages, even though it's not actually needed. > > It might be that the copy of 'emacs-seq' in Emacs 26 was relatively old, > and that some users and other emacs packages wanted a newer version. I > guess that's the rationale for 'emacs-org', and I vaguely recall that we > might have had an updated Gnus package in the past as well, for the same > reason. > > Hopefully the version of 'emacs-seq' bundled with Emacs 27 is now > sufficiently up-to-date. > >> Anyways, I've reconfigured my system with the following patch to fix the >> issue, let me know if that looks OK! > > Except for a minor typo in the commit log "alongisde", looks good to me. > > Thank you! I think you should go ahead and push it to 'master', since > things are currently broken and this is certainly an improvement. If > there are remaining issues, they can be addressed in future commits. OK, pushed to master with 852ae64e11ef9107afabbdb307770f946376addd , I'll close the bug as well, I suppose we can open new ones in case problems arise later. > >> Oh, another thing, I wanted to warn potential users of emacs-seq with a >> deprecation warning using (guix deprecation), like: >> >> ;; seq.el is included into emacs. >> (define-deprecated emacs-seq emacs) > > It's a good thought, but I'm not sure if 'define-deprecated' is the > right thing here. This might be a question for Ludovic. > >> It would be good to do that so somebody isn't tempted to re-add it when >> it's listed a dependency. But that triggers errors: >> >> error: emacs: unbound variable >> hint: Did you forget a `use-modules' form? >> >> Am I using it wrong? The (gnu packages emacs) module is included of >> course. > > I guess that this is most likely caused by a cyclic dependency between > the (gnu packages emacs) and (gnu packages emacs-xyz) modules. When > there's a cyclic dependency between modules, Guile cannot ensure that > the definitions of imported modules are evaluated first. > > In this case, I guess that (define-deprecated emacs-seq emacs) is > evaluated before the definition of 'emacs' is evaluated, and that it > fails to cope with that. > > I wish that we didn't have any cyclic module dependencies, but at this > point it would require a *major* reorganization of our package modules > to avoid it. Ouch, yeah that seems like the problem, I'll see if I can get it to work as a follow-up, but it seems not really worth the effort :-). Thanks! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9SJW0ACgkQqPyeRH9P fVQWxgf8DTfelZPoOewJJlu110Gmf2kgbRMDaAfJUfpdDIYS1zFzlH3Bb09/m8L8 VVlEqluYA14wa4Y/kfdDYzNKxxB3xoa04EsVv3dsgS7wjYkCWQGh1rmOJIJ9cItv NcB016og5WN35JS72TUaWwpyepte1xPDT8l/HOOnjFAOwnw00Oryr93UYClBHna1 jigNXSIEdz1sX3nt/RfEF9La6VSu3r74plYQ+nnOt5Ei+fjceUzLZZOrbFOl5YMw NV8LuLsPzroAmWtkqPDZppPoVXOhpyos1+S5hxKwAaY5DrWAxB4JPijyfNyAti8v inxr2jOLFQC629bgqSm75O7DG8WVRg== =RQZH -----END PGP SIGNATURE----- --=-=-=--