unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: John Soo <jsoo1@asu.edu>
To: 44619@debbugs.gnu.org
Subject: bug#44619: [PATCH] Expose some functions for guix.el
Date: Fri, 13 Nov 2020 05:54:08 -0800	[thread overview]
Message-ID: <87mtzlmkfz.fsf@asu.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi Guix,

guix.el Has been broken for quite some time because it depends on @@ for
some modules.  After some review, I came to the conclusion that all of
the bindings it uses can be safely exposed.

In general, it uses mostly bindings from guix scripts (pack, build,
etc).  Those bindings seem reasonable to expose since they give
programmatic access to "API"s that the CLI user is most likely familiar
with.

Thanks!

John


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-guix-pack-Expose-some-bindings-for-third-party-use.patch --]
[-- Type: text/x-patch, Size: 892 bytes --]

From af50f2d398096f7f8bd4efd9255b5713f39104b2 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Thu, 12 Nov 2020 21:47:36 -0800
Subject: [PATCH 1/2] guix pack: Expose some bindings for third-party use.

* guix/scripts/pack.scm (compressor-name, %compressors, %formats):
Expose them.
---
 guix/scripts/pack.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index 8e694edbbe..b6dfcb5f6a 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -58,11 +58,14 @@
   #:use-module (srfi srfi-37)
   #:use-module (ice-9 match)
   #:export (compressor?
+            compressor-name
+            %compressors
             lookup-compressor
             self-contained-tarball
             docker-image
             squashfs-image
 
+            %formats
             guix-pack))
 
 ;; Type of a compression tool.
-- 
2.29.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-guix-build-Expose-log-url-for-third-parties.patch --]
[-- Type: text/x-patch, Size: 962 bytes --]

From 17344a2a6f68146c51368788dcdf3dd9193155e6 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Thu, 12 Nov 2020 21:54:45 -0800
Subject: [PATCH 2/2] guix build: Expose log-url for third parties.

* guix/scripts/build.scm (log-url): Expose it.
---
 guix/scripts/build.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm
index f4a8af035b..41f21fa81d 100644
--- a/guix/scripts/build.scm
+++ b/guix/scripts/build.scm
@@ -57,7 +57,9 @@
   #:use-module ((guix status) #:select (with-status-verbosity))
   #:use-module ((guix progress) #:select (current-terminal-columns))
   #:use-module ((guix build syscalls) #:select (terminal-columns))
-  #:export (%standard-build-options
+  #:export (log-url
+
+            %standard-build-options
             set-build-options-from-command-line
             set-build-options-from-command-line*
             show-build-options-help
-- 
2.29.1


             reply	other threads:[~2020-11-13 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 13:54 John Soo [this message]
2020-11-13 15:58 ` bug#44619: [PATCH] Expose some functions for guix.el zimoun
2020-11-13 16:11   ` John Soo
2020-11-13 17:13     ` Ludovic Courtès
2020-11-13 17:17       ` John Soo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtzlmkfz.fsf@asu.edu \
    --to=jsoo1@asu.edu \
    --cc=44619@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).