From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id PGAZHH32sV8UHAAA0tVLHw (envelope-from ) for ; Mon, 16 Nov 2020 03:48:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 3MRlF332sV8ERgAAB5/wlQ (envelope-from ) for ; Mon, 16 Nov 2020 03:48:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D90EB9400D3 for ; Mon, 16 Nov 2020 03:48:12 +0000 (UTC) Received: from localhost ([::1]:37246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keVUw-0005TH-CR for larch@yhetil.org; Sun, 15 Nov 2020 22:48:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keVUo-0005Rd-5B for bug-guix@gnu.org; Sun, 15 Nov 2020 22:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keVUn-0003ZO-R6 for bug-guix@gnu.org; Sun, 15 Nov 2020 22:48:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keVUn-0001Es-Oc for bug-guix@gnu.org; Sun, 15 Nov 2020 22:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 16 Nov 2020 03:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44353 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44353-submit@debbugs.gnu.org id=B44353.16054984504717 (code B ref 44353); Mon, 16 Nov 2020 03:48:01 +0000 Received: (at 44353) by debbugs.gnu.org; 16 Nov 2020 03:47:30 +0000 Received: from localhost ([127.0.0.1]:54756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keVUI-0001E1-3A for submit@debbugs.gnu.org; Sun, 15 Nov 2020 22:47:30 -0500 Received: from mail-qv1-f53.google.com ([209.85.219.53]:47081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keVUD-0001Di-Le for 44353@debbugs.gnu.org; Sun, 15 Nov 2020 22:47:29 -0500 Received: by mail-qv1-f53.google.com with SMTP id r12so8153102qvq.13 for <44353@debbugs.gnu.org>; Sun, 15 Nov 2020 19:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+QOM3XO1zMziJt+JQZS0z+7Zal7fBdC9V0INJbTsxio=; b=coR4UgBSty4xPabOy/3SxvT+zEs7mntlzcd5QLSCSh+xYMhe/w4cFT+gPQuxT2H/jr abYzspyztq0y5Isrs5w2amZScWvFiZt1ukshlqr/ChaoiZ19688TCmRzLOCZNjeAMKf8 1Gy9cQSeV5110/fFjR4wS1eOCyko2da4S3ft98up2PsD3/MErT+JvN8iBLZ6DyVv4WkG 8+APKQdVMbz0GpfqYJlx+sxiclvkGHvJSbT35eCXIJP8B/d32KneRV8ci2lvszFJg95N wTXV05i7fCkerfdf0OOeKnQun+PYUK+HumdcdlaCC88bsSzJUe2cVdsDcGwlyf88ntLF V8lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+QOM3XO1zMziJt+JQZS0z+7Zal7fBdC9V0INJbTsxio=; b=uBBiFSDOGmP3zJpOMRoRX87DaSdQHAA6wcwhnDEHA4MiVP3/8oS9M1Fff2U3MW8Mw3 PXxgbWO+oNbq0s3P+bl9gdIVQ/t5mZa4BLLK91QPY64ntBuUYyF9sM0CfmryefMzgxF3 1Iv8UbXph7ZlQgU2q7Y452afIffX7h+BripVpinPGtYxhx1fzGP9Mn3J3X5mkvpusdKQ dglmoX2vEh1WLD8Ez60KMwAFkjX15NiF87cuK29zXNJdh7dOOVAeCToLMS0tP2ePtnNS jdSMQ0sXV6e6qtCO/7m1PfkbEHvlBOhwn+FvjT0ok3s+7TLJoqEUHGBCP50lWCWS7ETb dhuw== X-Gm-Message-State: AOAM5323E9IfRcum5e5/exCLtKjW/ToqDCkWN4gJkMSz+Q0wZ4CyWj/S owITJNm+B3P+CGfnJX07S4I= X-Google-Smtp-Source: ABdhPJxRsrAeDho2P+KgHKPFFbM9CwlO1HpApk12LBxSSabfyAekKm2cbp8BmP99WYz70w6o9FD/cQ== X-Received: by 2002:ad4:4745:: with SMTP id c5mr14094639qvx.2.1605498440109; Sun, 15 Nov 2020 19:47:20 -0800 (PST) Received: from hurd (dsl-10-128-91.b2b2c.ca. [72.10.128.91]) by smtp.gmail.com with ESMTPSA id a1sm11142270qtw.11.2020.11.15.19.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2020 19:47:19 -0800 (PST) From: Maxim Cournoyer References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <878sb25m6s.fsf@gnu.org> Date: Sun, 15 Nov 2020 22:47:11 -0500 In-Reply-To: <878sb25m6s.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 15 Nov 2020 22:45:15 +0100") Message-ID: <87mtzidku8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44353@debbugs.gnu.org, Mathieu Othacehe , Jesse Gibbons Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=coR4UgBS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: KqtORXvAiF0U Hello, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. >> (%default-options): Set its default value to #f. >> (show-help): Add help doc. >> * guix/scripts/system.scm (perform-action): Propagate option... >> (system-derivation-for-action): ...here. Use it to set the volatile-roo= t? >> field of the image object passed to SYSTEM-IMAGE. >> * doc/guix.texi (Invoking guix system): Document it. > > Due notably to the =E2=80=9Cstring freeze=E2=80=9D, I think we shouldn=E2= =80=99t apply it to > =E2=80=98version-1.2.0=E2=80=99. > > Some comments: > >> +@code{disk-image}. By default, the root file system of a disk image is >> +mounted volatile; the @option{--non-volatile} option can be used to make > > That=E2=80=99s not generally the case, though in (gnu system image), only= two > image types have it set to false. Note that the only two images with volatile-root? #f are ARM, and not by intent but as a workaround: ;; FIXME: Deleting and creating "/var/run" and "/tmp" on the overlayfs ;; fails. > Before the new image API though, =E2=80=98disk-image=E2=80=99 did not pro= duce a volatile > root, IIRC. I=E2=80=99m tempted to think that we should set (volatile-ro= ot? > #f) on image types where it makes sense, which is maybe all of them > except ISO. (Then we need to make sure =E2=80=98guix system vm=E2=80=99 = still gets a > volatile root.) > > WDYT, Mathieu? Based on your comments and those of Mathieut, I've made volatile-root? #f the default for 'guix system disk-image', with a '--volatile' option to maintain the ability to have the rootfs mounted volatile, and adjusted the doc accordingly. > So apart from the sentence above, the patch LGTM for =E2=80=98master=E2= =80=99! Thanks for the review! Maxim