From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CLCPK8OZy19dDQAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 14:31:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CA5FJ8OZy18lCQAAbx9fmQ (envelope-from ) for ; Sat, 05 Dec 2020 14:31:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4FC7494043B for ; Sat, 5 Dec 2020 14:31:31 +0000 (UTC) Received: from localhost ([::1]:43780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klYaw-0004zG-9R for larch@yhetil.org; Sat, 05 Dec 2020 09:31:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klYaU-0004mO-4M for bug-guix@gnu.org; Sat, 05 Dec 2020 09:31:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klYaT-0006RH-SW for bug-guix@gnu.org; Sat, 05 Dec 2020 09:31:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klYaT-0000ky-O2 for bug-guix@gnu.org; Sat, 05 Dec 2020 09:31:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 05 Dec 2020 14:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42771 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Holger Peters Received: via spool by 42771-submit@debbugs.gnu.org id=B42771.16071786232855 (code B ref 42771); Sat, 05 Dec 2020 14:31:01 +0000 Received: (at 42771) by debbugs.gnu.org; 5 Dec 2020 14:30:23 +0000 Received: from localhost ([127.0.0.1]:46831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klYZq-0000jz-WA for submit@debbugs.gnu.org; Sat, 05 Dec 2020 09:30:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klYZq-0000jY-7q for 42771@debbugs.gnu.org; Sat, 05 Dec 2020 09:30:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46215) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klYZi-00061e-8J; Sat, 05 Dec 2020 09:30:16 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58398 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1klYZh-0000Jq-4I; Sat, 05 Dec 2020 09:30:13 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Frimaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 05 Dec 2020 15:30:11 +0100 In-Reply-To: <20201129084328.545720-1-holger.peters@posteo.de> (Holger Peters's message of "Sun, 29 Nov 2020 09:43:28 +0100") Message-ID: <87mtys72bw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42771@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 4FC7494043B X-Spam-Score: -2.80 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: DxPsA2wN12j8 Hi Holger, Holger Peters skribis: > * gnu/packages/smalltalk.scm (smalltalk): disable tests > (smalltalk-next): New variable. > (smalltalk-next-from-vcs): New variable. I have mostly two comments, as discussed on IRC (restating them here for those following along): 1. Instead of disabling tests wholesale, what we usually do is (1) investigate why the test is failing (I think it=E2=80=99s a single test failure here), (2) try to determine whether it=E2=80=99s serious or no= t, (3) see if we can work around it with reasonable effort, and if not, skip just this test. 2. I think we should just have =E2=80=98smalltalk=E2=80=99 (latest releas= e) and =E2=80=98smalltalk-next=E2=80=99 (VCS snapshot). Having an extra pack= age for the release candidate is not really useful IMO, and not something we generally do. HTH! Ludo=E2=80=99.