unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Holger Peters <holger.peters@posteo.de>
Cc: 42771@debbugs.gnu.org
Subject: bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases
Date: Sat, 05 Dec 2020 15:30:11 +0100	[thread overview]
Message-ID: <87mtys72bw.fsf@gnu.org> (raw)
In-Reply-To: <20201129084328.545720-1-holger.peters@posteo.de> (Holger Peters's message of "Sun, 29 Nov 2020 09:43:28 +0100")

Hi Holger,

Holger Peters <holger.peters@posteo.de> skribis:

> * gnu/packages/smalltalk.scm (smalltalk): disable tests
> (smalltalk-next): New variable.
> (smalltalk-next-from-vcs): New variable.

I have mostly two comments, as discussed on IRC (restating them here for
those following along):

  1. Instead of disabling tests wholesale, what we usually do is (1)
     investigate why the test is failing (I think it’s a single test
     failure here), (2) try to determine whether it’s serious or not,
     (3) see if we can work around it with reasonable effort, and if
     not, skip just this test.

  2. I think we should just have ‘smalltalk’ (latest release) and
     ‘smalltalk-next’ (VCS snapshot).  Having an extra package for the
     release candidate is not really useful IMO, and not something we
     generally do.

HTH!

Ludo’.




  reply	other threads:[~2020-12-05 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-08 18:53 bug#42771: smalltalk fails to build Michael Rohleder
2020-11-28 22:09 ` bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases Holger Peters
2020-12-04 11:34   ` Holger Peters
2020-12-04 12:06     ` Holger Peters
2020-11-29  8:43 ` Holger Peters
2020-12-05 14:30   ` Ludovic Courtès [this message]
2020-12-28 11:42     ` bug#42771: smalltalk fails to build Miguel Ángel Arruga Vivas
2021-01-04  9:28       ` Ludovic Courtès
2021-01-05 12:09         ` Miguel Ángel Arruga Vivas
2021-01-03 15:34     ` bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases Holger Peters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtys72bw.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=42771@debbugs.gnu.org \
    --cc=holger.peters@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).