From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Leo Prikler <leo.prikler@student.tugraz.at>, 49168@debbugs.gnu.org
Subject: bug#49168: ‘guix import pypi’ misses package dependencies
Date: Fri, 25 Jun 2021 16:51:25 +0200 [thread overview]
Message-ID: <87mtre2e1e.fsf@gnu.org> (raw)
In-Reply-To: <87pmwbythg.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 24 Jun 2021 15:04:27 -0400")
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
[...]
>> Why does the importer favor .whl in the first place? Is it supposed to
>> be more accurate or more widespread or something?
>
> Yes, the METADATA file from the binary wheel is a better place to look
> than the source egg-info requires.txt file. In my commit 01589acc5e1, I
> simplified a comment that used used to read as:
>
> - ;; First, try to compute the requirements using the wheel, since that is the
> - ;; most reliable option. If a wheel is not provided for this package, try
> - ;; getting them by reading either the "requirements.txt" file or the
> - ;; "requires.txt" from the egg-info directory from the source tarball. Note
> - ;; that "requirements.txt" is not mandatory, so this is likely to fail.
> + ;; First, try to compute the requirements using the wheel, else, fallback to
> + ;; reading the "requires.txt" from the egg-info directory from the source
> + ;; tarball.
>
> The wheel (.whl) binary format is well specified as PEP 427 [0] and is
> what pip primarily uses for installing Python packages, making it a very
> reliable source of metadata. The Python egg is the predecessor of the
> wheel, and can be considered obsolete, which explains why it's used as a
> fallback.
Oh, I see.
> Perhaps it'd be best to raise the issue to the package maintainers and
> have them specify their metadata correctly?
Going back to the example at the beginning of this thread, what ‘guix
import pypi tablib’ produces is missing ‘python-setuptools-scm’.
Indeed, ‘METADATA’ doesn’t mention it.
Is it really a bug on their side, or is it something peculiar about Guix
packaging? Perhaps ‘python-setuptools-scm’ should be provided more or
less by default?
> Having the code you wrote to allow importing optional dependencies is
> still a nice (optional) option to have though. It was originally left
> out based on comments from Ricardo that it wouldn't make a good default
> due to raising the packaging effort.
OK. Looking at <https://www.python.org/dev/peps/pep-0345/>, the
‘METADATA’ format apparently doesn’t support optional dependencies
anyway (which makes sense, because Wheels are a binary format), so
perhaps that idea was misguided.
(However ‘METADATA’ defines ‘Requires-External’, which the importer
could usefully interpret!)
WDYT?
Ludo’.
next prev parent reply other threads:[~2021-06-25 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:20 bug#49168: ‘guix import pypi’ misses package dependencies Ludovic Courtès
2021-06-22 8:34 ` Leo Prikler
2021-06-22 12:33 ` Ludovic Courtès
2021-06-22 12:37 ` Leo Prikler
2021-06-22 19:01 ` Maxim Cournoyer
2021-06-23 13:20 ` Ludovic Courtès
2021-06-23 14:17 ` Leo Prikler
2021-06-24 9:57 ` Ludovic Courtès
2021-06-24 19:04 ` Maxim Cournoyer
2021-06-25 14:51 ` Ludovic Courtès [this message]
2021-06-25 15:25 ` Leo Prikler
2021-06-25 16:39 ` Maxim Cournoyer
2021-06-28 9:39 ` Ludovic Courtès
2022-03-08 9:28 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtre2e1e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=49168@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).