unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
To: 55495@debbugs.gnu.org
Subject: bug#55495: Re: emacs-haskell-mode build fails
Date: Thu, 19 May 2022 12:14:17 -0300	[thread overview]
Message-ID: <87mtfdwjly.fsf@gmail.com> (raw)
In-Reply-To: <87o7zvtf8z.fsf@taiju.info>

Hi Taiju,

I also can't really understand why this didn't happen previously, 
the `vc-refresh-state' (which will need git in this case) is added 
to `find-file-hook' by default since before Emacs 28. The 
`haskell-generate-tags' test was last changed on 2016 and the 
`with-temp-dir-structure' on 2019 according to git blame. This 
code is called when the test runs `with-temp-dir-structure' on 
each of the created dirs:

--8<---------------cut here---------------start------------->8---
vc-refresh-state()
run-hooks(find-file-hook)
after-find-file(t t)
find-file-noselect-1(#<buffer Tx.hs> 
"/tmp/guix-build-emacs-haskell-
find-file-noselect("Tx.hs")
(set-buffer (find-file-noselect (car entry)))
(save-current-buffer (set-buffer (find-file-noselect (car entry))) 
(
(cond ((stringp (cdr entry)) (save-current-buffer (set-buffer 
(find-
(let ((entry (car --dolist-tail--))) (cond ((stringp (cdr entry)) 
(s
(while --dolist-tail-- (let ((entry (car --dolist-tail--))) (cond 
((
(let ((--dolist-tail-- entries)) (while --dolist-tail-- (let 
((entry
create-directory-structure((("Tx.hs" . "should_not_see_me :: 
Int")))
--8<---------------cut here---------------end--------------->8---

That happens because of this line on `create-directory-structure':
https://github.com/haskell/haskell-mode/blob/17.2/tests/haskell-test-utils.el#L235

I think it's fine to add git to the native inputs for this test 
specifically, as it only weights 346.8 MiB.

Regards,
-- 
Luis H. Higino




  parent reply	other threads:[~2022-05-19 16:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  8:30 bug#55495: emacs-haskell-mode build fails Taiju HIGASHI
2022-05-18 13:16 ` Liliana Marie Prikler
2022-05-18 14:39   ` Taiju HIGASHI
2022-05-18 14:31 ` bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-05-19 19:09   ` Liliana Marie Prikler
2022-05-20  2:29     ` Taiju HIGASHI
2022-05-20  8:49       ` Taiju HIGASHI
2022-05-19 15:14 ` Luis Henrique Gomes Higino [this message]
2022-05-20  9:49   ` bug#55495: Re: emacs-haskell-mode build fails Taiju HIGASHI
2022-05-20  9:54 ` bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-05-20 20:59   ` Taiju HIGASHI
2022-05-20 21:57     ` Liliana Marie Prikler
2022-05-20 22:52       ` Taiju HIGASHI
2022-05-20  9:59 ` bug#55495: [PATCH v2] " Taiju HIGASHI
2022-05-21  5:23 ` bug#55495: [PATCH v3] " Taiju HIGASHI
2022-05-31 19:29 ` bug#55495: (no subject) Luis Henrique Gomes Higino
2022-06-01  3:52   ` Taiju HIGASHI
2022-06-01 14:56     ` Luis Henrique Gomes Higino
2022-06-01 15:36       ` Taiju HIGASHI
2022-06-02  3:57 ` bug#55495: [PATCH v3] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-06-02  4:01   ` Taiju HIGASHI
2022-06-17 21:41 ` bug#55495: About v3 Luis Henrique Gomes Higino
2022-06-18 14:09   ` Taiju HIGASHI
2022-06-22  0:33 ` bug#55495: resolved by bug#56120 Taiju HIGASHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtfdwjly.fsf@gmail.com \
    --to=luishenriquegh2701@gmail.com \
    --cc=55495@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).