From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gLI/Ff2DuWJTxAAAbAwnHQ (envelope-from ) for ; Mon, 27 Jun 2022 12:18:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iE0fFf2DuWIeywAA9RJhRA (envelope-from ) for ; Mon, 27 Jun 2022 12:18:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 915C84238C for ; Mon, 27 Jun 2022 12:18:35 +0200 (CEST) Received: from localhost ([::1]:44916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5lpC-0005L6-Pc for larch@yhetil.org; Mon, 27 Jun 2022 06:18:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5loh-0005Gp-Kc for bug-guix@gnu.org; Mon, 27 Jun 2022 06:18:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5log-00043A-3q for bug-guix@gnu.org; Mon, 27 Jun 2022 06:18:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5log-0000YF-01 for bug-guix@gnu.org; Mon, 27 Jun 2022 06:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51466: bug#53355: guix shell --check: confusing error message Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 27 Jun 2022 10:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51466 X-GNU-PR-Package: guix X-GNU-PR-Keywords: moreinfo To: Chris Marusich Cc: 53355@debbugs.gnu.org, 51466@debbugs.gnu.org Received: via spool by 51466-submit@debbugs.gnu.org id=B51466.16563250402062 (code B ref 51466); Mon, 27 Jun 2022 10:18:01 +0000 Received: (at 51466) by debbugs.gnu.org; 27 Jun 2022 10:17:20 +0000 Received: from localhost ([127.0.0.1]:49887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5lnz-0000XA-P0 for submit@debbugs.gnu.org; Mon, 27 Jun 2022 06:17:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5lnw-0000Ws-21; Mon, 27 Jun 2022 06:17:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5lnq-0003xt-NV; Mon, 27 Jun 2022 06:17:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tq69ygapcaeSMPtR0e46Z1ob3EaoqV0nEqoigd4V6io=; b=BJLWYBpFcS15ktzUlQBm E+Ou6eBGxlFqVy/verjCXsfvAMsHS11DFdoS58lGYv86heQTo+MPtIuwm2izEnJsGJaUghIZlPBPf Kxo0LmWwriVlShnBW+pNCCB3qYCUcSj6/ZEqdcE91o6OGOcyS9hztk8bs11c1qmrJy9FxJJnfroyO ZnRN2iwl7MFUlsmgX5XgE3V4a6DMa5/hgl16sEdmyqDxzm1wEZLyZPOORFdkNr2ahmW+AWrVKaUox 4IYrTHrANKgc3BUUChXYHSGEglnma2IVAjysD11AkqibeCqGKMWm8uzXR37jfEKL8MfBFwAe/wT69 im95LpwDbY8BVA==; Received: from [193.50.110.235] (port=48724 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5lnq-0005Cp-9n; Mon, 27 Jun 2022 06:17:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87h7a08kub.fsf@gmail.com> <87lez5td4n.fsf@gnu.org> <87sftc4osu.fsf@gmail.com> <87h79slysd.fsf@gnu.org> <87sft13dyv.fsf@gmail.com> <874k59d802.fsf@gnu.org> <87wnhy2w73.fsf_-_@gmail.com> <878rudzsmv.fsf@gnu.org> <87sfozzglf.fsf_-_@gmail.com> <875ykpdsbd.fsf_-_@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 Messidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de l'Absinthe X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 27 Jun 2022 12:17:08 +0200 In-Reply-To: <875ykpdsbd.fsf_-_@gmail.com> (Chris Marusich's message of "Sat, 25 Jun 2022 02:07:50 -0700") Message-ID: <87mtdyif6j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656325117; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tq69ygapcaeSMPtR0e46Z1ob3EaoqV0nEqoigd4V6io=; b=PQ/jVzxFOsvFuuI9izQtVFB6qACQGrVe4+ibQBuwdWsa+za7F+FhdbzDj9T2aubLx0y7uz LntwNxI59sGXZwO+2vPqDsFP2IcnO/wP/Ab0DiH3k88XTdu32Hf4X6vwO86qTHe2lJ18CY of/9buLZ/iC2nL39Em++N7mL0dU1UkM2jRmPiK9E1Dh+mUZtp0lb+1iowaiFod4Ev3ytQ7 RxvdTwF2Dtde2QOcqCIihzS06rad48I5n3v10uWp9NnJMS0hKlzPVJ5UD8oCDhdOWmq62z f6jznjE4eTNCKVTqGIFAbOUcFpjQFXCz729uS9kcAzVOIwDnHMEbd32qf2Yupg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656325117; a=rsa-sha256; cv=none; b=fiaZRVC9zewk0qqJBhVo8vbMcpHxOB6V88ae2hMik9Dr/yFHIshEt2O9UWrv4TVnlsKREC zbQnvj/MhY5+TL1Q58ro0UuDaAMXQCRZsXmOdmKFzcibMmBYSpNz7R55FYR9L+R7bTCisc Ja/Moh/Wx6G3qteFmGqIodrkVyVCg8QvbLgMoXttP8rN8QLNpkOiVD39T886RQq5l1y7ic LIyiBQo4aLWk3Ffuf8zifyD9D3dCZ2B2cjsU4m4EYxsEw0el5sfmw1+9cEwUNEFXdplv8H vyvCq1nrTfVkmvZkizQ83gFJxCH9diHftW6MIY/SGHWIYQK7QeWSshTuwEKGSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BJLWYBpF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.85 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BJLWYBpF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 915C84238C X-Spam-Score: -3.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: dMPVnwQdVlrk Hi Chris, Chris Marusich skribis: > It turns out that it is probably not OK to rely on shell redirection in > this case, after all. For example, "dash does not support multi-digit > file descriptors": > > https://bugs.launchpad.net/ubuntu/+source/dash/+bug/249620 Bah. :-/ [...] > To resolve this, I changed the code so that it just writes to a > temporary file. This is simple and more robust. With the attached > patch, I was able to use a command like the one above to verify that > "guix environment --check" works correctly for Guix-built bash, dash, > ksh, fish, zsh, and ash. I also verified that it works for Fedora's > /bin/sh and /bin/bash. > > What do you think of this file-based approach? Supporting many > different shells is pretty tricky, but I think this patch does a good > enough job. Like Maxime, I=E2=80=99d rather not create a temporary file. I agree that Dash should be fixed, but in the meantime, we still want our stuff to work with the broken Dash (it=E2=80=99s the default on Debian/Ubuntu, isn=E2=80=99t it?). I don=E2=80=99t have a better idea to offer though=E2=80=A6 Ludo=E2=80=99.