unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 61684@debbugs.gnu.org
Subject: bug#61684: can't compose 'with-patch' with 'with-source'
Date: Tue, 21 Feb 2023 13:08:41 -0500	[thread overview]
Message-ID: <87mt56gac6.fsf@gmail.com> (raw)

Hi,

Given 'with-source' discards any patch from the original source, I thought
I could at least add them back via 'with-patch', but it appears this
does not work:

--8<---------------cut here---------------start------------->8---
scheme@(gnu packages jami)> (options->transformation 
                             `((with-source . "libjami@20230220.0=/home/maxim/src/jami/jami-20230220.0.tar.gz")
                               (with-patch . ,(string-append 
                                               "libjami=" (search-patch 
                                                           "jami-disable-integration-tests.patch")))))
$6 = #<procedure 7f2cd01a97e0 at guix/transformations.scm:1010:2 (obj)>
scheme@(gnu packages jami)> ($6 libjami)
$7 = #<package libjami@20230220.0 guix/transformations.scm:1002 7f2ccc8386e0>
scheme@(gnu packages jami)> (package-source $7)
$8 = #<<downloaded-file> uri: "/home/maxim/src/jami/jami-20230220.0.tar.gz" recursive?: #t>
scheme@(gnu packages jami)>
--8<---------------cut here---------------end--------------->8---

The downloaded-file resulting package source has lost the patch, and no
error got produced, leaving the user to discover this limitation by
themselves.

-- 
Thanks,
Maxim




             reply	other threads:[~2023-02-21 18:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 18:08 Maxim Cournoyer [this message]
2023-02-21 19:05 ` bug#61684: can't compose 'with-patch' with 'with-source' Simon Tournier
2023-02-23 14:08 ` Ludovic Courtès
2023-02-23 22:27   ` Maxim Cournoyer
2023-02-24 12:02     ` Simon Tournier
2023-02-24 13:21       ` Maxim Cournoyer
2023-02-24 13:43         ` Simon Tournier
2023-02-24 13:52           ` Maxim Cournoyer
2023-02-25 12:29             ` Simon Tournier
2023-02-25 19:43               ` Maxim Cournoyer
2023-02-27 14:12             ` Ludovic Courtès
2023-02-27 16:29               ` Maxim Cournoyer
2023-02-27 14:09       ` Ludovic Courtès
2023-02-28 10:00         ` Simon Tournier
2023-03-01 15:49           ` Ludovic Courtès
2023-02-24 13:59   ` Maxim Cournoyer
2023-03-03  9:43     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt56gac6.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=61684@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).