From: "Ludovic Courtès" <ludo@gnu.org>
To: "Picnoir" <picnoir@alternativebit.fr>
Cc: 71193@debbugs.gnu.org
Subject: bug#71193: Shepherd fails to start a system when given an incorrect form to the start field of any service
Date: Wed, 26 Jun 2024 15:47:52 +0200 [thread overview]
Message-ID: <87msn7byt3.fsf@gnu.org> (raw)
In-Reply-To: <87fru6uyzg.fsf@alternativebit.fr> (picnoir@alternativebit.fr's message of "Sat, 25 May 2024 09:33:55 +0200")
Hi Picnoir,
"Picnoir" <picnoir@alternativebit.fr> skribis:
> I think the following snippet is a good minimal reproducer for this. Add
> this service to a guix system configuration:
>
> --8<---------------cut here---------------start------------->8---
> (simple-service
> 'shepherd-bug-repro
> shepherd-root-service-type
> (list (shepherd-service
> (documentation "shepherd hang minimal repro")
> (provision '(shepherd-bug-repro))
> (requirement '())
> (start #~('())))))
> u--8<---------------cut here---------------end--------------->8---
>
> ⚠ DO NOT BOOT ON A CRITICAL SYSTEM WITH THIS SERVICE, IT'LL BRICK IT ⚠
>
> You can create a VM for this system and start it. The VM hangs after the
> log line "creating /etc/machine-id...", before any shepherd service gets
> started.
[...]
> Tested on Shepherd 0.10.4 with the Guix revision
> c5e63e19ac672f9e63fc8ee98fa9a16f978ce19c.
This sounds very much like <https://issues.guix.gnu.org/71144>, which
was fixed in Guix commit cca25a67693bb68a1884a081b415a43fad1e8641,
shortly after the commit you mention.
I tested the reproducer you posted in a VM and it boots fine. The
problem simply leads to an error message in /var/log/messages:
--8<---------------cut here---------------start------------->8---
Jun 26 15:43:09 localhost vmunix: [ 3.574026] shepherd[1]: Exception caught while loading '/gnu/store/c44hd3gfksalrbsgc3a0ax4v9jmnkzb4-shepherd-shepherd-bug-repro.go': #<&compound-exception components: (#<&assertion-failure> #<&origin origin: #f> #<&message message: "Wrong type to apply: ~S"> #<&i
Jun 26 15:43:09 localhost vmunix: [ 3.574132] rritants irritants: (())> #<&exception-with-kind-and-args kind: wrong-type-arg args: (#f "Wrong type to apply: ~S" (()) (()))>)>
Jun 26 15:43:09 localhost vmunix: [ 3.583838] shepherd[1]: starting services...
Jun 26 15:43:09 localhost vmunix: [ 3.585444] shepherd[1]: Configuration successfully loaded from '/gnu/store/8cch4dv5ca1v0hsgyr6d8jay513x7d8g-shepherd.conf'.
--8<---------------cut here---------------end--------------->8---
… and of course the faulty service doesn’t show up at all in ‘herd
status’.
Could you confirm it’s fine for you?
Thanks,
Ludo’.
prev parent reply other threads:[~2024-06-26 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 7:33 bug#71193: Shepherd fails to start a system when given an incorrect form to the start field of any service Picnoir
2024-06-26 13:47 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msn7byt3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=71193@debbugs.gnu.org \
--cc=picnoir@alternativebit.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).