From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#21829: guix import hackage failures Date: Thu, 12 Nov 2015 21:21:32 +0100 Message-ID: <87lha3ufxv.fsf@gnu.org> References: <87d1vghjhk.fsf@gnu.org> <87vb971t74.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwyNg-0003EP-74 for bug-guix@gnu.org; Thu, 12 Nov 2015 15:22:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwyNe-0001Pq-SW for bug-guix@gnu.org; Thu, 12 Nov 2015 15:22:04 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:44417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwyNe-0001Pm-On for bug-guix@gnu.org; Thu, 12 Nov 2015 15:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZwyNe-0007wt-F7 for bug-guix@gnu.org; Thu, 12 Nov 2015 15:22:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: (Federico Beffa's message of "Thu, 12 Nov 2015 17:54:48 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Federico Beffa Cc: 21829@debbugs.gnu.org Federico Beffa skribis: > On Thu, Nov 12, 2015 at 10:07 AM, Ludovic Court=C3=A8s wro= te: >> Federico Beffa skribis: >> I wonder if it wouldn=E2=80=99t be easier to change the lexer to recogni= ze line >> feeds are white space or newlines, maybe along these lines: > > What you suggest is not enough. You have to tweak a couple of other > places as well. > > I don't like having to mess around in token recognition code to > account for different eol styles. With my proposal I was trying to > abstract this away and make the eol style problem orthogonal to > parsing: first we convert to a "normal form" and then we operate on > it. Should we find some files in 'mac' eol-style (in Emacs parlance) > then it would be trivial to adapt. > > Could you be more explicit about what you do not like about this? I think the approach you suggest is fine, but I noticed that the places I changed were too specific anyway (looking for #\space and #\tab instead of the general char-set:whitespace class, for instance.) So I thought that it generalizing this would also fix the problem, that would be nice, because the change is more general than just fixing the CRLF issue. But maybe I=E2=80=99m missing other places, which would make the change too intrusive. That=E2=80=99s why I was asking for your feedback. Does that make sense? If we go for the CRLF conversion port, we should avoid the pipe and extra thread. Instead, I would suggest something like: (define (canonical-newline-port port) "Return an input port that wraps PORT such that all newlines consist of a single carriage return." (make-custom-binary-input-port =E2=80=A6)) WDYT? Thanks, Ludo=E2=80=99.