From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#22354: Hash-bang line length Date: Wed, 13 Jan 2016 11:25:03 +0100 Message-ID: <87lh7t7p4w.fsf__238.148650578474$1452680786$gmane$org@gnu.org> References: <87r3hnuple.fsf@T420.taylan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJIcw-0005V1-TJ for bug-guix@gnu.org; Wed, 13 Jan 2016 05:26:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJIcs-0007au-8K for bug-guix@gnu.org; Wed, 13 Jan 2016 05:26:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:59619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJIcs-0007aq-5M for bug-guix@gnu.org; Wed, 13 Jan 2016 05:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aJIcs-0007iE-1e for bug-guix@gnu.org; Wed, 13 Jan 2016 05:26:02 -0500 In-Reply-To: <87r3hnuple.fsf@T420.taylan> Sender: "Debbugs-submit" Resent-Message-ID: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: bug-bash@gnu.org Cc: 22354@debbugs.gnu.org Hello, The =E2=80=98READ_SAMPLE_BUF=E2=80=99 macro in execute_cmd.c reads at most = 80 bytes from the hash-bang line. This is less than the already-small 128-byte limit in the Linux kernel=C2=B9 and can quite easily be hit=C2=B2. What about changing it to 128 bytes (as well as the =E2=80=98sample=E2=80= =99 array) to at least match Linux? (It might even make sense to make it bigger so that Bash might succeed when the kernel simply fails.) Thanks, Ludo=E2=80=99. =C2=B9 http://lxr.free-electrons.com/source/include/uapi/linux/binfmts.h#L18 =C2=B2 See .