From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Allan Webber Subject: bug#22633: Provide a kvm-less qemu / guix system vm Date: Mon, 22 Feb 2016 13:30:21 -0800 Message-ID: <87lh6c8mc2.fsf@dustycloud.org> References: <87oabnqhv3.fsf@dustycloud.org> <20160211225009.GA4943@novena-choice-citizen.lan> <87oabm2tfa.fsf@gnu.org> <87ziv595xb.fsf@dustycloud.org> <87twl2xo6c.fsf@gnu.org> <87si0k8th9.fsf@dustycloud.org> <87r3g48rnh.fsf@dustycloud.org> <87bn78moz3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXy4R-0007ip-6H for bug-guix@gnu.org; Mon, 22 Feb 2016 16:31:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXy4M-0001xn-TS for bug-guix@gnu.org; Mon, 22 Feb 2016 16:31:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:41449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXy4M-0001xe-QZ for bug-guix@gnu.org; Mon, 22 Feb 2016 16:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aXy4M-000897-Mx for bug-guix@gnu.org; Mon, 22 Feb 2016 16:31:02 -0500 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-reply-to: <87bn78moz3.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 22633-done@debbugs.gnu.org Ludovic Courtès writes: > Christopher Allan Webber skribis: > >> Christopher Allan Webber writes: >> >>> Ludovic Courtès writes: >>> >>>> Libkmod honors ‘modprobe.blacklist’ (in ‘kcmdline_parse_result’ in >>>> libkmod-config.c) and eudev passes KMOD_PROBE_APPLY_BLACKLIST >>>> unconditionally in udev-builtin-kmod.c (meaning it honors it too.) >>>> >>>> However, there’s a hyphen-vs-underscore issue, I think. Namely, the >>>> file is called ‘kvm-intel.ko’, but the normalized module name is >>>> ‘kvm_intel’, and this is what libkmod expects (commit 5c7dd5a changes >>>> our code to normalize module names similarly.) >>>> >>>> Could you try with “modprobe.blacklist=kvm_intel”? >>> >>> I tried it, and it works! This does mean that /dev/kvm doesn't exist, >>> so I should be able to write a patch to Guix that disables kvm for qemu >>> when /dev/kvm is absent. Great! :) >> >> This is slightly based off of Leo's preliminary patch, so I included him >> in the copyright headers. I've tested and it works (in terms of >> disabling kvm if no /dev/kvm is present) here. > > Cool! Can you just double-check whether -enable-kvm has any effect when > /dev/kvm is missing? If it has no effect when /dev/kvm is missing, then > we don’t even need a patch. I checked yes; qemu fails. >> Let me know if I need to fix something or if I should push... >> >> From 852e0049213a0a80cacdcad4aba13ab242c3fbd8 Mon Sep 17 00:00:00 2001 >> From: Christopher Allan Webber >> Date: Mon, 22 Feb 2016 11:23:14 -0800 >> Subject: [PATCH] vm: Only pass "-enable-kvm" to qemu if /dev/kvm is present. >> >> * gnu/build/vm.scm (load-in-linux-vm): Only pass "-enable-kvm" flag to qemu >> if "/dev/kvm" is present. >> * gnu/system/vm.scm (common-kvm-options): Same as above. > > [...] > >> + ;; Only enable kvm if we see /dev/kvm exists. >> + ;; This allows uers without hardware virtualization to still use these > ^^ > Typo. > > [...] > >> + ;; Only enable kvm if we see /dev/kvm exists. >> + ;; This allows uers without hardware virtualization to still use these > > Ditto. Okay, fixed those. > Otherwise the patch LGTM. Make sure to mention: > > Fixes . > > in the commit log. Mentioned, committed, pushed!