unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 24832@debbugs.gnu.org
Subject: bug#24832: Hydra generates faulty derivation for gettext-boot0
Date: Mon, 31 Oct 2016 08:49:45 -0400	[thread overview]
Message-ID: <87lgx4d6om.fsf@netris.org> (raw)
In-Reply-To: <87d1igral2.fsf@gnu.org>

Hi Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:
> The bug stems from ‘ld-wrapper-boot0’ and was introduced in
> d75acc293dd3e63db8739aa04c021df917aa1b80.  The problem is that
> ‘ld-wrapper-boot0’ uses the value of (%current-system) on the machine
> that builds the derivation i.e., hydra.gnu.org.
> 
> Instead, it should use the value of the system we’re building for, so
> its evaluation should be delayed, as is the case for ‘inputs’ fields.
> 
> The result of this bug is that ‘ld-wrapper-boot0’ is bogus on all arches
> except x86_64.  However, this is harmless: we don’t need this ld wrapper
> anyway, except for GNU/Hurd.
> 
> So, a short-term hack might be this:
> 
> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
> index 53ba718..0a8e608 100644
> --- a/gnu/packages/commencement.scm
> +++ b/gnu/packages/commencement.scm
> @@ -424,8 +424,8 @@ the bootstrap environment."
>  (define ld-wrapper-boot0
>    ;; We need this so binaries on Hurd will have libmachuser and libhurduser
>    ;; in their RUNPATH, otherwise validate-runpath will fail.
> -  (make-ld-wrapper (string-append "ld-wrapper-" (boot-triplet))
> -                   #:target (boot-triplet)
> +  (make-ld-wrapper (string-append "ld-wrapper-" "x86_64-guix-linux-gnu")
> +                   #:target "x86_64-guix-linux-gnu"
>                     #:binutils binutils-boot0
>                     #:guile %bootstrap-guile
>                     #:bash (car (assoc-ref %boot0-inputs "bash"))))
> 
> That way, we would not have to rebuild anything (it temporarily breaks
> GNU/Hurd though, but that’s the cost we’d have to pay.)
> 
> How does that sound?

Ah, nice!  Could be avoid breaking GNU/Hurd by delaying evaluation of
‘ld-wrapper-boot0’ right now, but temporarily rigging it so that on all
_non-Hurd_ platforms, the hard-coded value "x86_64-guix-linux-gnu" is
used?

     Thanks!
       Mark

  reply	other threads:[~2016-10-31 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31  5:33 bug#24832: Hydra generates faulty derivation for gettext-boot0 on MIPS Mark H Weaver
2016-10-31  5:58 ` bug#24832: Hydra generates faulty derivation for gettext-boot0 Mark H Weaver
2016-10-31 12:01 ` Ludovic Courtès
2016-10-31 12:49   ` Mark H Weaver [this message]
2016-10-31 15:13     ` Ludovic Courtès
2017-01-20 22:17       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgx4d6om.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=24832@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).