From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 27437@debbugs.gnu.org
Subject: bug#27437: Source downloader accepts X.509 certificate for incorrect domain
Date: Wed, 21 Jun 2017 12:50:15 +0200 [thread overview]
Message-ID: <87lgolipi0.fsf@gnu.org> (raw)
In-Reply-To: <20170621061752.GA32412@jasmine.lan> (Leo Famulari's message of "Wed, 21 Jun 2017 02:17:52 -0400")
Hi,
Leo Famulari <leo@famulari.name> skribis:
> While working on some package updates, I found that the source code
> downloader will accept an X.509 certificate for an incorrect site.
>
> Here is what happens:
>
> ------
> $ ./pre-inst-env guix build -S opus-tools --check
> @ build-started /gnu/store/nn93hkik8kvrigcf2pvmym01zg7jqm4v-opus-tools-0.1.10.tar.gz.drv - x86_64-linux /var/log/guix/drvs/nn//93hkik8kvrigcf2pvmym01zg7jqm4v-opus-tools-0.1.10.tar.gz.drv.bz2
>
> Starting download of /gnu/store/0js62s7pz9gfcdsd1n764w91mhhwkws4-opus-tools-0.1.10.tar.gz
> From https://downloads.xiph.org/releases/opus/opus-tools-0.1.10.tar.gz...
> ….1.10.tar.gz 305KiB 822KiB/s 00:00 [####################] 100.0%
> warning: rewriting hashes in `/gnu/store/vdpyfqzp0kkjpxr79fq3an7j4s4vkz0h-opus-tools-0.1.10.tar.gz'; cross fingers
> /gnu/store/vdpyfqzp0kkjpxr79fq3an7j4s4vkz0h-opus-tools-0.1.10.tar.gz
> ------
>
> Here is an example of what I think should happen in this case:
>
> ------
> $ curl https://downloads.xiph.org/releases/opus/opus-tools-0.1.10.tar.gz
> curl: (51) SSL: certificate subject name (osuosl.org) does not match target host name 'downloads.xiph.org'
> ------
Also:
--8<---------------cut here---------------start------------->8---
$ guix download https://downloads.xiph.org/releases/opus/opus-tools-0.1.10.tar.gz
Starting download of /tmp/guix-file.vjPVRk
From https://downloads.xiph.org/releases/opus/opus-tools-0.1.10.tar.gz...
ERROR: X.509 server certificate for 'downloads.xiph.org' does not match: C=US,postalCode=97331,ST=OR,L=Corvallis,street=Oregon State University,street=Kerr Admin Building,O=Oregon State University,OU=OSU OSL,CN=osuosl.org
failed to download "/tmp/guix-file.vjPVRk" from "https://downloads.xiph.org/releases/opus/opus-tools-0.1.10.tar.gz"
guix download: error:
https://downloads.xiph.org/releases/opus/opus-tools-0.1.10.tar.gz: download failed
--8<---------------cut here---------------end--------------->8---
The behavior of the source download is on purpose as noted in (guix
download):
;; No need to validate certificates since we know the
;; hash of the expected result.
#:verify-certificate? #f)))))
IOW, since we’re checking the integrity of the tarball anyway, and we
assume developers checked its authenticity when writing the recipe, then
who cares whether downloads.xiph.org has a valid certificate?
Conversely, ‘guix download’ always checks certificates by default.
Does it make sense?
Ludo’.
next prev parent reply other threads:[~2017-06-21 10:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 6:17 bug#27437: Source downloader accepts X.509 certificate for incorrect domain Leo Famulari
2017-06-21 10:50 ` Ludovic Courtès [this message]
2017-06-22 4:09 ` Leo Famulari
2017-06-22 7:57 ` Ludovic Courtès
2017-06-22 16:16 ` Leo Famulari
2017-06-22 15:33 ` Mark H Weaver
2017-06-22 16:11 ` Leo Famulari
2017-06-22 19:12 ` Ludovic Courtès
2017-06-23 0:45 ` Mike Gerwitz
2017-06-23 9:31 ` Ludovic Courtès
2017-06-22 21:30 ` ng0
2017-06-22 21:45 ` Ricardo Wurmus
2017-06-22 22:32 ` Marius Bakke
2017-06-23 3:24 ` Leo Famulari
2017-06-23 7:29 ` Ricardo Wurmus
2017-07-27 12:29 ` Ludovic Courtès
2017-07-27 19:34 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgolipi0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27437@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).