From: ludo@gnu.org (Ludovic Courtès)
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 32245@debbugs.gnu.org
Subject: bug#32245: Guix does not search sources locally by hash
Date: Mon, 23 Jul 2018 16:50:49 +0200 [thread overview]
Message-ID: <87lga2ovjq.fsf@gnu.org> (raw)
In-Reply-To: <20180723115053.67423d42@alma-ubu> ("Björn Höfling"'s message of "Mon, 23 Jul 2018 11:50:53 +0200")
Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:
> On Mon, 23 Jul 2018 10:41:14 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Hi,
>>
>> Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:
>>
>> > $> ./pre-inst-env guix build java-eclipse
>> > [..]
>> > @
>> > build-started /gnu/store/lqfw971srfifgql68ibdgh58vi4d8fq3-java-eclipse-oxygen-3a-linux-gtk-x86_64.tar.gz.drv
>> > -
>> > x86_64-linux /var/log/guix/drvs/lq//fw971srfifgql68ibdgh58vi4d8fq3-java-eclipse-oxygen-3a-linux-gtk-x86_64.tar.gz.drv.bz2
>>
>> [...]
>>
>> > But it does NOT search locally. Because I already have:
>> >
>> > guix
>> > hash /gnu/store/56h6snwcawpzk6rhcwgk442wsx6k86q2-eclipse-java-oxygen-3a-linux-gtk-x86_64.tar.gz
>> > 0m7y7jfm059w01x9j5b5qkinjjmhkyygpjabhjf19fg2smxmwcim
>>
>> It does, but the file name matters. In this case what you have is
>> “eclipse-java-…” but you’re trying to build “java-eclipse-…”.
>>
>> So you first need to add the file to the store under its expected
>> name. You can do that for instance with:
>>
>> guix download file://…/java-eclipse-…
>>
>> HTH!
>
> Not sure yet. I havent't tried it yet, but I'm sure your solution
> helps with the specific problem here. (Also updating the URL helps even
> better :-))
>
> What I feel strange here is:
>
> * When the file is already on the local disk, it has to match a certain
> file name criteria. Quite hard criteria.
> * But when asking outside repositories over the network, we just "take
> anything that has the hashsum".
>
> Is that wanted behaviour?
It’s not optimal, as you pointed out. But it’s not implemented in these
terms. The ‘add-to-store’ RPC returns a file name that’s a function of
the content and the file name. So the way ‘add-to-store’ works is:
1. compute store file name = g(content, filename)
(See ‘fixed-output-path’ in (guix store).)
2. if store file name exists, return it, else create it.
Since /var/guix/db/db.sqlite contains the content hash of each store
item, we could in theory perform a lookup by hash. To do that we’d need
to add a new RPC and use it in the correct places. It’d be a nice
addition.
Ludo’.
next prev parent reply other threads:[~2018-07-23 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 9:56 bug#32245: Guix does not search sources locally by hash Björn Höfling
2018-07-23 8:41 ` Ludovic Courtès
2018-07-23 9:50 ` Björn Höfling
2018-07-23 14:50 ` Ludovic Courtès [this message]
2018-10-22 7:00 ` Björn Höfling
2018-10-22 8:06 ` Gábor Boskovits
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lga2ovjq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32245@debbugs.gnu.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).