unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 39712@debbugs.gnu.org
Subject: bug#39712: Partitions produced by the installer not properly unmounted?
Date: Fri, 21 Feb 2020 12:13:22 +0100	[thread overview]
Message-ID: <87lfownqgd.fsf@inria.fr> (raw)

Hi Mathieu,

I noticed that partitions created by the installer appear to not be
properly unmounted, at least when running in the context of (gnu tests
install):

--8<---------------cut here---------------start------------->8---
ludo@ribbon ~$ qemu-img convert -O raw /gnu/store/2d3s2nbb3j2c1hmkz52xds9rfbk4q3x3-installation /tmp/broken.raw
ludo@ribbon ~$ sudo losetup -P /dev/loop0 /tmp/broken.raw 
ludo@ribbon ~$ sudo dmesg |tail -3
[10703.869334] kvm [8936]: vcpu0, guest rIP: 0xffffffffac073dad disabled perfctr wrmsr: 0xc2 data 0xffff
[10742.475623] kvm [8957]: vcpu0, guest rIP: 0xffffffffaf073dad disabled perfctr wrmsr: 0xc2 data 0xffff
[11774.318468]  loop0: p1 p2 p3
ludo@ribbon ~$ sudo fdisk -l /dev/loop0
Disk /dev/loop0: 2.15 GiB, 2306867200 bytes, 4505600 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 213AE251-0E91-499E-9184-0CCEC6DA64C7

Dispositiu    Start   Final Sectors  Size Tipus
/dev/loop0p1   2048    6143    4096    2M BIOS boot
/dev/loop0p2   6144  231423  225280  110M Intercanvi Linux
/dev/loop0p3 231424 4503551 4272128    2G Linux filesystem
ludo@ribbon ~$ sudo mount /dev/loop0p3 /mnt/usb
ludo@ribbon ~$ sudo dmesg |tail -3
[11774.318468]  loop0: p1 p2 p3
[11803.975300] EXT4-fs (loop0p3): recovery complete
[11803.977277] EXT4-fs (loop0p3): mounted filesystem with ordered data mode. Opts: (null)
--8<---------------cut here---------------end--------------->8---

However, I’ve added logging in ‘umount-user-partitions’ in (gnu
installer parted), and the installer does seem to unmount partitions
correctly.

Could it be a side effect of the MS_MOVE dance in
1d02052067e04d7dd8fd1ec17557ca02a30b9bcf?

(I’m observing this on ‘wip-installer-tests’, roughly based on
117d8467be232bcc1b0136d04f362d95d975ca95.)

Thanks,
Ludo’.

             reply	other threads:[~2020-02-21 11:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 11:13 Ludovic Courtès [this message]
2020-02-21 15:27 ` bug#39712: Partitions produced by the installer not properly unmounted? Mathieu Othacehe
2020-02-21 20:43   ` Ludovic Courtès
2020-02-22 10:24     ` Mathieu Othacehe
2020-02-22 17:13       ` Ludovic Courtès
2020-03-13 15:52         ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfownqgd.fsf@inria.fr \
    --to=ludo@gnu.org \
    --cc=39712@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).