From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QIjlC5n3S2HgMQEAgWs5BA (envelope-from ) for ; Thu, 23 Sep 2021 05:42:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CMWoB5n3S2H2HgAA1q6Kng (envelope-from ) for ; Thu, 23 Sep 2021 03:42:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7489A5601 for ; Thu, 23 Sep 2021 05:42:16 +0200 (CEST) Received: from localhost ([::1]:44032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTFcl-0007Te-Gd for larch@yhetil.org; Wed, 22 Sep 2021 23:42:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTFcY-0007TU-96 for bug-guix@gnu.org; Wed, 22 Sep 2021 23:42:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTFcX-00071Y-W1 for bug-guix@gnu.org; Wed, 22 Sep 2021 23:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTFcX-0002gJ-TN for bug-guix@gnu.org; Wed, 22 Sep 2021 23:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50299: The check-tests-true lint check is incorrect for Emacs packages Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 23 Sep 2021 03:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50299 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Received: via spool by 50299-submit@debbugs.gnu.org id=B50299.163236848810258 (code B ref 50299); Thu, 23 Sep 2021 03:42:01 +0000 Received: (at 50299) by debbugs.gnu.org; 23 Sep 2021 03:41:28 +0000 Received: from localhost ([127.0.0.1]:52345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTFbz-0002fO-RN for submit@debbugs.gnu.org; Wed, 22 Sep 2021 23:41:28 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:46855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTFbx-0002f9-72 for 50299@debbugs.gnu.org; Wed, 22 Sep 2021 23:41:26 -0400 Received: by mail-qk1-f169.google.com with SMTP id b65so17068912qkc.13 for <50299@debbugs.gnu.org>; Wed, 22 Sep 2021 20:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RLXpY/GqmOIVCXJvz5Hc4f/WQPzGBzdEvAi+zh/rmEU=; b=SnGLxRNh3gmL3n1JCGVHbqQua6ELI2h4ZisA7F2oFxrs9Y8DGDyw0j5ebDKi5Abo6s JJp/8wycWBPCN7vaIrVvOoueuMzYY5VUDhMPY+mieXEJzAf14D4pSNlTJeKu3JjJV7OF 6WW6OjqF4MDSaklshwJJpRDP1EryL3M3CwrSia4pSRKWsg5pfG36yXTCYXCd5FujXbxK V7ounlNxO+8ntSZuJjsZvTSvIGcUM3uh03yPhyte8yrOwzxMGDfRQHXbtqcDwnMh0pOh ETsf8CMDRZzFN17mlGgrcnbaDzWBs5wmjt1CQHDACzcN1wdx77XODhm5o6XNDq7Y3Ql1 7Bdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RLXpY/GqmOIVCXJvz5Hc4f/WQPzGBzdEvAi+zh/rmEU=; b=G6sB/UAQM4Acf/XE/s140aaXsQh1nGdOE2Zauy7ofdcvxJ+MPKMP6XQvqKvmQ0Biii bnc4GWVFc95YLkdSN892sA/hYOYEkA1ZjQ1+9KM1imJyuHL7TimoZnvujq2in0gwNDun k0bUJcXE8PgDMdCmzBKMRmgBuq+zZ/XVTFdJKEvw68hAVwH8BG2F2IXRfL5xA96H54hY JqiPZHzqxxP+ZTBuD4trPPLml17tCmwXlWVI/TmIybHNyWjBReqlGgb/U5ByUUvpU0d5 KcTLFCRvlOEehE+ZB4lEbPfnpEFn/EfHcrdgXtvgXEBoiWoti2ZtS+FfraXgzwhEp7Qa zz9w== X-Gm-Message-State: AOAM5336rFKqbiMQj/As1dLVHucexlCTRflWFMOQI32+Ixled6eD5PYU 0GWMfWzPQ726XD4CNhCskufjC/Z17ng= X-Google-Smtp-Source: ABdhPJzVPIBW+uIMqKOT2BMIyYQnnapqXf7qSLOdIcBE+qA2ZeKAZQGEoPrYASs2bMA7MCcRNXDUjg== X-Received: by 2002:a37:27d5:: with SMTP id n204mr2760414qkn.31.1632368479330; Wed, 22 Sep 2021 20:41:19 -0700 (PDT) Received: from hurd (dsl-157-23.b2b2c.ca. [66.158.157.23]) by smtp.gmail.com with ESMTPSA id m27sm3260436qkm.57.2021.09.22.20.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 20:41:19 -0700 (PDT) From: Maxim Cournoyer References: <87mtoxiqkw.fsf@gmail.com> <31f8389794c709cf91334d283513d1bf42382308.camel@telenet.be> Date: Wed, 22 Sep 2021 23:41:18 -0400 In-Reply-To: <31f8389794c709cf91334d283513d1bf42382308.camel@telenet.be> (Maxime Devos's message of "Tue, 07 Sep 2021 14:34:21 +0200") Message-ID: <87lf3oklgh.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50299@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632368536; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=RLXpY/GqmOIVCXJvz5Hc4f/WQPzGBzdEvAi+zh/rmEU=; b=aVxIqIRQLUXCIEd1GMLK6K6ytfL7Dr3YrGPrTtph4Cthi4jzQBhXEwFrq1TQx07K2zitwL xoRJWnlC392Fv7jgjFuLXWx71EJPdzs0uyK8myuP44htDWvfX0r8so9WR5XRADX5APDzlG sZ30a9mJH92psNd9dg7FvHu3woTA70flPZgslM+tF96Z3x3woG6Tas/snu/GYGIBcyxHm/ CkQdl5rok+1vBiyBNNq9UtHrs56xaL98Q8T6Nr3AtrL75gZynBdS0OUMp4J5aeD5AahLjF RYHOt9zhbDv1uuRJkpQHhFXRm664X9m7bJImYyrCKZ1SqARK+tLWSmZw359jjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632368536; a=rsa-sha256; cv=none; b=BtD5Uy9cy8HKK2FRZuYm7Q23iwcdYBoF4DD22WSiLmgnwgXRQiUXljKc34ytlP2bUxsKq7 s8g/voECKRTbTtilXBssIePxevEyefEqigWMya0TCbll9Ku9BlOacHZSnwYPjtrlyRO0EA UQa9gpsTFs3JKGcJ+0NohllrHeTVjRiswe3AV295bfROBFZMtDby01FPI75W+CTdrMW3Bs bGgY4HNtFicMbw67+ZV94XpVXwcAlkO64X+2aB2x4hgZlKz39NgqaXT2nT6yZZ1ifW42hu 10uAqnAMlclY8lFH1j/561QFgWk5FxyZoAlY1finwH0kZ8cFR1DFncK5v5YlOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SnGLxRNh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SnGLxRNh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 7489A5601 X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: vkEVVew0BHLT Hello Maxime, Maxime Devos writes: > Hi > > The attached patch should fix this. > > Greetings, > Maxime. > > From c8efd59560509381920cbfe915279bd16077552d Mon Sep 17 00:00:00 2001 > From: Maxime Devos > Date: Tue, 7 Sep 2021 14:25:43 +0200 > Subject: [PATCH] lint: check-tests-true: Allow #:tests? #t for > emacs-build-system. > > emacs-build-system sets #:tests? #f by default, so the linter > shouldn't warn if #:tests? #t is set for packages using > emacs-build-system. > > * guix/lint.scm (check-tests-true): Do not warn if the build system > is emacs-build-system. > > Fixes: > Reported-by: Maxim Cournoyer > --- > guix/lint.scm | 5 +++++ > tests/lint.scm | 10 ++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/guix/lint.scm b/guix/lint.scm > index 8e80aae938..f708465ed8 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -34,6 +34,7 @@ > #:use-module (guix store) > #:autoload (guix base16) (bytevector->base16-string) > #:use-module (guix base32) > + #:use-module (guix build-system emacs) > #:use-module (guix diagnostics) > #:use-module (guix download) > #:use-module (guix ftp-client) > @@ -279,6 +280,10 @@ superfluous when building natively and incorrect when cross-compiling." > (eq? tests? #t)) > (package-arguments package))) > (if (and (tests-explicitly-enabled?) > + ;; emacs-build-system sets #:tests? #f by default, therefore > + ;; writing #:tests? #t in package definitions using > + ;; emacs-build-system is reasonable. > + (not (eq? emacs-build-system (package-build-system package))) > ;; Some packages, e.g. gnutls, set #:tests? > ;; differently depending on whether it is being > ;; cross-compiled. Grepping for (tests? #f), I found texlive-build also defaults to #f, so should be treated the same. OK to push with such a change. Thank you! Maxim