unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55638@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: bug#55638: time-machine: backtrace about maybe-remove-expired-cache-entries
Date: Sat, 28 May 2022 19:12:19 +0200	[thread overview]
Message-ID: <87leulbmz0.fsf@gnu.org> (raw)
In-Reply-To: <bc32e583c62832e3c64b1f75455d196bf0ec48ee.camel@telenet.be> (Maxime Devos's message of "Thu, 26 May 2022 17:12:18 +0200")

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> It's a work-around, but there's still an underlying problem: 
> guix/cache.scm doesn't do 'fsync+rename', so the file is not created
> atomically, so in case of an abrupt shutdown or C-c at the wrong time,
> the file becomes corrupted without fault of the file system.

Right, I guess this is what we should fix first, by using
‘with-atomic-file-output’ for instance.

> As such, WDYT of making last-expiry-date more robust, by treating
> invalid contents as time=0 or something like that?

That too.

Ludo’.




  reply	other threads:[~2022-05-28 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 16:49 bug#55638: time-machine: backtrace about maybe-remove-expired-cache-entries zimoun
2022-05-26 15:05 ` Ludovic Courtès
2022-05-26 15:12   ` Maxime Devos
2022-05-28 17:12     ` Ludovic Courtès [this message]
2022-05-30 13:11       ` zimoun
2022-05-27  8:31   ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leulbmz0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=55638@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).