From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YLQDAb7CQGPQhgAAbAwnHQ (envelope-from ) for ; Sat, 08 Oct 2022 02:22:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ENcwAb7CQGOkCwEA9RJhRA (envelope-from ) for ; Sat, 08 Oct 2022 02:22:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 98E4522211 for ; Sat, 8 Oct 2022 02:22:21 +0200 (CEST) Received: from localhost ([::1]:37376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogxbg-0000xd-CD for larch@yhetil.org; Fri, 07 Oct 2022 20:22:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogxbQ-0000w6-Dy for bug-guix@gnu.org; Fri, 07 Oct 2022 20:22:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogxbP-0004RP-1d for bug-guix@gnu.org; Fri, 07 Oct 2022 20:22:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogxbO-0004z2-9t for bug-guix@gnu.org; Fri, 07 Oct 2022 20:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#22608: Module system thread unsafety and .go compilation Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 08 Oct 2022 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22608 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Taylan Ulrich "=?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=" , 22608@debbugs.gnu.org, guile-devel@gnu.org Received: via spool by 22608-submit@debbugs.gnu.org id=B22608.166518850819134 (code B ref 22608); Sat, 08 Oct 2022 00:22:02 +0000 Received: (at 22608) by debbugs.gnu.org; 8 Oct 2022 00:21:48 +0000 Received: from localhost ([127.0.0.1]:37668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogxb9-0004yX-Ix for submit@debbugs.gnu.org; Fri, 07 Oct 2022 20:21:47 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:42582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogxb7-0004yK-6O for 22608@debbugs.gnu.org; Fri, 07 Oct 2022 20:21:46 -0400 Received: by mail-qt1-f171.google.com with SMTP id w28so1779846qtv.9 for <22608@debbugs.gnu.org>; Fri, 07 Oct 2022 17:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=DzqMU2SeRW+01Tz4ClXeMY2bOTVlhrtEkPdpunAbz6U=; b=SrylB8lPOJyjZBnqhFscyTzxFHOw0YGLyICX8YcQd9/MoSsYHVU040IsuOr4iND4eZ KuSH4y5tz7lT1tR99j/h+Wcl7uBkytLf+Hf0+B04KqBG4jzUUcrHAhwCfib1CPu9um1O 4usMMXQy4JjT+JzDTJtuTMMZ5p0M1cx6tGqv+rdxbzHTtYtXUTFCKNrCTbHUKB7sCk/0 W7Zj0nzGRxdnaZqSFeP4TVqdEYPXZLcq6sk8Q0IbeDgtadU/6e+3qjS7l0kutfwyEpkC 9JSJI+fdwQ/Sv0hOOHckDUhd5iu9CgZM+MGGACHtOnEihPwmNu4Tgtmybv79Fv6PJxQh ScyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DzqMU2SeRW+01Tz4ClXeMY2bOTVlhrtEkPdpunAbz6U=; b=h8hVIcGUSJSzVI5iFd8pZDpII+CZXDfgKVuzzLuAYton5bsjDItVv6HVOcPFz08CIl M/hJz0ETQ0I4weFoKeEAjVhDqBYlp/OJ5mlK+yCdmM2LNdMKpPuG4zz1hFqdtR3omc4p 8pmsqPFWGZVYsrNtCiVDkIJcYCap8KEl7HNlCU3jBk5clWamHaYrz6FsPTZgMVVca5di 1BrWvpM248xhpvHLXvGo9xR16NxBYdhueEDX/5DT7mh/Ov0MfqXzI+mYCet5KxUVh/ZD OWMSvX+CqSvxZ/jaMi/m03N0uBllQyEZxdBnmUM488BBEZm9VhK0blXVmUFWcM/Cjhm8 Sytg== X-Gm-Message-State: ACrzQf3x3IzgWcDACyc4H2UYEI/cyyJ3CaT/CZAxbnmks0+iSS32MUCU 6oiFcgPIVzbsOXVUABa9gfg= X-Google-Smtp-Source: AMsMyM6sjYiyNaLFUT+3SdZ0YZJfxQ6bT3kx2Ewn6D620zvLx33rZ/YAyZP1Hu5lzEFOUA+L9LoD8Q== X-Received: by 2002:ac8:5b04:0:b0:375:f4d7:50cc with SMTP id m4-20020ac85b04000000b00375f4d750ccmr6565007qtw.333.1665188499731; Fri, 07 Oct 2022 17:21:39 -0700 (PDT) Received: from hurd ([2607:fad8:4:3::1005]) by smtp.gmail.com with ESMTPSA id h10-20020a05620a284a00b006b9c9b7db8bsm3331794qkp.82.2022.10.07.17.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 17:21:39 -0700 (PDT) From: Maxim Cournoyer References: <8737t1k5yk.fsf@T420.taylan> <87d0w4ezst.fsf@gnu.org> Date: Fri, 07 Oct 2022 20:21:37 -0400 In-Reply-To: <87d0w4ezst.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 04 Jul 2018 00:10:10 +0200") Message-ID: <87lepr412m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665188541; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DzqMU2SeRW+01Tz4ClXeMY2bOTVlhrtEkPdpunAbz6U=; b=OBIfZN/rFRmfv5K0jZFRaLWFvA05KGNbFTTg6A8msUvGlP2QEBuAAjtK4Ajj883rEoPWnQ RfUuNm0/3clwlUCkCdEhu1VCMLZ6+ikCXtXcSmhOFzr1NkaVdso3YTMx3xwGEKUDlxugsq vsP1r0Qo9DO8CJhAqma7KWKWd1JjSvJg3jgHKexEqRcW+B4IPbXT2+0xigVh6xCPSpbloD WZt9bhVeJchs08jYhlUu7vSX/qYcXU7VOHzO/vh3wd+JGgaTfDD4V06aAt55XtMyjSfrQO 4cAWjXLXJRIlQJ7GSuaIPiDFzobqmphDab97U073NS7j51TmfNEESAG853N7HQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665188541; a=rsa-sha256; cv=none; b=aUzSImB4qYb93+6u0VRNj0/C+NOD7F4tBCDpr6ulXZhNb5lEcg+eWZE+JSM8CTRJTlak+J uVfudf2dM03MDyAkPDzqgu9dypUfB5el6htqw2U55jOY9qAyi3J4cuTc7z6cbhdN6tpSa9 lrDUny28NJF4Z1+VI67Ahl96fSV7s+ip2BcjI2Gtp2OCapMUO3UmTHorhkamrCUfM372sD lO1XLguMA79VuEaTc+v1aeTdgDxRjRhzB59bk+e01zO/CHLnYoWy5DSEUsHY5ZM6zRgd+j hPuPxcV+/BUIRoWS2I83a8gdPRUokaHZoRwLcVcG5aRB0NZ9ixpMFVkpqHSCdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SrylB8lP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SrylB8lP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 98E4522211 X-Spam-Score: 6.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: GOKHBUpmwUgk Hi, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello, > > taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribi= s: > >> To speed up the compilation of the many Scheme files in Guix, we use a >> script that first loads all modules to be compiled into the Guile >> process (by calling 'resolve-interface' on the module names), and then >> the corresponding Scheme files are compiled in a par-for-each. >> >> While Guile's module system is known to be thread unsafe, the idea was >> that all mutation should happen in the serial loading phase, and the >> parallel compile-file calls should then be thread safe. >> >> Sadly that assumption isn't met when autoloads are involved. > > For the record, these issues should be fixed in Guile 2.2.4: > > 533e3ff17 * Serialize accesses to submodule hash tables. > 46bcbfa56 * Module import obarrays are accessed in a critical section. > 761cf0fb8 * Make module autoloading thread-safe. > > =E2=80=98guix pull=E2=80=99 now defaults to 2.2.4, so we=E2=80=99ll see i= f indeed those crashes > disappear. I think we haven't seen these in the last 4 years! We still have references to https://bugs.gnu.org/15602 in our code base though; although the upstream issue appears to have been fixed. Could we remove the workarounds now? --=20 Thanks, Maxim