From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KM4iAGSD8mMjSgEAbAwnHQ (envelope-from ) for ; Sun, 19 Feb 2023 21:15:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mFwkAGSD8mPucgAA9RJhRA (envelope-from ) for ; Sun, 19 Feb 2023 21:15:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF89D10E41 for ; Sun, 19 Feb 2023 21:15:31 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676837731; a=rsa-sha256; cv=none; b=ejViwf/XM19o17OYSQ+hN0up59j8n7gQK8YbotUmT5SYnVBEEkm3S/t0Y3DbDjYmMDG0so hCUnTW98HCnofQPZEYu75C2KBHfKu2YnGoF/PD/5dl3U+bz2rsv7VMNLmVUJorcSdDoY1z vsm8nfxzOi+fVaWV2x/xktZLwftPrgANkY5hyRYOhRcr8lCiiZSEg/wvUHiuRy7CDmDyfZ hME8qhEHxnoyM+6e4Ezx4pc/e12EYHJvCXSS4IClR5StioReMe0b/bChp/9yWmG0nXwyNm iQBqRqfpWr2CJSjvITge5CP5M5+Gnm+cWRE14M/cLVre39cP16Ta1E/zELCT2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676837731; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=oH2Bseo2s5H3FHEHBQkqgLmdoFK/yPcCtcdFDuembVA=; b=ZXheGOukhSKPT0bgBmaERkmqGGlBpwal8x88ZwIyQseq1OWgAsWLFu0rLabOuqnIysU475 DPXbi/cvx77/OrsIheBfQSnG2QVM90zJXNdkb9cKKW6GrBbhHinn9t8cajaGjFu91g7HiF qNjB5UceU81UF+9WVmLvh3DxygRMLSf3/BOXBnoU4cCMq021RiD1REmb1yEBFFt4BHVvMe x4x9UfdMriaSfh3Vh6tK8ykfXqZEPKSjl25xXK+Vy/rfpBxVDVU40+flupmTWGpf334sK/ sZfKyBttDeNQ+tWZZti2WspYtFEKzjLEGHCOkqQtysIcdlU4BELps7QorlLGNg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTq5Y-0006V8-8X; Sun, 19 Feb 2023 15:15:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTq5O-0006UT-Oa for bug-guix@gnu.org; Sun, 19 Feb 2023 15:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTq5O-000576-Fq for bug-guix@gnu.org; Sun, 19 Feb 2023 15:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTq5O-00029R-BJ for bug-guix@gnu.org; Sun, 19 Feb 2023 15:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH v4 3/9] gnu: Define %icecat-base-version at the top level. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 19 Feb 2023 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 32026@debbugs.gnu.org Cc: ludo@gnu.org, Jonathan Brielmaier , Maxim Cournoyer Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16768376988247 (code B ref 32026); Sun, 19 Feb 2023 20:15:02 +0000 Received: (at 32026) by debbugs.gnu.org; 19 Feb 2023 20:14:58 +0000 Received: from localhost ([127.0.0.1]:49746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTq5K-00028w-9X for submit@debbugs.gnu.org; Sun, 19 Feb 2023 15:14:58 -0500 Received: from world.peace.net ([64.112.178.59]:36048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTq5I-00028i-HJ for 32026@debbugs.gnu.org; Sun, 19 Feb 2023 15:14:56 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTq5B-0003k7-4T; Sun, 19 Feb 2023 15:14:49 -0500 From: Mark H Weaver In-Reply-To: <20230219192405.26549-3-maxim.cournoyer@gmail.com> References: <20230219192405.26549-1-maxim.cournoyer@gmail.com> <20230219192405.26549-3-maxim.cournoyer@gmail.com> Date: Sun, 19 Feb 2023 15:13:55 -0500 Message-ID: <87lektct0h.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: BF89D10E41 X-Spam-Score: -2.74 X-Migadu-Spam-Score: -2.74 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: TECsQXBwuy9T Hi Maxim, Maxim Cournoyer writes: > * gnu/packages/gnuzilla.scm (%icecat-base-version): New variable. > (%icecat-version): Define in terms of %icecat-base-version. > (icecat-source): Adjust to use the above newly introduced variables. What's the rationale for this? I couldn't find any uses of '%icecat-base-version' in your patch set outside of 'icecat-source'. I don't have a strong objection, but it seems unjustified. Thanks, Mark