From: Jelle Licht <jlicht@fsfe.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>,
61497-done@debbugs.gnu.org
Subject: bug#61497: emacs-lsp-treemacs unused leftover icons in sources
Date: Mon, 06 Mar 2023 15:15:09 +0100 [thread overview]
Message-ID: <87leka0xw2.fsf@fsfe.org> (raw)
In-Reply-To: <3c5bf58df07650ebeaf0c9411c0a23a548904e24.camel@gmail.com>
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht:
>> Commit e0d2ec418bb on master removed icons that are unclearly
>> licensed
>> from the sources of emacs-lsp-treemacs. Quoted here:
>>
>> --8<---------------cut here---------------start------------->8---
>> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.
>>
>> emacs-lsp-treemacs bundles icons with unclear licenses.
>> See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
>> --8<---------------cut here---------------end--------------->8---
>>
>> Some icons are still left in the sources, in the 'icons/vscode'
>> directory' of the source tarball one builds by running `guix build
>> --source emacs-lsp-treemacs'. I have never used vscode, and am
>> unfamiliar with the licensing situation of it and its related icons.
>>
>> In case these icons are also unclearly licensed, I propose we follow
>> the same strategy as done earlier by Liliana, and remove the vscode
>> icons entirely. If the icons are actually licensed under an
>> unproblematic license, it would be nice if they were installed when
>> running `guix install emacs-lsp-treemacs', and the license property
>> of the package updated to reflect this fact.
> From what I could gather, vscode-icons [1] are actually CC-BY, but used
> without proper attribution in this package. As for why they're unused,
> I mostly forgot to whitelist them.
>
> Cheers
>
> [1] https://github.com/microsoft/vscode-icons
Fixed + pushed to master in #61649 / 3f222cd5ad,
closing this issue.
- Jelle
prev parent reply other threads:[~2023-03-06 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 1:06 bug#61497: emacs-lsp-treemacs unused leftover icons in sources Jelle Licht
2023-02-14 19:24 ` Liliana Marie Prikler
2023-03-06 14:15 ` Jelle Licht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leka0xw2.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=61497-done@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).