From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kCrKGyTbYWdO5AAAe85BDQ:P1 (envelope-from ) for ; Tue, 17 Dec 2024 20:12:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kCrKGyTbYWdO5AAAe85BDQ (envelope-from ) for ; Tue, 17 Dec 2024 21:12:20 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=GFlIfi0e; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=cmY7Jzwl; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734466340; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vKSARIDwng3CgSgv0tRzjDN2EoR5Rcd1EEaqgBmAWxA=; b=UAqxtXr23fCNKtMfWdVwuMhnSvf0+RIRSRpMbzfpiztTmLD1pTR58xAcXi3x9U542w+TFq khWNwkJ0pzEVNhKmfI/Tjt407wt0tubmMK1tKQP7vVamsI0WLKwkx/5optTg5q4XvDDdHM pi0kBRrveLXsL8mqz+CpQCXB1/35BXHDHKSeszJDdpVgnTjXtaxedmzCAseUL2Pa+cVJPO TPUMxlyF/i8AxiEfoY9HO/o8tA6uso855xOhtuUhuSJbaygSndE2i86WVGENoCriRWOCmL WA79zOAmcF+B8yQceoW8GH0AXdqhPnqjQuO2JZc+UmhsGaTkkSeg0KP3oztbaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=GFlIfi0e; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=cmY7Jzwl; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734466340; a=rsa-sha256; cv=none; b=BA1gFOVF4E3C4NjK8HnYSpOjEGFJp7TJqNBcGGKJbPP6kV/kucHy3GMxmyq7BaqFRIelpo X/epUbO7vQtiu++OerWrQEtvB97r7DJXiTqKAl6KKjpwly2/CmeAy5lq1fahwfqvXg0k+t qu2/5HOW3o8e6ePlIRdOGGDFA8lxqXNAnSmgTslmdaWYJM4dT4+AK17dLQVezEu1Sx/7Zs AlNljPd/cKmOllJbJnEWQ7LUsnjDjCqEKCJO3tWJBxqQzTdCMy1jpCZkTkotEzTCWDQogm oqnGqyQ8UNRtziGJhQSqj3heJgAG8Me4gzbJkdnFXOJE4IjPPOI4iUFkhIY7Ng== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6173330990 for ; Tue, 17 Dec 2024 21:12:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNbzK-0000zR-2Q; Tue, 17 Dec 2024 13:08:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNbzH-0000zJ-7x for bug-guix@gnu.org; Tue, 17 Dec 2024 13:08:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNbzG-0005jB-UA for bug-guix@gnu.org; Tue, 17 Dec 2024 13:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=vKSARIDwng3CgSgv0tRzjDN2EoR5Rcd1EEaqgBmAWxA=; b=GFlIfi0eoval0MAfFIl+lr9qXk+/umN27GNfaxfNoPGDO9eYWCwQqJZl58PpB8Rx/NpfA6hq5ISXak03nZRFqXOo/FpWp56SriZeRds1WCRTySWooCCHyY+/gX4D1EqbGHltRIxX4HQGubp8fKiZ6OZUCBZFJLesSyTxqv7I3wmkoeZ1pk0PvcHFZITde4GLJiKFnCb5DDnm1HMewwsWqimVsqFhApbNV08DdQBVvNhhasH/u5heTN9CKlF656ToDgeGBBqOrGjL7DFTA/Jy0qC0eHlGr24jZKeQa0tEXgG0L4Su56WsM08JwepGPUrWSAfrG38ovvjKWX7m83s88A==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNbzG-0005ZJ-Hi for bug-guix@gnu.org; Tue, 17 Dec 2024 13:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#67241: [PATCH] guix-install.sh: Add message about Info reader. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 17 Dec 2024 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67241 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 67241@debbugs.gnu.org Received: via spool by 67241-submit@debbugs.gnu.org id=B67241.173445884921337 (code B ref 67241); Tue, 17 Dec 2024 18:08:02 +0000 Received: (at 67241) by debbugs.gnu.org; 17 Dec 2024 18:07:29 +0000 Received: from localhost ([127.0.0.1]:60208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNbyj-0005Y5-8Q for submit@debbugs.gnu.org; Tue, 17 Dec 2024 13:07:29 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:55427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNbyh-0005Xr-06 for 67241@debbugs.gnu.org; Tue, 17 Dec 2024 13:07:27 -0500 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-37ed3bd6114so2750564f8f.2 for <67241@debbugs.gnu.org>; Tue, 17 Dec 2024 10:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734458781; x=1735063581; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vKSARIDwng3CgSgv0tRzjDN2EoR5Rcd1EEaqgBmAWxA=; b=cmY7Jzwl44tIV2Z7NaxMrfYFTBjHoUYfiHwEc+uJ1XpUsNEjWaJEvKO2k/z4QLhb13 9KgJt1RMCH7R1kQ0Fhf+IcnXnvT+sorcOtpmcbOdHbccgNAn6E7NB7XfjpBhMT6HCOb5 zHeqeEdRmunsv6hvWHNDB8LBwKbPzbugVpXfhQHHPwdwiY52yrufo9ZkwJm+sQg6v5mK vru9SHKihZpUrZk3v2pq9qCpSBs4r95lLO98/zwj41M+px8w8scs5NBsBv+tMh1CGLu3 ircf/pbvleWATj6fWda9y8zGfa2hRBVAqo0tbWg0tBBtvQ528ZwZ8rkzUsLGAMBdmJuH Tj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734458781; x=1735063581; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vKSARIDwng3CgSgv0tRzjDN2EoR5Rcd1EEaqgBmAWxA=; b=PpXh6jz7uw/LdbaBuurEAkqF8OIXsCae9ZFPmQSk4m/eyNdqqadlPSlxQgQG2rzVrT TZZbIihrbVZYUWgTXAoyfR/qllLr7n0CMnHJWFoIJI95dmEI6oL6jUlJsXFvLPrEpHZl 9sVhtZ8pPaIODEHa84VeWeedRogimACwRzBbi0OARtcsQsrKIcUnrMBN4LrIlvo0QWBU fRSUh9KfzRd62Ia9hv3on7bteXLOOdpauGDNfjFTDux5xRX64Q/riw1ha4vBBuYQqFRW agN3LhxrNU2yhuEd6QBoNO6ccSoZGCRWixRKaLIjf++++KJv2WxbwdXt+HXjV1qbhKsW 786A== X-Gm-Message-State: AOJu0YycE8b6aj4JMJizZKb3h4FDYiwpjgjjzAPUNTZFTOzRLgdZou8W /3RwatVB9wDxaKzW9TxJIB8TrAEQZOfWjmRMVF40osV9SDyw319g+QDmew== X-Gm-Gg: ASbGncu+Uie4rNbA6q0sq3yFVjKhSXsvEhK+cQ1wsZkgow+SKCWeDy0eT+jIEcnfaU1 Tw3OIWLj8dI5ZS3DK+LCb4kMaMKS8XbpLOGrwrGAOrnR/xSf2aaPR6ReV2bOLtxilPoKNsU69in /h6MMgZBqAefNllxg6f+NsYIvspoWHwJMuHfqU5xXwrWnLYsNIumaopPIyxXFWQtSQDVdoZ75UQ rFPx220MRyk8xg6nNJ2p2dpmccH6GsMPUSMZYAMUNw1NiPwMaBpoqne4y3LcToP/3tENkUNDBWH 6J5RFCRP X-Google-Smtp-Source: AGHT+IEC8xkKf/Wl3rHrngoxjkldxjSbKUod43H+/M/N3SpxyJDZTYaGBPDDgVjj490dMaYtm0vwHw== X-Received: by 2002:a5d:64a8:0:b0:385:f349:ffef with SMTP id ffacd0b85a97d-3888e0b8723mr15751849f8f.41.1734458780877; Tue, 17 Dec 2024 10:06:20 -0800 (PST) Received: from lili (33.148.22.93.rev.sfr.net. [93.22.148.33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8046c05sm11979269f8f.73.2024.12.17.10.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 10:06:20 -0800 (PST) From: Simon Tournier In-Reply-To: <87r068uyn5.fsf@gmail.com> References: <87h68d6k4e.fsf@gmail.com> <87r068uyn5.fsf@gmail.com> Date: Mon, 16 Dec 2024 18:58:58 +0100 Message-ID: <87ldwf7bml.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -3.86 X-Spam-Score: -3.86 X-Migadu-Queue-Id: 6173330990 X-TUID: 5/5Mvckx1ze9 Hi Maxim, On Mon, 16 Dec 2024 at 11:53, Maxim Cournoyer w= rote: >> +_info() >> +{ >> + if [ "$(type -P info)" ]; then >> + _msg "$1" >> + else >> + _msg "${WAR}Please install Info reader; see package 'info-reade= r'" >> + _msg "$1" >> + fi >> +} > > It seems odd to me to "overload" _msg into _info that deals with some side > effect; I'd rather see this conditional explicit at the message printing > site. It was to avoid the duplication of the exact same conditional with the exact same message. I do not have an opinion=E2=80=A6 > Also, your test is testing for the empty string when info is not found, > not the exist status, which is wrong. Please note that the script already uses: if [ "$(type -P pidof)" ]; then if [ ! "$(pidof nscd)" ]; then And I have only respected the same. :-) > not the exist status, which is wrong. I think you meant something like: > > --8<---------------cut here---------------start------------->8--- > if type -P info >/dev/null then [...]; fi > --8<---------------cut here---------------end--------------->8--- Well, I am not a Bash expert but I guess that=E2=80=99s the same result in practise, no? Both $() and "" used in tandem makes the test sound, from my understanding. > But this got me curious again... could we instead automate the > installation of info post-installation? It appears to me unrelated to this change at hand. :-) > If yes, we should also automate > the installation of glibc-locales, using prompts that the user can > accept or decline like for the other configuration choices. Yeah why not, but let open another issue for tracking that, because that=E2=80=99s not necessary straightforward since it=E2=80=99s on the top = of different distros. Cheers, simon