From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#18994: [PATCH] Preserve supplementary groups of build users
Date: Wed, 01 Jul 2015 16:54:00 +0200
Message-ID: <87k2ukornb.fsf__2521.32986574924$1435762700$gmane$org@gnu.org>
References: <87ppcxsse0.fsf@gnu.org> <87vbe4w8a4.fsf@gnu.org>
	<5593E431.70200@logicblox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJPn-0005EJ-FF
	for bug-guix@gnu.org; Wed, 01 Jul 2015 10:55:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJPk-0003rV-0V
	for bug-guix@gnu.org; Wed, 01 Jul 2015 10:55:07 -0400
Received: from debbugs.gnu.org ([140.186.70.43]:34700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJPj-0003qU-RJ
	for bug-guix@gnu.org; Wed, 01 Jul 2015 10:55:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAJPj-0008TP-Cz
	for bug-guix@gnu.org; Wed, 01 Jul 2015 10:55:03 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.18994.B18994.143576246132515@debbugs.gnu.org>
In-Reply-To: <5593E431.70200@logicblox.com> (Eelco Dolstra's message of "Wed,
	01 Jul 2015 14:59:29 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Eelco Dolstra <eelco.dolstra@logicblox.com>
Cc: 18994@debbugs.gnu.org, nix-dev@lists.science.uu.nl

Hi Eelco,

Eelco Dolstra <eelco.dolstra@logicblox.com> skribis:

> On 01/07/15 11:12, Ludovic Court=C3=A8s wrote:
>
>>> Currently, the build environment made by the daemon does not preserve
>>> supplementary groups of the build users.
>>>
>>> Thus, even though the standalone Guix system sets /dev/kvm 660, owned by
>>> root:kvm, and adds the build users to the kvm group, build users are
>>> unable to access it.
>>=20
>> The following patch is an attempt to address this bug (see
>> <http://bugs.gnu.org/18994>) by preserving the supplementary groups of
>> build users in the build environment.
>>=20
>> In practice, I would expect that supplementary groups would contain only
>> one or two groups: the build users group, and possibly the =E2=80=9Ckvm=
=E2=80=9D group.
>
> Applied, thanks!

Excellent, thank you!

Ludo=E2=80=99.