unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Eelco Dolstra <eelco.dolstra@logicblox.com>
Cc: 18994@debbugs.gnu.org, nix-dev@lists.science.uu.nl
Subject: bug#18994: [PATCH] Preserve supplementary groups of build users
Date: Wed, 01 Jul 2015 16:54:00 +0200	[thread overview]
Message-ID: <87k2ukornb.fsf__2521.32986574924$1435762700$gmane$org@gnu.org> (raw)
In-Reply-To: <5593E431.70200@logicblox.com> (Eelco Dolstra's message of "Wed, 01 Jul 2015 14:59:29 +0200")

Hi Eelco,

Eelco Dolstra <eelco.dolstra@logicblox.com> skribis:

> On 01/07/15 11:12, Ludovic Courtès wrote:
>
>>> Currently, the build environment made by the daemon does not preserve
>>> supplementary groups of the build users.
>>>
>>> Thus, even though the standalone Guix system sets /dev/kvm 660, owned by
>>> root:kvm, and adds the build users to the kvm group, build users are
>>> unable to access it.
>> 
>> The following patch is an attempt to address this bug (see
>> <http://bugs.gnu.org/18994>) by preserving the supplementary groups of
>> build users in the build environment.
>> 
>> In practice, I would expect that supplementary groups would contain only
>> one or two groups: the build users group, and possibly the “kvm” group.
>
> Applied, thanks!

Excellent, thank you!

Ludo’.

      parent reply	other threads:[~2015-07-01 14:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-08 14:01 bug#18994: Daemon does not preserve supplementary groups of build users Ludovic Courtès
2015-07-01  9:12 ` bug#18994: [PATCH] Preserve " Ludovic Courtès
     [not found] ` <87vbe4w8a4.fsf@gnu.org>
2015-07-01 12:59   ` Eelco Dolstra
     [not found]   ` <5593E431.70200@logicblox.com>
2015-07-01 14:54     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87k2ukornb.fsf__2521.32986574924$1435762700$gmane$org@gnu.org' \
    --to=ludo@gnu.org \
    --cc=18994@debbugs.gnu.org \
    --cc=eelco.dolstra@logicblox.com \
    --cc=nix-dev@lists.science.uu.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).