From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#18994: [nix] Preserve supplementary groups of build users
	(9aed117)
Date: Wed, 01 Jul 2015 23:10:52 +0200
Message-ID: <87k2ujmvmr.fsf@gnu.org>
References: <NixOS/nix/commit/9aed117395f6fd6c4d24a81a6b66994e75311f5e@github.com>
	<NixOS/nix/commit/9aed117395f6fd6c4d24a81a6b66994e75311f5e/11960324@github.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAPIc-0003U3-N8
	for bug-guix@gnu.org; Wed, 01 Jul 2015 17:12:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAPIZ-0006k2-6C
	for bug-guix@gnu.org; Wed, 01 Jul 2015 17:12:06 -0400
Received: from debbugs.gnu.org ([140.186.70.43]:35011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAPIZ-0006ji-3a
	for bug-guix@gnu.org; Wed, 01 Jul 2015 17:12:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZAPIY-0007Rh-Ok
	for bug-guix@gnu.org; Wed, 01 Jul 2015 17:12:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.18994.B18994.143578507128558@debbugs.gnu.org>
In-Reply-To: <NixOS/nix/commit/9aed117395f6fd6c4d24a81a6b66994e75311f5e/11960324@github.com>
	(Charles Strahan's message of "Wed, 01 Jul 2015 12:03:24 -0700")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Charles Strahan <notifications@github.com>
Cc: 18994@debbugs.gnu.org, NixOS/nix <reply+0011d43327cde66fa384a8345ffe1205d196179a23d7e9d092cf0000000111abfb7c92a163ce00b68004@reply.github.com>, NixOS/nix <nix@noreply.github.com>

Charles Strahan <notifications@github.com> skribis:

> Is there any reason we immediately throw here, instead of checking `ngrou=
ps`, resizing the buffer accordingly, and then rerunning `getgrouplist`? I =
would think that would be a bit more robust.

Sorry, could you quote the code you=E2=80=99re referring to?

If you talking about the =E2=80=98getgrouplist=E2=80=99 call, maybe we coul=
d do that,
but we would still need to put a hard limit on the maximum number of
groups anyway.

WDYT?

Thanks,
Ludo=E2=80=99.

PS: Please keep 18994@debbugs.gnu.org Cc=E2=80=99d.